From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH RFC] checkpatch: add new exceptions to repeated word check
Date: Tue, 13 Oct 2020 00:43:33 +0530 [thread overview]
Message-ID: <CABJPP5BrrqFh=e6Qiy8=PLB+26uenBkyTgShcD9qeHaLVZiqFw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2010122053210.17866@felia>
> > I did run an evaulation for the single letter case
> > and though it caught one of the lurking 'a's, like in:
> >
> > commit 8d90822643ad ("crypto: engine - support for batch requests")
> >
> > WARNING:REPEATED_WORD: Possible repeated word: 'a'
> > #53: FILE: crypto/crypto_engine.c:472:
> > + * @cbk_do_batch: pointer to a callback function to be invoked when executing a
> > + * a batch of requests.
> >
> >
> > But yikes, it introduced new false positive:
> >
> > commit 6514b25d3fba ("lpfc: Refactor Send LS Request support")
> >
> > WARNING:REPEATED_WORD: Possible repeated word: 'x'
> > #156: FILE: drivers/scsi/lpfc/lpfc_nvme.c:614:
> > + "Data: x%x x%x rc x%x\n",
> >
> > It's probably a bad idea to allow single lettered checking. :-[
> >
>
> Yeah, I feared that...
>
> I agree single letter checking is probably not a good idea if we do not
> refine that even more.
>
> Maybe, we put that aside for now and look at other potential improvements.
>
>
> Lukas
Yeah sure, so just quickly sending out the small patch for git modification.
Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-12 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 6:43 [Linux-kernel-mentees] [PATCH RFC] checkpatch: add new exceptions to repeated word check Dwaipayan Ray
2020-10-11 7:00 ` Dwaipayan Ray
2020-10-11 17:37 ` Lukas Bulwahn
2020-10-11 17:42 ` Dwaipayan Ray
2020-10-12 18:34 ` Dwaipayan Ray
2020-10-12 18:56 ` Lukas Bulwahn
2020-10-12 19:13 ` Dwaipayan Ray [this message]
2020-10-11 17:36 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABJPP5BrrqFh=e6Qiy8=PLB+26uenBkyTgShcD9qeHaLVZiqFw@mail.gmail.com' \
--to=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).