From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53DB7C4363D for ; Wed, 23 Sep 2020 07:39:06 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6330B214D8 for ; Wed, 23 Sep 2020 07:39:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BujE1Z7C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6330B214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E84D922F05; Wed, 23 Sep 2020 07:39:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t1mzoioQuFoY; Wed, 23 Sep 2020 07:39:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 96FFA22E96; Wed, 23 Sep 2020 07:39:03 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 74A8CC0889; Wed, 23 Sep 2020 07:39:03 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4C38AC0051 for ; Wed, 23 Sep 2020 07:39:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3667422EC1 for ; Wed, 23 Sep 2020 07:39:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MGyvwNhlEoH0 for ; Wed, 23 Sep 2020 07:39:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by silver.osuosl.org (Postfix) with ESMTPS id 4EF5B22E96 for ; Wed, 23 Sep 2020 07:39:01 +0000 (UTC) Received: by mail-ot1-f45.google.com with SMTP id m13so13595080otl.9 for ; Wed, 23 Sep 2020 00:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IRmAjmuBLRDlHafKwUOWp9wh3KDYL9aLonW8el9ifAQ=; b=BujE1Z7ClsLcmM8DLzZOBufZ1ncWU0cnM6vpK7K3B3IiB94FMwQOm64dWHD9u3HUns lLvJZhWANoMrjuqBcAzNHbu3liYPnzAquHn+Xs3iap/rbcB6B8j2Cp8335HHs0RtFEr+ scqkN9uS+yrDzJ8oGM1YVGNE+OHV+nx9anv7Ygx8V1rzgYifAcqmOgsEgjCZ82uUTXAk P/1P7Xm/hyL9E0v+vJBiXwIdPXRjKkw+bk2npc/n4pcEoN0cnmpNE2pzloy4UAsDVZGu 5tuMvSuUR+2q7+LyGMhzdHvIfQCg/yh9kRclCY9fe8Hk0nZI5kwK/Z5udl/LTr1ayEYx C/Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IRmAjmuBLRDlHafKwUOWp9wh3KDYL9aLonW8el9ifAQ=; b=JUaEsR57QlSj204WioREUBNHmIuirGG7q1L2ikLQRlvp8XGF5EfKkScdEQRdH97dQR Xy2VbuALC6yGUl7Kvdpgr5e4V9dO2XXfTDodVNnFR6ky7o36fC3edmvAKsFZJwgXk+iS ukKxQlConmBr/NYV59QvnowNuaaJE6nm92jYIOTm6I4He4IGCFFFFkKCOlF1wdn8n4lX 05ojg3J1lHJ9v2XiXgDkhpD/Bl/pttE3WLoRIz+AMRd66T+A4Lec7vjuirnu8B1mrL0F H0Dj8orxsVQeUfa6YHPG7kWsUS6qy7qivHAEuk9nscWxlq1zTq8ZdshRY3bciw2/UK+1 7zgQ== X-Gm-Message-State: AOAM533mU3cxnKSMZz71ma/ejWQlnOtzvjK0ZRONGZ07/TzHm0lbf3VR OXQbmVe3YB/jnkzFHtZc2f9YGwQJZtObr+mM6/c= X-Google-Smtp-Source: ABdhPJy8xuzeWpFLGYpNx3utnCEl0ZDrTKu8xrDsAQq3bFgKLY+GgAamtt/c8HBePiLvgtxc895POT/PqDqF/qjUOzM= X-Received: by 2002:a05:6830:c4:: with SMTP id x4mr5617448oto.30.1600846740241; Wed, 23 Sep 2020 00:39:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dwaipayan Ray Date: Wed, 23 Sep 2020 13:08:40 +0530 Message-ID: To: Lukas Bulwahn Cc: linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] checkpatch.pl investigation: NO_AUTHOR_SIGN_OFF issues X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" > > Hi, > > As for the lk_path, it can be removed easily. To me too, it didn't make much > > sense since it was just a duplicate, as $root should contain the same. > > > > But again due to some reason, > > $root in checkpatch had the value ".", > > while $lk_path in get_maintainer had the value "./" > > > > I have no idea yet if this was a design decision or just different handling. > > > > So, I can change the part where I referenced the mailmap file by adding > > a trailing / with $root rather than $lk_path. That should do it. > > > > And for the duplicate code part, Joe did mention that either I could copy > > or place the read_mailmap code in a separate file and reference both > > checkpatch and get_maintainers from there. > > > > To me, copying seems much feasible because the referenced part of the > > mailmap handling code here is very small as there are some minor > > changes. > > > > Well, if you can argue copying code, it is fine. Go ahead and send out a > RFC patch. > I definitely know that redundant code is a bad practice. But yes, I would send a patch in with a proper commit message to get yours and Joe's comments. > Regarding the mentorship, would you have time for some virtual > face-to-face meeting to discuss the Eligibility Criteria and Mentorship > Models? > > > Lukas Yes sure, what time are you available? I don't have any more classes today so I am free. Thanks, Dwaipayan. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees