From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0781CC433E2 for ; Thu, 17 Sep 2020 13:09:36 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 696A621582 for ; Thu, 17 Sep 2020 13:09:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pAUzrYsg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 696A621582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0581A87606; Thu, 17 Sep 2020 13:09:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id epaTuulm6J8L; Thu, 17 Sep 2020 13:09:32 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 50E6F875FF; Thu, 17 Sep 2020 13:09:32 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 44DBEC0864; Thu, 17 Sep 2020 13:09:32 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7A254C0051 for ; Thu, 17 Sep 2020 13:09:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 6867987600 for ; Thu, 17 Sep 2020 13:09:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GRwGO2ACthtm for ; Thu, 17 Sep 2020 13:09:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by hemlock.osuosl.org (Postfix) with ESMTPS id 7DC13875FF for ; Thu, 17 Sep 2020 13:09:29 +0000 (UTC) Received: by mail-oi1-f176.google.com with SMTP id x69so2376920oia.8 for ; Thu, 17 Sep 2020 06:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=An2RDFVNHCh0mUzSn4u3T8b4tHmZPQVYjNiRpRZnOGc=; b=pAUzrYsgXv90W4cRvCzM8ZhbtTaz2RJEoXRnPQXIYDv6rWoF+6YBz+gOQfQApse/od Y45e9pPqPmQHhhMcgxsvDAsmgeplqjhKmozPQFj4/44MqtvStNfkioL23/3FFZEbi08E /rLPow2psOBqwkUDpMSuwaL3d/SMRWZYvWvhv8mgrlt4jnyQyrRHdD/DI171MjRCKlcL UShDLhy8Yo9TXkv2Y+5ZSzDkzEJS9bqUe9evO9rQC/0qPAlRt+ttSYQQDTNqzWOpIVJt SfFZfuKUOIs+mqA85z74a5Jb3HLKRvryvgbB6s/dOQRqg4yzdJv9thp1+l31TR0Mw/Wd XB/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=An2RDFVNHCh0mUzSn4u3T8b4tHmZPQVYjNiRpRZnOGc=; b=NEDiZfuqP0ppywfbm3ig1x81zCLaCSO8KKT9fXt4FH4CW9sDH8uovxKGIv47eqpAek qJ4GLOJ2K1aG/I7W6SaHkQowVtG5BIFklsqjm0zmrZXdV24urOYuNY5aDAkuljKUo0rk P3PrPVdCRFAGfWNwUw4Miqk5MOYbIPG6dz5m5HKKDzb3qAD4w010ohKVmlvQn2hhVDVT 9O0SOWGO1YhpuDmaxwWcfPGKZvf6smEzGlns97ScPrj3OvMWskdnjwKh11g2iCQnBZ50 svkXACvDRc3EX6OKI8La0H9yIvn++RiBptqNsMsfh79Ohv7yQnl9B3l2L37lhyJTAyzs JqzQ== X-Gm-Message-State: AOAM532KBSGryv4QtD1q+07cYwOS/Qdom1eIZYmnC23Qh9u1l63JAOqn debLCjr706rqEYRADfOLs62iHafqt+7vjvHW/mE= X-Google-Smtp-Source: ABdhPJwD4JNMHY63CrpjPBEDXopSFnSIHuw6vo11QIwqljku9LZE5QP/9gngx9WcR6oleS3zWYywcupi76dkUfICBGE= X-Received: by 2002:aca:b2d7:: with SMTP id b206mr6068474oif.110.1600348168382; Thu, 17 Sep 2020 06:09:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dwaipayan Ray Date: Thu, 17 Sep 2020 18:39:10 +0530 Message-ID: To: Lukas Bulwahn Cc: linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] Linux kernel checkpatch.pl mentorship X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0833352922240351334==" Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" --===============0833352922240351334== Content-Type: multipart/alternative; boundary="00000000000017f02f05af8218b3" --00000000000017f02f05af8218b3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > If you do your homework, proper research what was decided in the past, > proper evaluations what the difference of your change is, proper > implementation, proper arguments for your change, it has high chances of > being accepted. Many agree that checkpatch.pl can be useful, but many > agree that it needs some improvements. > > It is certainly not a quick improvement, and needs some thought to make i= t > really better. > > > > > > You can try to work that through or look for another case of potentia= l > > > checkpatch.pl improvement in your evaluation data. > Hi, I would like to report you another finding about AUTHOR_SIGN_OFF. I found that some commits with the same author mail and sign off mail also threw off this warning when there were non-ascii characters in the name. Let me give some examples: Commit 9d9cc58aff46 : Author: =E5=91=A8=E7=90=B0=E6=9D=B0 (Zhou Yanjie) ..... Signed-off-by: =E5=91=A8=E7=90=B0=E6=9D=B0 (Zhou Yanjie) As you can see, there should have been no error message, but checkpatch gave this: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author '' Also commit 440d7a6f7390 and commit 424c85e1ffea by the same person threw the error again. Evidently non ascii characters cause the parsing to fail. Both had the same chinese characters in the name. I also found another person with the same issue. Commit b03628b73564 Author: Niklas S=C3=B6derlund ... Signed-off-by: Niklas S=C3=B6derlund Checkpatch gave the warning: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author '' . The string here is again empty. Another same issue Commit f0a087a533b3 Author: Vesa J=C3=A4=C3=A4skel=C3=A4inen ... Signed-off-by: Vesa J=C3=A4=C3=A4skel=C3=A4inen So you see in all these cases non ascii characters are present. I looked into checkpatch.pl . line 2662: if (decode("MIME-Header", $line) =3D~ /^From:\s*(.*)/) { $author =3D $1; $author =3D encode("utf8", $author) if ($line =3D~ /=3D\?utf-8\= ?/i); $author =3D~ s/"//g; $author =3D reformat_email($author); } When i looked into $line, it gave below: From: =3D?UTF-8?q?=3DE5=3D91=3DA8=3DE7=3D90=3DB0=3DE6=3D9D=3DB0=3D20=3D28Zh= ou=3D20Yanjie =3D29?=3D And at the end of this block, $author was equal to ''. There seems to be a parsing problem there. Does this seem like a proper fixable candidate? Thanks, Dwaipayan. --00000000000017f02f05af8218b3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


> If you do your homewo= rk, proper research what was decided in the past,
> proper evaluation= s what the difference of your change is, proper
> implementation, pro= per arguments for your change, it has high chances of
> being accepte= d. Many agree that checkpatch.pl can b= e useful, but many
> agree that it needs some improvements.
>> It is certainly not a quick improvement, and needs some thought to m= ake it
> really better.
>
> >
> > > You ca= n try to work that through or look for another case of potential
> &g= t; > checkpatch.pl improvement in y= our evaluation data.
>=C2=A0
<= br>
Hi,
I would like to report you another finding about AUTHOR_SIGN= _OFF.

I found that some commits with the same author mail and s= ign off mail=C2=A0
also threw=C2= =A0off this warning when there were= non-ascii characters in
= the name.
Let me give some example= s:

Commit=C2=A09d9cc58aff46 :

A= uthor: =E5=91=A8=E7=90=B0=E6=9D=B0 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
....= .
Signed-off-by: =E5=91=A8=E7=90=B0=E6=9D=B0 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>= ;

As you can see, there should have been no er= ror message, but checkpatch
gave this:

W= ARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal
=C2=A0patch author ''


= Also commit=C2=A0440d7a6f7390 and commit=C2=A0424c85e1ffea by the same pers= on=C2=A0
threw the error again. Evidently non ascii characters ca= use the parsing to fail.
Both had the same chinese characters in = the name.


I also found another pers= on with the same issue.
Commit=C2=A0b03628b73564
Author= : Niklas S=C3=B6derlund <niklas.soderlund+renesas@ragnatech.se>
...=
Signed-off-by: Niklas S=C3=B6derlund <niklas.soderlund+renesas@ragnatech.se>

= WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal=C2=A0
patch author '' . The string here is again empty.
=

Another same issue
Commit=C2=A0f0a087a533b3
Author:=C2=A0Vesa J=C3=A4=C3=A4skel=C3=A4inen <vesa.jaaskelainen@vaisala.com>
...
Signed-off-by: Vesa J=C3=A4=C3=A4skel=C3=A4inen <vesa.jaaskelainen@vaisala.com= >

So you see in all these cases non asc= ii characters are present. I looked=C2=A0

line 2662:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (decode("MIME-Header", $line= ) =3D~ /^From:\s*(.*)/) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$auth= or =3D $1;=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $author =3D e= ncode("utf8", $author) if ($line =3D~ /=3D\?utf-8\?/i);
=C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $author =3D~ s/"//g;
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $author =3D reformat_email($author);=C2=A0<= br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

When i looked= into $line, it gave below:
From: =3D?UTF-8?q?=3DE5=3D91=3DA8=3DE= 7=3D90=3DB0=3DE6=3D9D=3DB0=3D20=3D28Zhou=3D20Yanjie
=3D29?=3D=C2= =A0<zhouyanjie@wanyeetech.c= om>

And at the end of this block, $auth= or was equal to ''.
There seems to be a parsing problem t= here.

Does this seem like a proper fixable candida= te?

Thanks,
Dwaipayan.
--00000000000017f02f05af8218b3-- --===============0833352922240351334== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees --===============0833352922240351334==--