From: Mrinal Pandey <firstname.lastname@example.org>
To: Lukas Bulwahn <email@example.com>,
Shuah Khan <firstname.lastname@example.org>
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: Fix the usage of capture group ( ... )
Date: Sun, 12 Jul 2020 10:48:37 +0530 [thread overview]
Message-ID: <CAD1=X6kLBAAMqMH+bZipagmVq4XHx4LOVB=yUb1J870NgXMCUg@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 883 bytes --]
On Sun, Jul 12, 2020 at 12:44 AM Lukas Bulwahn <email@example.com>
> On Sat, Jul 11, 2020 at 5:44 PM Mrinal Pandey <firstname.lastname@example.org> wrote:
>> The usage of "capture group (...)" in the immediate condition after `&&`
>> results in `$1` being uninitialized. This eventually crashes the script.
> It does not really crash it, right? It just emits a warning.
Yes. I will modify the line accordingly.
>> Fix this by placing the capture group in the condition before `&&`.
>> Thus, `$1` can be initialized to the text it matches thereby setting it
>> to the desired and required value.
> Maybe you can look when this bug was introduced?
The bug was first introduced with the commit `e518e9a59ec3` when the block
added to the script. It has been like that since then.
Should I add this detail too in the commit message?
[-- Attachment #1.2: Type: text/html, Size: 2168 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
Linux-kernel-mentees mailing list
next prev parent reply other threads:[~2020-07-12 5:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 15:44 [Linux-kernel-mentees] [PATCH] checkpatch: Fix the usage of capture group ( ... ) Mrinal Pandey
2020-07-11 19:14 ` Lukas Bulwahn
2020-07-12 5:18 ` Mrinal Pandey [this message]
2020-07-12 7:18 ` Lukas Bulwahn
2020-07-12 12:19 ` Mrinal Pandey
2020-07-12 17:36 ` Lukas Bulwahn
2020-07-13 4:32 Mrinal Pandey
2020-07-13 19:31 ` Lukas Bulwahn
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).