From: Mrinal Pandey <email@example.com>
To: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org,
Lukas Bulwahn <email@example.com>,
Shuah Khan <firstname.lastname@example.org>,
Subject: Re: [Linux-kernel-mentees] [PATCH v2] checkpatch: Fix the usage of capture group ( ... )
Date: Tue, 14 Jul 2020 13:07:03 +0530 [thread overview]
Message-ID: <CAD1=X6kVo26OT2jaPu-D_MremS75=+6U7nrXw89xFbo255pbhg@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 2676 bytes --]
On Tue, Jul 14, 2020 at 11:18 AM Lukas Bulwahn <email@example.com>
> On Tue, 14 Jul 2020, Mrinal Pandey wrote:
> > The usage of "capture group (...)" in the immediate condition after `&&`
> > results in `$1` being uninitialized. This issues a warning "Use of
> > uninitialized value $1 in regexp compilation at ./scripts/checkpatch.pl
> > line 2638".
> > I noticed this bug while running checkpatch on the set of commits from
> > v5.7 to v5.8-rc1 of the kernel on the commits with a diff content in
> > their commit message.
> > This bug was introduced in the script by commit e518e9a59ec3
> > ("checkpatch: emit an error when there's a diff in a changelog"). It has
> > been in the script since then.
> > The author intended to store the match made by capture group in variable
> > `$1`. This should have contained the name of the file as `[\w/]+`
> > However, this couldn't be accomplished due to usage of capture group and
> > `$1` in the same regular expression.
> > Fix this by placing the capture group in the condition before `&&`.
> > Thus, `$1` can be initialized to the text that capture group matches
> > thereby setting it to the desired and required value.
> > Reviewed-by: Lukas Bulwahn <firstname.lastname@example.org>
> > Tested-by: Lukas Bulwahn <email@example.com>
> > Signed-off-by: Mrinal Pandey <firstname.lastname@example.org>
> > ---
> > Changes since v1:
> > Add Reviewed-by and Tested-by tag
> Usually, the maintainers pick up those tags when they apply a patch to
> their tree, and the patch authors do not need to add those tags and resend
> the patch as a new version on the mailing list.
Thank you for your insight. I'll keep this in mind.
> Mrinal, can you please go through and check the kernel documentation on
> submitting patches and find the places where it is pointed out that the
> maintainers usually apply those tags and the authors usually do not need
> to resend a new version of the patch with the tags applied?
I read through Submitting patches
and a few related pieces of documentation but
couldn't infer this information.
> If you cannot find such a statement in the documentation, please let us
> know where it would ideally added in the documentation. We can then create
> a patch for that together.
The statement might be placed under Respond to review comments
it could further contain some information about how to send a new version
of the patch.
[-- Attachment #1.2: Type: text/html, Size: 4200 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
Linux-kernel-mentees mailing list
next prev parent reply other threads:[~2020-07-14 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 3:23 [Linux-kernel-mentees] [PATCH v2] checkpatch: Fix the usage of capture group ( ... ) Mrinal Pandey
2020-07-14 5:47 ` Lukas Bulwahn
2020-07-14 7:37 ` Mrinal Pandey [this message]
2020-07-30 5:58 ` Lukas Bulwahn
2020-07-30 7:31 ` Joe Perches
2020-08-20 4:52 ` Mrinal Pandey
2020-08-21 4:25 ` Joe Perches
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).