Linux Kernel Mentees Archive on lore.kernel.org
 help / color / Atom feed
From: Mrinal Pandey <mrinalmni@gmail.com>
To: apw@canonical.com, joe@perches.com, linux-kernel@vger.kernel.org,
	 Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] checkpatch: Fix the usage of capture group ( ... )
Date: Tue, 14 Jul 2020 13:07:03 +0530
Message-ID: <CAD1=X6kVo26OT2jaPu-D_MremS75=+6U7nrXw89xFbo255pbhg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2007140742570.6558@felia>

[-- Attachment #1.1: Type: text/plain, Size: 2676 bytes --]

On Tue, Jul 14, 2020 at 11:18 AM Lukas Bulwahn <lukas.bulwahn@gmail.com>
wrote:

>
>
> On Tue, 14 Jul 2020, Mrinal Pandey wrote:
>
> > The usage of "capture group (...)" in the immediate condition after `&&`
> > results in `$1` being uninitialized. This issues a warning "Use of
> > uninitialized value $1 in regexp compilation at ./scripts/checkpatch.pl
> > line 2638".
> >
> > I noticed this bug while running checkpatch on the set of commits from
> > v5.7 to v5.8-rc1 of the kernel on the commits with a diff content in
> > their commit message.
> >
> > This bug was introduced in the script by commit e518e9a59ec3
> > ("checkpatch: emit an error when there's a diff in a changelog"). It has
> > been in the script since then.
> >
> > The author intended to store the match made by capture group in variable
> > `$1`. This should have contained the name of the file as `[\w/]+`
> matched.
> > However, this couldn't be accomplished due to usage of capture group and
> > `$1` in the same regular expression.
> >
> > Fix this by placing the capture group in the condition before `&&`.
> > Thus, `$1` can be initialized to the text that capture group matches
> > thereby setting it to the desired and required value.
> >
> > Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > Tested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > Signed-off-by: Mrinal Pandey <mrinalmni@gmail.com>
> > ---
> > Changes since v1:
> > Add Reviewed-by and Tested-by tag
> >
>
>
> Usually, the maintainers pick up those tags when they apply a patch to
> their tree, and the patch authors do not need to add those tags and resend
> the patch as a new version on the mailing list.
>

Sir,

Thank you for your insight. I'll keep this in mind.


>
> Mrinal, can you please go through and check the kernel documentation on
> submitting patches and find the places where it is pointed out that the
> maintainers usually apply those tags and the authors usually do not need
> to resend a new version of the patch with the tags applied?
>

I read through Submitting patches
<https://www.kernel.org/doc/html/latest/process/submitting-patches.html>
and a few related pieces of documentation but
couldn't infer this information.


> If you cannot find such a statement in the documentation, please let us
> know where it would ideally added in the documentation. We can then create
> a patch for that together.
>

The statement might be placed under Respond to review comments
<https://www.kernel.org/doc/html/latest/process/submitting-patches.html#respond-to-review-comments>
and maybe
it could further contain some information about how to send a new version
of the patch.

Thank you.

>
>
> Lukas
>

[-- Attachment #1.2: Type: text/html, Size: 4200 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14  3:23 Mrinal Pandey
2020-07-14  5:47 ` Lukas Bulwahn
2020-07-14  7:37   ` Mrinal Pandey [this message]
2020-07-30  5:58 ` Lukas Bulwahn
2020-07-30  7:31   ` Joe Perches
2020-08-20  4:52     ` Mrinal Pandey
2020-08-21  4:25       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD1=X6kVo26OT2jaPu-D_MremS75=+6U7nrXw89xFbo255pbhg@mail.gmail.com' \
    --to=mrinalmni@gmail.com \
    --cc=Linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Kernel Mentees Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kernel-mentees/0 linux-kernel-mentees/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kernel-mentees linux-kernel-mentees/ https://lore.kernel.org/linux-kernel-mentees \
		linux-kernel-mentees@lists.linuxfoundation.org linux-kernel-mentees@lists.linux-foundation.org
	public-inbox-index linux-kernel-mentees

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxfoundation.lists.linux-kernel-mentees


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git