From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1C87C433E4 for ; Sat, 11 Jul 2020 13:40:24 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84CFC20657 for ; Sat, 11 Jul 2020 13:40:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L7l/PpA7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84CFC20657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 6234089337; Sat, 11 Jul 2020 13:40:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fs2awxgpiUsB; Sat, 11 Jul 2020 13:40:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id F311C8928E; Sat, 11 Jul 2020 13:40:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id DE258C077B; Sat, 11 Jul 2020 13:40:22 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 54BA3C016F for ; Sat, 11 Jul 2020 13:40:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3F6D02221F for ; Sat, 11 Jul 2020 13:40:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EoSVFIajEYHg for ; Sat, 11 Jul 2020 13:40:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by silver.osuosl.org (Postfix) with ESMTPS id 6BAF32154B for ; Sat, 11 Jul 2020 13:40:18 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id m22so3791691pgv.9 for ; Sat, 11 Jul 2020 06:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=EmkYOFziLKEeRp41RR6mzBaBzN4MFoR1xwnUW7Lrr6w=; b=L7l/PpA7VsaocSUleIbu3lOO43pogDlPWrrhlrncp4QmuxzyjnQdZFmFZVDR8oTcsf 8wNaSrLIOZxl6S0gnIY6q3FFZxl7H1s6iuRVBZo/MwQQPzCMWV2oblGQBBGufDbZb/C/ 8oNPYabzRUo7qFYFinc0fDZQsreutFqcK2aunbYpaw0XiFq7gfQVhwncetmFI0uuCW+0 z40YVXLaRke/QH7AO6LBsjq/GrPKbyyFDc0KJ9oyXUI1H0Phva9fNfdtbBFLcLRROgk7 l+I7q/HdpX16jCD4NsUlmXa5pYn6Sp0zLRgqsTjJZQcH+N10UUjmbEqtJDO8IDHEYSpN oGlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=EmkYOFziLKEeRp41RR6mzBaBzN4MFoR1xwnUW7Lrr6w=; b=er0J430kDVpwf4wq8YViM/8TxcF03S88/KpRecR8k6oxGZvap3H/GZypZk0b/wSJa1 idDBkc7XTZvITWRFoHiL/Z2vDXOvCQ+wIhM5FWA1krZh9reJYozu8KHYB2XoZpTDVKCR T4oaPbXlEpJCvD3H8UndWNeTihyiTcDeYijJzpr/zykghHll9pax+v7vKaV3FgnXcVXU Yu2JPlvCCYYh4kTUOVMb+8634HK+2m8mbrZTvoR8napAyOhyGH+XUzAf4QjI18LB1lkY mtajXQh67Xx3/RyJk0ldrD3v6xhbgMb8FbwVrzq4pxTGYOxbJNomP4ycGZhn8cy0IDev I5Pg== X-Gm-Message-State: AOAM531k6AoD6pgv4tp/N7K2pyI55UQpzcTO2kQaF68saSNe7aN62Qpx 07UzfEtwgSN6QIMXjELRQQpQn3BnPML2G5gfcFD5qzKqYU0= X-Google-Smtp-Source: ABdhPJxXs/KDx2LgXwSs1LAQKaCGBK+eDeD/2JLGItHjBIH2Q7xT6SvCF9UH32mwVP+HbWT+BgcT5WvcO0Bp8nyAHgc= X-Received: by 2002:a63:140f:: with SMTP id u15mr50417374pgl.94.1594474817841; Sat, 11 Jul 2020 06:40:17 -0700 (PDT) MIME-Version: 1.0 References: <20200706080814.of3oftqsbp32nwge@mrinalpandey> <844f8a74-0a95-216b-3785-79ab161a00e7@linuxfoundation.org> In-Reply-To: From: Mrinal Pandey Date: Sat, 11 Jul 2020 19:10:06 +0530 Message-ID: To: Lukas Bulwahn , Shuah Khan , Linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: Adjust spelling check false positive X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5913242491836430062==" Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" --===============5913242491836430062== Content-Type: multipart/alternative; boundary="0000000000001eede805aa2a99a4" --0000000000001eede805aa2a99a4 Content-Type: text/plain; charset="UTF-8" Okay, sir. On Sat, Jul 11, 2020 at 2:46 AM Lukas Bulwahn wrote: > On Fri, Jul 10, 2020 at 10:46 PM Shuah Khan > wrote: > > > > On 7/10/20 5:26 AM, Mrinal Pandey wrote: > > > On Thu, Jul 9, 2020 at 10:33 AM Lukas Bulwahn > > > wrote: > > > > > > On Thu, Jul 9, 2020 at 6:31 AM Mrinal Pandey > > > wrote: > > > > > > > > On Tue, Jul 7, 2020 at 10:24 PM Lukas Bulwahn > > > > wrote: > > > >> > > > >> On Tue, Jul 7, 2020 at 10:22 AM Mrinal Pandey > > > > wrote: > > > >> > > > > >> > > > > >> > > > > >> > On Tue, Jul 7, 2020 at 1:20 AM Lukas Bulwahn > > > > wrote: > > > >> >> > > > >> >> On Mon, Jul 6, 2020 at 10:08 AM Mrinal Pandey > > > > wrote: > > > >> >> > > > > >> >> > checkpatch.pl issues warnings on > the > > > commits > > > >> >> > made to scripts/spelling.txt for new entries > > > >> >> > of typos and their fixes. This commit adjusts > > > >> >> > checkpatch not to complain about the same. > > > >> >> > > > > >> >> > Signed-off-by: Mrinal Pandey > > > > > > >> >> > --- > > > >> >> > > > >> >> How often does that issue appear? Can you use your > checkpatch > > > >> >> evaluation to show that it is relevant? > > > >> > > > > >> > > > >> How many commits to spelling.txt happened within the last year? > > > > > > > > > > > > Sir, > > > > > > > > I could find only commit to the file in the range 5.7 to > 5.8.rc-1. > > > >> > > > >> > > > >> The patch might be accepted, but the reason is not that > convincing. > > > > > > > > > > > > What do you suggest? Should I send it or not? > > > > > > > > > > Let us keep that in the backlog for now, but not send it. If it is > > > only one single case among hundreds false positives, it is maybe > not > > > the best to start with. > > > We might get to that one case here eventually, but let us start > with > > > the more important and critical cases first. > > > > > > > > > >> Maybe you can find another class of false positives that > happen more > > > >> often? > > > > > > > > > > > > Yes, I have a few other suggestions that I found occurring often > > > and I'm still evaluating to find more: > > > > 1. In `.h` files, when we write a function prototype, the name > of > > > the function parameters are > > > > not required, only the data type is enough, checkpatch says to > > > define the name of the parameters too. > > > > Issues a warning like - function definition argument '' > > > should also have an identifier name > > > > > > > > > > Okay, we need to discuss if that is a convention that developers > care > > > about or not. > > > > > > > > > > 2. A very common warning is - Macros with complex values should > > > be enclosed in parentheses > > > > which is correct sometimes but a false positive many times, for > > > macros ending with `)` or > > > > macros like `#define var value` we probably don't need another > > > pair of `()` > > > > > > > > > > Agree, this might be worth refining in checkpatch as you described. > > > > > > > 3. checkpatch complains about breaking a quoted string across > > > lines but this is many a time > > > > necessary for readability and in most of the patches I saw the > > > strings broken. > > > > > > > > > > Tricky to really know what the best solution is here. It is a > tradeoff > > > in both directions. > > > Let us put that aside for now. > > > > > > > 4. There are many patches where checkpatch issues false > positives > > > regarding spaces before > > > > and after lines. > > > > > > > Why are they false positives? > > > > > > > > > Sir, > > > > > > The warning by checkpatch says - please, no spaces at the start of a > line > > > but there are indeed no spaces before the line where this warning is > issued. > > > There are multiple commits having this issue, two of them are > > > `acaab7335bd6` and `372b38ea5911`. > > > > > > > > > > 5. The warning - EXPORT_SYMBOL(foo); should immediately follow > > > its function/variable > > > > is falsely positive in many cases where the statement is correct > > > but the script fails to identify it. > > > > > > > > > > If the script does not detect that, it sounds like a bug. > > > This can be improved for checkpatch.pl . > > > > > > > 6. While running checkpatch on a patch the following error was > > > thrown to the console - > > > > Use of uninitialized value $1 in regexp compilation at > > > ./scripts/checkpatch.pl line 2653. > > > > This could be fixed. > > > > > > > > > > That looks pretty sure like a bug. > > > > > > > Please let me know your views on these ideas. > > > > > > I suggest we look into issue 5 and 6. > > > > > > For Issue 5: Can you provide me (and the CC: the list) the list of > > > false positives (the commit hashes) you found for issue 5 on > > > EXPORT_SYMBOL? > > > > > > > > > Here are the commit hashes for which the warning is issued: > > > 54505a1e2083 > > > 75d75b7a4d54 > > > 8084c99b9af6 > > > bfdaf029c9c9 > > > dfd402a4c4ba > > > > > > Can you also provide a short rationale/explanation for > > > each case that you considered a false positive? > > > > > > > > > In each case the `EXPORT_SYMBOL()` is correctly written and the > > > variable/function to be exported > > > is also inside the parentheses, still, we get the warning. Please let > me > > > know if I am wrong here. > > > > > > > > > For Issue 6: Can you provide me the commit hash that caused this > > > checkpatch.pl error? Then, we can reproduce > > > and confirm that issue > > > probably simply with `git format-patch -1 $SHA | > > > ./scripts/checkpatch.pl ` and observe the > bug > > > and crash ourselves? > > > > > > > > > These are the commit hashes that crashed the checkpatch: > > > 6b3e0e2e0461 > > > 19ce2321739d > > > 059c6d68cfc5 > > > > > > > > > (I added linux-kernel-mentees@lists.linuxfoundation.org > > > back to > the > > > recipient list.) > > > Also, on sending emails: you started the thread on > > > linux-kernel-mentees@lists.linuxfoundation.org > > > . All > further > > > replies > > > shall always include that list in To or CC, so that the email > thread > > > is complete on the list. > > > > > > At some point in this mail thread, you only replied to me but did > not > > > have the list in the recipient list (in To or CC). That was wrong; > > > Please follow the rule stated above. I hope this point was already > > > taught on the LF Kernel Development Introduction course. Maybe you > can > > > check the material once again and see if and where that was pointed > > > out in the course material? > > > > > > > > > Sir, I apologize for not including the list in my previous replies. > > > Unfortunately, it slipped out of my mind. > > > I assure you it would not happen again. Also, Linux Kernel Mentorship > > > wiki says to CC the overall > > > program mentor Shuah Khan Ma'am on each contribution. Should I do it > > > only on the final patches or on > > > every mail I send? > > > > > > > No worries. You are new and this is a learning process. > > > > Please cc me on emails. You have to reply to the list when you respond > > to patch reviews. > > > > Please run get_maintainers.pl and include everybody get_maintainers.pl > > suggests. Without doing so will add more work for you when you send > > it to the community. > > > > Mrinal, please first send these suggested patches only to me, Shuah > and the linux-kernel-mentees list for reviewing. > > If I am okay with a specific patch, I will let you know to then send > the patch to everybody get_maintainers.pl suggest, which will be for > the patches we discuss: > > Andy Whitcroft (maintainer:CHECKPATCH) > Joe Perches (maintainer:CHECKPATCH) > linux-kernel@vger.kernel.org (open list) > > I want to make sure that I agree with the patch before sending it to > Andy and Joe. > > Lukas > --0000000000001eede805aa2a99a4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Okay, sir.

On Sat, Jul 11, 2020 at 2:46 AM Lukas Bulwah= n <lukas.bulwahn@gmail.com> wrote:
On = Fri, Jul 10, 2020 at 10:46 PM Shuah Khan <skhan@linuxfoundation.org> wrote: >
> On 7/10/20 5:26 AM, Mrinal Pandey wrote:
> > On Thu, Jul 9, 2020 at 10:33 AM Lukas Bulwahn <lukas.bulwahn@gmail.com > > <mailto:lukas.bulwahn@gmail.com>> wrote:
> >
> >=C2=A0 =C2=A0 =C2=A0On Thu, Jul 9, 2020 at 6:31 AM Mrinal Pandey &= lt;mrinalmni@gmail= .com
> >=C2=A0 =C2=A0 =C2=A0<mailto:mrinalmni@gmail.com>> wrote:
> >=C2=A0 =C2=A0 =C2=A0 >
> >=C2=A0 =C2=A0 =C2=A0 > On Tue, Jul 7, 2020 at 10:24 PM Lukas Bu= lwahn
> >=C2=A0 =C2=A0 =C2=A0<lukas.bulwahn@gmail.com <mailto:lukas.bulwahn@gmail.com>= > wrote:
> >=C2=A0 =C2=A0 =C2=A0 >>
> >=C2=A0 =C2=A0 =C2=A0 >> On Tue, Jul 7, 2020 at 10:22 AM Mrin= al Pandey
> >=C2=A0 =C2=A0 =C2=A0<mrinalmni@gmail.com <mailto:mrinalmni@gmail.com>> wrote:
> >=C2=A0 =C2=A0 =C2=A0 >> >
> >=C2=A0 =C2=A0 =C2=A0 >> >
> >=C2=A0 =C2=A0 =C2=A0 >> >
> >=C2=A0 =C2=A0 =C2=A0 >> > On Tue, Jul 7, 2020 at 1:20 AM = Lukas Bulwahn
> >=C2=A0 =C2=A0 =C2=A0<lukas.bulwahn@gmail.com <mailto:lukas.bulwahn@gmail.com>= > wrote:
> >=C2=A0 =C2=A0 =C2=A0 >> >>
> >=C2=A0 =C2=A0 =C2=A0 >> >> On Mon, Jul 6, 2020 at 10:0= 8 AM Mrinal Pandey
> >=C2=A0 =C2=A0 =C2=A0<mrinalmni@gmail.com <mailto:mrinalmni@gmail.com>> wrote:
> >=C2=A0 =C2=A0 =C2=A0 >> >> >
> >=C2=A0 =C2=A0 =C2=A0 >> >> > checkpatch.pl <http://che= ckpatch.pl> issues warnings on the
> >=C2=A0 =C2=A0 =C2=A0commits
> >=C2=A0 =C2=A0 =C2=A0 >> >> > made to scripts/spelli= ng.txt for new entries
> >=C2=A0 =C2=A0 =C2=A0 >> >> > of typos and their fix= es. This commit adjusts
> >=C2=A0 =C2=A0 =C2=A0 >> >> > checkpatch not to comp= lain about the same.
> >=C2=A0 =C2=A0 =C2=A0 >> >> >
> >=C2=A0 =C2=A0 =C2=A0 >> >> > Signed-off-by: Mrinal = Pandey <mrinalm= ni@gmail.com
> >=C2=A0 =C2=A0 =C2=A0<mailto:mrinalmni@gmail.com>>
> >=C2=A0 =C2=A0 =C2=A0 >> >> > ---
> >=C2=A0 =C2=A0 =C2=A0 >> >>
> >=C2=A0 =C2=A0 =C2=A0 >> >> How often does that issue a= ppear? Can you use your checkpatch
> >=C2=A0 =C2=A0 =C2=A0 >> >> evaluation to show that it = is relevant?
> >=C2=A0 =C2=A0 =C2=A0 >> >
> >=C2=A0 =C2=A0 =C2=A0 >>
> >=C2=A0 =C2=A0 =C2=A0 >> How many commits to spelling.txt hap= pened within the last year?
> >=C2=A0 =C2=A0 =C2=A0 >
> >=C2=A0 =C2=A0 =C2=A0 >
> >=C2=A0 =C2=A0 =C2=A0 > Sir,
> >=C2=A0 =C2=A0 =C2=A0 >
> >=C2=A0 =C2=A0 =C2=A0 > I could find only commit to the file in = the range 5.7 to 5.8.rc-1.
> >=C2=A0 =C2=A0 =C2=A0 >>
> >=C2=A0 =C2=A0 =C2=A0 >>
> >=C2=A0 =C2=A0 =C2=A0 >> The patch might be accepted, but the= reason is not that convincing.
> >=C2=A0 =C2=A0 =C2=A0 >
> >=C2=A0 =C2=A0 =C2=A0 >
> >=C2=A0 =C2=A0 =C2=A0 > What do you suggest? Should I send it or= not?
> >=C2=A0 =C2=A0 =C2=A0 >
> >
> >=C2=A0 =C2=A0 =C2=A0Let us keep that in the backlog for now, but n= ot send it. If it is
> >=C2=A0 =C2=A0 =C2=A0only one single case among hundreds false posi= tives, it is maybe not
> >=C2=A0 =C2=A0 =C2=A0the best to start with.
> >=C2=A0 =C2=A0 =C2=A0We might get to that one case here eventually,= but let us start with
> >=C2=A0 =C2=A0 =C2=A0the more important and critical cases first. > >
> >
> >=C2=A0 =C2=A0 =C2=A0 >> Maybe you can find another class of = false positives that happen more
> >=C2=A0 =C2=A0 =C2=A0 >> often?
> >=C2=A0 =C2=A0 =C2=A0 >
> >=C2=A0 =C2=A0 =C2=A0 >
> >=C2=A0 =C2=A0 =C2=A0 > Yes, I have a few other suggestions that= I found occurring often
> >=C2=A0 =C2=A0 =C2=A0and I'm still evaluating to find more:
> >=C2=A0 =C2=A0 =C2=A0 > 1. In `.h` files, when we write a functi= on prototype, the name of
> >=C2=A0 =C2=A0 =C2=A0the function parameters are
> >=C2=A0 =C2=A0 =C2=A0 > not required, only the data type is enou= gh, checkpatch says to
> >=C2=A0 =C2=A0 =C2=A0define the name of the parameters too.
> >=C2=A0 =C2=A0 =C2=A0 > Issues a warning like - function definit= ion argument '<arg>'
> >=C2=A0 =C2=A0 =C2=A0should also have an identifier name
> >=C2=A0 =C2=A0 =C2=A0 >
> >
> >=C2=A0 =C2=A0 =C2=A0Okay, we need to discuss if that is a conventi= on that developers care
> >=C2=A0 =C2=A0 =C2=A0about or not.
> >
> >
> >=C2=A0 =C2=A0 =C2=A0 > 2. A very common warning is - Macros wit= h complex values should
> >=C2=A0 =C2=A0 =C2=A0be enclosed in parentheses
> >=C2=A0 =C2=A0 =C2=A0 > which is correct sometimes but a false p= ositive many times, for
> >=C2=A0 =C2=A0 =C2=A0macros ending with `)` or
> >=C2=A0 =C2=A0 =C2=A0 > macros like `#define var value` we proba= bly don't need another
> >=C2=A0 =C2=A0 =C2=A0pair of `()`
> >=C2=A0 =C2=A0 =C2=A0 >
> >
> >=C2=A0 =C2=A0 =C2=A0Agree, this might be worth refining in checkpa= tch as you described.
> >
> >=C2=A0 =C2=A0 =C2=A0 > 3. checkpatch complains about breaking a= quoted string across
> >=C2=A0 =C2=A0 =C2=A0lines but this is many a time
> >=C2=A0 =C2=A0 =C2=A0 > necessary for readability and in most of= the patches I saw the
> >=C2=A0 =C2=A0 =C2=A0strings broken.
> >=C2=A0 =C2=A0 =C2=A0 >
> >
> >=C2=A0 =C2=A0 =C2=A0Tricky to really know what the best solution i= s here. It is a tradeoff
> >=C2=A0 =C2=A0 =C2=A0in both directions.
> >=C2=A0 =C2=A0 =C2=A0Let us put that aside for now.
> >
> >=C2=A0 =C2=A0 =C2=A0 > 4. There are many patches where checkpat= ch issues false positives
> >=C2=A0 =C2=A0 =C2=A0regarding spaces before
> >=C2=A0 =C2=A0 =C2=A0 > and after lines.
> >=C2=A0 =C2=A0 =C2=A0 >
> >=C2=A0 =C2=A0 =C2=A0Why are they false positives?
> >
> >
> > Sir,
> >
> > The warning by checkpatch says - please, no spaces at the start o= f a line
> > but there are indeed no spaces before the line where this warning= is issued.
> > There are multiple commits having this issue, two of them are
> > `acaab7335bd6` and `372b38ea5911`.
> >
> >
> >=C2=A0 =C2=A0 =C2=A0 > 5. The warning - EXPORT_SYMBOL(foo); sho= uld immediately follow
> >=C2=A0 =C2=A0 =C2=A0its function/variable
> >=C2=A0 =C2=A0 =C2=A0 > is falsely positive in many cases where = the statement is correct
> >=C2=A0 =C2=A0 =C2=A0but the script fails to identify it.
> >=C2=A0 =C2=A0 =C2=A0 >
> >
> >=C2=A0 =C2=A0 =C2=A0If the script does not detect that, it sounds = like a bug.
> >=C2=A0 =C2=A0 =C2=A0This can be improved for checkpatch.pl <http://ch= eckpatch.pl>.
> >
> >=C2=A0 =C2=A0 =C2=A0 > 6. While running checkpatch on a patch t= he following error was
> >=C2=A0 =C2=A0 =C2=A0thrown to the console -
> >=C2=A0 =C2=A0 =C2=A0 > Use of uninitialized value $1 in regexp = compilation at
> >=C2=A0 =C2=A0 =C2=A0./scripts/checkpatch.pl <http://checkpatch.pl= > line 2653.
> >=C2=A0 =C2=A0 =C2=A0 > This could be fixed.
> >=C2=A0 =C2=A0 =C2=A0 >
> >
> >=C2=A0 =C2=A0 =C2=A0That looks pretty sure like a bug.
> >
> >=C2=A0 =C2=A0 =C2=A0 > Please let me know your views on these i= deas.
> >
> >=C2=A0 =C2=A0 =C2=A0I suggest we look into issue 5 and 6.
> >
> >=C2=A0 =C2=A0 =C2=A0For Issue 5: Can you provide me (and the CC: t= he list) the list of
> >=C2=A0 =C2=A0 =C2=A0false positives (the commit hashes) you found = for issue 5 on
> >=C2=A0 =C2=A0 =C2=A0EXPORT_SYMBOL?
> >
> >
> > Here are the commit hashes for which the warning is issued:
> > 54505a1e2083
> > 75d75b7a4d54
> > 8084c99b9af6
> > bfdaf029c9c9
> > dfd402a4c4ba
> >
> >=C2=A0 =C2=A0 =C2=A0Can you also provide a short rationale/explana= tion for
> >=C2=A0 =C2=A0 =C2=A0each case that you considered a false positive= ?
> >
> >
> > In each case the `EXPORT_SYMBOL()` is correctly written and the > > variable/function to be exported
> > is also inside the parentheses, still, we get the warning. Please= let me
> > know if I am wrong here.
> >
> >
> >=C2=A0 =C2=A0 =C2=A0For Issue 6: Can you provide me the commit has= h that caused this
> >=C2=A0 =C2=A0 =C2=A0checkpatch.pl <http://checkpatch.pl> error= ? Then, we can reproduce
> >=C2=A0 =C2=A0 =C2=A0and confirm that issue
> >=C2=A0 =C2=A0 =C2=A0probably simply with `git format-patch -1 $SHA= |
> >=C2=A0 =C2=A0 =C2=A0./scripts/checkpatch.pl <http://checkpatch.pl= >` and observe the bug
> >=C2=A0 =C2=A0 =C2=A0and crash ourselves?
> >
> >
> > These are the commit hashes that crashed the checkpatch:
> > 6b3e0e2e0461
> > 19ce2321739d
> > 059c6d68cfc5
> >
> >
> >=C2=A0 =C2=A0 =C2=A0(I added linux-kernel-mentees@lists.l= inuxfoundation.org
> >=C2=A0 =C2=A0 =C2=A0<mailto:linux-kernel-mentees@lists= .linuxfoundation.org> back to the
> >=C2=A0 =C2=A0 =C2=A0recipient list.)
> >=C2=A0 =C2=A0 =C2=A0Also, on sending emails: you started the threa= d on
> >=C2=A0 =C2=A0 =C2=A0linux-kernel-mentees@lists.linuxfound= ation.org
> >=C2=A0 =C2=A0 =C2=A0<mailto:linux-kernel-mentees@lists= .linuxfoundation.org>. All further
> >=C2=A0 =C2=A0 =C2=A0replies
> >=C2=A0 =C2=A0 =C2=A0shall always include that list in To or CC, so= that the email thread
> >=C2=A0 =C2=A0 =C2=A0is complete on the list.
> >
> >=C2=A0 =C2=A0 =C2=A0At some point in this mail thread, you only re= plied to me but did not
> >=C2=A0 =C2=A0 =C2=A0have the list in the recipient list (in To or = CC). That was wrong;
> >=C2=A0 =C2=A0 =C2=A0Please follow the rule stated above. I hope th= is point was already
> >=C2=A0 =C2=A0 =C2=A0taught on the LF Kernel Development Introducti= on course. Maybe you can
> >=C2=A0 =C2=A0 =C2=A0check the material once again and see if and w= here that was pointed
> >=C2=A0 =C2=A0 =C2=A0out in the course material?
> >
> >
> > Sir, I apologize for not including the list in my previous replie= s.
> > Unfortunately, it slipped out of my mind.
> > I assure you it would not happen again. Also, Linux Kernel Mentor= ship
> > wiki says to CC the overall
> > program mentor Shuah Khan Ma'am on each contribution. Should = I do it
> > only on the final patches or on
> > every mail I send?
> >
>
> No worries. You are new and this is a learning process.
>
> Please cc me on emails. You have to reply to the list when you respond=
> to patch reviews.
>
> Please run get_maintainers.pl and include everybody get_maintainer= s.pl
> suggests. Without doing so will add more work for you when you send > it to the community.
>

Mrinal, please first send these suggested patches only to me, Shuah
and the linux-kernel-mentees list for reviewing.

If I am okay with a specific patch, I will let you know to then send
the patch to everybody get_maintainers.pl suggest, which will be for the patches we discuss:

Andy Whitcroft <a= pw@canonical.com> (maintainer:CHECKPATCH)
Joe Perches <joe@pe= rches.com> (maintainer:CHECKPATCH)
linux-ker= nel@vger.kernel.org (open list)

I want to make sure that I agree with the patch before sending it to
Andy and Joe.

Lukas
--0000000000001eede805aa2a99a4-- --===============5913242491836430062== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees --===============5913242491836430062==--