From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD0BDC433DF for ; Thu, 15 Oct 2020 16:57:42 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA59B206CA for ; Thu, 15 Oct 2020 16:57:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=massaru-org.20150623.gappssmtp.com header.i=@massaru-org.20150623.gappssmtp.com header.b="MF80TclT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA59B206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=massaru.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5730B880FD; Thu, 15 Oct 2020 16:57:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qNZMlSPgQJ6A; Thu, 15 Oct 2020 16:57:39 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 5A086880FB; Thu, 15 Oct 2020 16:57:39 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 417FBC07FF; Thu, 15 Oct 2020 16:57:39 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8B10AC0051 for ; Thu, 15 Oct 2020 16:57:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7B429887EC for ; Thu, 15 Oct 2020 16:57:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xsynMToSVati for ; Thu, 15 Oct 2020 16:57:36 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) by whitealder.osuosl.org (Postfix) with ESMTPS id 4AFF8887EA for ; Thu, 15 Oct 2020 16:57:36 +0000 (UTC) Received: by mail-yb1-f194.google.com with SMTP id d15so2801974ybl.10 for ; Thu, 15 Oct 2020 09:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=massaru-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pRJa+JTBxjpybniwHzuLNlcZWPVzh1B/YCuXreTnx1Y=; b=MF80TclTsq3KUYL4cHkQi8yGG5UzqcpzPJ6iZ65WadP7lnemhjnzWDQAsq3nQe+LIz x6eBsaMzJb70GjETfJQDvVBSmSg9ftHaoylzruLwATBVz/EDTMolvrbYshswR5WjAL04 MsjGzqzscfv7JGzomGofoqNAA0XrLOmNvsIS3h7ArfpkYjU9Iit6zTwgn6SvKFaga5R+ t6RtyCOMdUl0t4TwvnqJJzAMiZ1ogVV5C3Oa9i++g96guMzorVorq5n57I354OEyaqqR iy211+PiThigTCDqGfcJaoU2WI7x4k3CEGWXtyg4b8tkWd+Pae24chxgB7r3pLS81Urf uxPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pRJa+JTBxjpybniwHzuLNlcZWPVzh1B/YCuXreTnx1Y=; b=GJeVMa8QIUDhsEMsN2McoJHclOfXLIihNO+GsIN1iIVdIRncr6NdQMHrFqradxww6P 8sqprGjb5bhY/+tEU4fjyAVx0IEmSJOBAO9pLpnduafCbYs0/Dmx+gV0pMwVwq/GcmPF c+YfGfVm9+OYSMpgszwARcPTCBBJ4C0oCPhjV4aVbIF2aWXSNkUCxBXxwNdpOuHORgsB BFSsMIR2e9n9hw4u8qFWdRv3gIxSA/oEqYqPqHfVSN90Me1rP8nIlBvOAcwyNCM9WOTq 52lMIhLOEmD2qulHC6jVe9m6NuZqB46onTn9Xi+4J5reQ9dMIpL5w/QdY93CxVZvZa9m ZWjw== X-Gm-Message-State: AOAM533ufFy2D4OfvQhS3WGg0aFBPZIn5JgaUWLgQIyoDG0sVZDWW4r9 m2ZWPwEj5ZxyKdWakRpxCGDGehWGc8uqehRFFSS2Tw== X-Google-Smtp-Source: ABdhPJwjere3Uxr4kSJqyk0Iv8NcXLA4jvFFeW7uJ35t7F+STHv3UeHgaYdkxlZhqCNMg1/36eLEXhMhQmXVDL3+LIc= X-Received: by 2002:a25:2311:: with SMTP id j17mr6906084ybj.362.1602781055178; Thu, 15 Oct 2020 09:57:35 -0700 (PDT) MIME-Version: 1.0 References: <20200729201146.537433-1-vitor@massaru.org> In-Reply-To: From: Vitor Massaru Iha Date: Thu, 15 Oct 2020 13:56:59 -0300 Message-ID: To: Ian Rogers Cc: Peter Zijlstra , Brendan Higgins , LKML , "open list:KERNEL SELFTEST FRAMEWORK" , linux-kernel-mentees@lists.linuxfoundation.org, Ingo Molnar , KUnit Development Subject: Re: [Linux-kernel-mentees] [PATCH] lib: kunit: add test_min_heap test conversion to KUnit X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Hi Ian, On Thu, Oct 15, 2020 at 1:30 PM Ian Rogers wrote: > > On Wed, Oct 14, 2020 at 4:49 PM Vitor Massaru Iha wrote: > > > > Hi Ian, > > > > > > On Wed, Jul 29, 2020 at 7:57 PM Ian Rogers wrote: > > > > > > On Wed, Jul 29, 2020 at 1:11 PM Vitor Massaru Iha wrote: > > > > > > > > This adds the conversion of the runtime tests of test_min_heap, > > > > from `lib/test_min_heap.c` to KUnit tests. > > > > > > > > Please apply this commit first (linux-kselftest/kunit-fixes): > > > > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space > > > > > > Thanks for this, I'm a fan of testing frameworks :-) > > > > > > > Signed-off-by: Vitor Massaru Iha > > > > --- > > > > lib/Kconfig.debug | 29 ++++-- > > > > lib/Makefile | 2 +- > > > > lib/{test_min_heap.c => min_heap_kunit.c} | 117 ++++++++++++---------- > > > > 3 files changed, 83 insertions(+), 65 deletions(-) > > > > rename lib/{test_min_heap.c => min_heap_kunit.c} (60%) > > > > > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > > > index 9ad9210d70a1..46674fc4972c 100644 > > > > --- a/lib/Kconfig.debug > > > > +++ b/lib/Kconfig.debug > > > > @@ -1864,16 +1864,6 @@ config TEST_LIST_SORT > > > > > > > > If unsure, say N. > > > > > > > > -config TEST_MIN_HEAP > > > > - tristate "Min heap test" > > > > - depends on DEBUG_KERNEL || m > > > > - help > > > > - Enable this to turn on min heap function tests. This test is > > > > - executed only once during system boot (so affects only boot time), > > > > - or at module load time. > > > > - > > > > - If unsure, say N. > > > > - > > > > config TEST_SORT > > > > tristate "Array-based sort test" > > > > depends on DEBUG_KERNEL || m > > > > @@ -2185,6 +2175,25 @@ config LINEAR_RANGES_TEST > > > > > > > > If unsure, say N. > > > > > > > > +config MIN_HEAP_KUNIT > > > > + tristate "KUnit test for Min heap" > > > > + depends on KUNIT > > > > + depends on DEBUG_KERNEL || m > > > > + help > > > > + Enable this to turn on min heap function tests. This test is > > > > + executed only once during system boot (so affects only boot time), > > > > + or at module load time. > > > > + > > > > + KUnit tests run during boot and output the results to the debug log > > > > + in TAP format (http://testanything.org/). Only useful for kernel devs > > > > + running the KUnit test harness, and not intended for inclusion into a > > > > + production build. > > > > + > > > > + For more information on KUnit and unit tests in general please refer > > > > + to the KUnit documentation in Documentation/dev-tools/kunit/. > > > > + > > > > + If unsure, say N. > > > > + > > > > > > It's a shame we need a config option for this. Could we have one > > > option to cover all basic library tests? > > > > > > > config TEST_UDELAY > > > > tristate "udelay test driver" > > > > help > > > > diff --git a/lib/Makefile b/lib/Makefile > > > > index b1c42c10073b..748f57063160 100644 > > > > --- a/lib/Makefile > > > > +++ b/lib/Makefile > > > > @@ -72,7 +72,6 @@ CFLAGS_test_ubsan.o += $(call cc-disable-warning, vla) > > > > UBSAN_SANITIZE_test_ubsan.o := y > > > > obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o > > > > obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o > > > > -obj-$(CONFIG_TEST_MIN_HEAP) += test_min_heap.o > > > > obj-$(CONFIG_TEST_LKM) += test_module.o > > > > obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o > > > > obj-$(CONFIG_TEST_OVERFLOW) += test_overflow.o > > > > @@ -318,3 +317,4 @@ obj-$(CONFIG_OBJAGG) += objagg.o > > > > # KUnit tests > > > > obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o > > > > obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o > > > > +obj-$(CONFIG_MIN_HEAP_KUNIT) += min_heap_kunit.o > > > > diff --git a/lib/test_min_heap.c b/lib/min_heap_kunit.c > > > > similarity index 60% > > > > rename from lib/test_min_heap.c > > > > rename to lib/min_heap_kunit.c > > > > index d19c8080fd4d..398db1c63146 100644 > > > > --- a/lib/test_min_heap.c > > > > +++ b/lib/min_heap_kunit.c > > > > @@ -7,9 +7,8 @@ > > > > > > > > #include > > > > #include > > > > -#include > > > > -#include > > > > #include > > > > +#include > > > > > > > > static __init bool less_than(const void *lhs, const void *rhs) > > > > { > > > > @@ -29,37 +28,34 @@ static __init void swap_ints(void *lhs, void *rhs) > > > > *(int *)rhs = temp; > > > > } > > > > > > > > -static __init int pop_verify_heap(bool min_heap, > > > > +static __init void pop_verify_heap(struct kunit *context, > > > > + bool min_heap, > > > > struct min_heap *heap, > > > > const struct min_heap_callbacks *funcs) > > > > { > > > > int *values = heap->data; > > > > - int err = 0; > > > > int last; > > > > > > > > last = values[0]; > > > > min_heap_pop(heap, funcs); > > > > while (heap->nr > 0) { > > > > if (min_heap) { > > > > - if (last > values[0]) { > > > > - pr_err("error: expected %d <= %d\n", last, > > > > - values[0]); > > > > - err++; > > > > - } > > > > + KUNIT_EXPECT_FALSE_MSG(context, > > > > + last > values[0], > > > > + "expected %d <= %d\n", > > > > + last, values[0]); > > > > > > I'm not familiar with kunit, is there a reason not to prefer: > > > KUNIT_EXPECT_LT(context, last, values[0]); > > > > > > > } else { > > > > - if (last < values[0]) { > > > > - pr_err("error: expected %d >= %d\n", last, > > > > - values[0]); > > > > - err++; > > > > - } > > > > + KUNIT_EXPECT_FALSE_MSG(context, > > > > + last < values[0], > > > > + "expected %d >= %d\n", > > > > + last, values[0]); > > > > > > Similarly KUNIT_EXPECT_GT. > > > > In relation to this, instead of KUNIT_EXPECT_LT, we would have to have > > something like KUNIT_EXPECT_LT_FALSE. > > Otherwise the test will always fail. > > Does KUNIT_EXPECT_GE not work? The error message suggests it should at least. My bad, both expect work, I will send v3 now. I'm working with other projects in parallel, and my context switch failed :( > Thanks, > Ian > > > > > > > Thanks, > > > Ian > > > > > > > } > > > > last = values[0]; > > > > min_heap_pop(heap, funcs); > > > > } > > > > - return err; > > > > } > > > > > > > > -static __init int test_heapify_all(bool min_heap) > > > > +static __init void test_heapify_all(struct kunit *context, bool min_heap) > > > > { > > > > int values[] = { 3, 1, 2, 4, 0x8000000, 0x7FFFFFF, 0, > > > > -3, -1, -2, -4, 0x8000000, 0x7FFFFFF }; > > > > @@ -73,12 +69,11 @@ static __init int test_heapify_all(bool min_heap) > > > > .less = min_heap ? less_than : greater_than, > > > > .swp = swap_ints, > > > > }; > > > > - int i, err; > > > > + int i; > > > > > > > > /* Test with known set of values. */ > > > > min_heapify_all(&heap, &funcs); > > > > - err = pop_verify_heap(min_heap, &heap, &funcs); > > > > - > > > > + pop_verify_heap(context, min_heap, &heap, &funcs); > > > > > > > > /* Test with randomly generated values. */ > > > > heap.nr = ARRAY_SIZE(values); > > > > @@ -86,12 +81,10 @@ static __init int test_heapify_all(bool min_heap) > > > > values[i] = get_random_int(); > > > > > > > > min_heapify_all(&heap, &funcs); > > > > - err += pop_verify_heap(min_heap, &heap, &funcs); > > > > - > > > > - return err; > > > > + pop_verify_heap(context, min_heap, &heap, &funcs); > > > > } > > > > > > > > -static __init int test_heap_push(bool min_heap) > > > > +static __init void test_heap_push(struct kunit *context, bool min_heap) > > > > { > > > > const int data[] = { 3, 1, 2, 4, 0x80000000, 0x7FFFFFFF, 0, > > > > -3, -1, -2, -4, 0x80000000, 0x7FFFFFFF }; > > > > @@ -106,25 +99,22 @@ static __init int test_heap_push(bool min_heap) > > > > .less = min_heap ? less_than : greater_than, > > > > .swp = swap_ints, > > > > }; > > > > - int i, temp, err; > > > > + int i, temp; > > > > > > > > /* Test with known set of values copied from data. */ > > > > for (i = 0; i < ARRAY_SIZE(data); i++) > > > > min_heap_push(&heap, &data[i], &funcs); > > > > - > > > > - err = pop_verify_heap(min_heap, &heap, &funcs); > > > > + pop_verify_heap(context, min_heap, &heap, &funcs); > > > > > > > > /* Test with randomly generated values. */ > > > > while (heap.nr < heap.size) { > > > > temp = get_random_int(); > > > > min_heap_push(&heap, &temp, &funcs); > > > > } > > > > - err += pop_verify_heap(min_heap, &heap, &funcs); > > > > - > > > > - return err; > > > > + pop_verify_heap(context, min_heap, &heap, &funcs); > > > > } > > > > > > > > -static __init int test_heap_pop_push(bool min_heap) > > > > +static __init void test_heap_pop_push(struct kunit *context, bool min_heap) > > > > { > > > > const int data[] = { 3, 1, 2, 4, 0x80000000, 0x7FFFFFFF, 0, > > > > -3, -1, -2, -4, 0x80000000, 0x7FFFFFFF }; > > > > @@ -139,7 +129,7 @@ static __init int test_heap_pop_push(bool min_heap) > > > > .less = min_heap ? less_than : greater_than, > > > > .swp = swap_ints, > > > > }; > > > > - int i, temp, err; > > > > + int i, temp; > > > > > > > > /* Fill values with data to pop and replace. */ > > > > temp = min_heap ? 0x80000000 : 0x7FFFFFFF; > > > > @@ -149,8 +139,7 @@ static __init int test_heap_pop_push(bool min_heap) > > > > /* Test with known set of values copied from data. */ > > > > for (i = 0; i < ARRAY_SIZE(data); i++) > > > > min_heap_pop_push(&heap, &data[i], &funcs); > > > > - > > > > - err = pop_verify_heap(min_heap, &heap, &funcs); > > > > + pop_verify_heap(context, min_heap, &heap, &funcs); > > > > > > > > heap.nr = 0; > > > > for (i = 0; i < ARRAY_SIZE(data); i++) > > > > @@ -161,34 +150,54 @@ static __init int test_heap_pop_push(bool min_heap) > > > > temp = get_random_int(); > > > > min_heap_pop_push(&heap, &temp, &funcs); > > > > } > > > > - err += pop_verify_heap(min_heap, &heap, &funcs); > > > > + pop_verify_heap(context, min_heap, &heap, &funcs); > > > > +} > > > > > > > > - return err; > > > > +static void __init test_heapify_all_true(struct kunit *context) > > > > +{ > > > > + test_heapify_all(context, true); > > > > } > > > > > > > > -static int __init test_min_heap_init(void) > > > > +static void __init test_heapify_all_false(struct kunit *context) > > > > { > > > > - int err = 0; > > > > - > > > > - err += test_heapify_all(true); > > > > - err += test_heapify_all(false); > > > > - err += test_heap_push(true); > > > > - err += test_heap_push(false); > > > > - err += test_heap_pop_push(true); > > > > - err += test_heap_pop_push(false); > > > > - if (err) { > > > > - pr_err("test failed with %d errors\n", err); > > > > - return -EINVAL; > > > > - } > > > > - pr_info("test passed\n"); > > > > - return 0; > > > > + test_heapify_all(context, true); > > > > +} > > > > + > > > > +static void __init test_heap_push_true(struct kunit *context) > > > > +{ > > > > + test_heap_push(context, true); > > > > +} > > > > + > > > > +static void __init test_heap_push_false(struct kunit *context) > > > > +{ > > > > + test_heap_push(context, false); > > > > } > > > > -module_init(test_min_heap_init); > > > > > > > > -static void __exit test_min_heap_exit(void) > > > > +static void __init test_heap_pop_push_true(struct kunit *context) > > > > { > > > > - /* do nothing */ > > > > + test_heap_pop_push(context, true); > > > > } > > > > -module_exit(test_min_heap_exit); > > > > + > > > > +static void __init test_heap_pop_push_false(struct kunit *context) > > > > +{ > > > > + test_heap_pop_push(context, false); > > > > +} > > > > + > > > > +static struct kunit_case __refdata min_heap_test_cases[] = { > > > > + KUNIT_CASE(test_heapify_all_true), > > > > + KUNIT_CASE(test_heapify_all_false), > > > > + KUNIT_CASE(test_heap_push_true), > > > > + KUNIT_CASE(test_heap_push_false), > > > > + KUNIT_CASE(test_heap_pop_push_true), > > > > + KUNIT_CASE(test_heap_pop_push_false), > > > > + {} > > > > +}; > > > > + > > > > +static struct kunit_suite min_heap_test_suite = { > > > > + .name = "min-heap", > > > > + .test_cases = min_heap_test_cases, > > > > +}; > > > > + > > > > +kunit_test_suites(&min_heap_test_suite); > > > > > > > > MODULE_LICENSE("GPL"); > > > > > > > > base-commit: d43c7fb05765152d4d4a39a8ef957c4ea14d8847 > > > > -- > > > > 2.26.2 > > > > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees