* [Linux-kernel-mentees] [PATCH] kunit: use KUnit defconfig by default
@ 2020-04-14 23:37 Vitor Massaru Iha
2020-04-16 23:20 ` Brendan Higgins via Linux-kernel-mentees
0 siblings, 1 reply; 3+ messages in thread
From: Vitor Massaru Iha @ 2020-04-14 23:37 UTC (permalink / raw)
To: kunit-dev
Cc: linux-kernel-mentees, brendanhiggins, linux-kernel, linux-kselftest
To improve the usability of KUnit, defconfig is used
by default if no kunitconfig is present.
* https://bugzilla.kernel.org/show_bug.cgi?id=205259
Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
---
tools/testing/kunit/kunit.py | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py
index 7dca74774dd2..4b98f6e75e4c 100755
--- a/tools/testing/kunit/kunit.py
+++ b/tools/testing/kunit/kunit.py
@@ -23,8 +23,8 @@ import kunit_parser
KunitResult = namedtuple('KunitResult', ['status','result'])
KunitRequest = namedtuple('KunitRequest', ['raw_output','timeout', 'jobs',
- 'build_dir', 'defconfig',
- 'alltests', 'make_options'])
+ 'build_dir', 'alltests',
+ 'make_options'])
KernelDirectoryPath = sys.argv[0].split('tools/testing/kunit/')[0]
@@ -118,10 +118,6 @@ def main(argv, linux=None):
'directory.',
type=str, default='', metavar='build_dir')
- run_parser.add_argument('--defconfig',
- help='Uses a default .kunitconfig.',
- action='store_true')
-
run_parser.add_argument('--alltests',
help='Run all KUnit tests through allyesconfig',
action='store_true')
@@ -143,8 +139,7 @@ def main(argv, linux=None):
cli_args.build_dir,
kunit_kernel.kunitconfig_path)
- if cli_args.defconfig:
- create_default_kunitconfig()
+ create_default_kunitconfig()
if not linux:
linux = kunit_kernel.LinuxSourceTree()
@@ -153,7 +148,6 @@ def main(argv, linux=None):
cli_args.timeout,
cli_args.jobs,
cli_args.build_dir,
- cli_args.defconfig,
cli_args.alltests,
cli_args.make_options)
result = run_tests(linux, request)
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] kunit: use KUnit defconfig by default
2020-04-14 23:37 [Linux-kernel-mentees] [PATCH] kunit: use KUnit defconfig by default Vitor Massaru Iha
@ 2020-04-16 23:20 ` Brendan Higgins via Linux-kernel-mentees
2020-05-22 22:40 ` shuah
0 siblings, 1 reply; 3+ messages in thread
From: Brendan Higgins via Linux-kernel-mentees @ 2020-04-16 23:20 UTC (permalink / raw)
To: Vitor Massaru Iha
Cc: linux-kernel-mentees, Linux Kernel Mailing List,
open list:KERNEL SELFTEST FRAMEWORK, KUnit Development
On Tue, Apr 14, 2020 at 4:37 PM Vitor Massaru Iha <vitor@massaru.org> wrote:
>
> To improve the usability of KUnit, defconfig is used
> by default if no kunitconfig is present.
>
> * https://bugzilla.kernel.org/show_bug.cgi?id=205259
>
> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] kunit: use KUnit defconfig by default
2020-04-16 23:20 ` Brendan Higgins via Linux-kernel-mentees
@ 2020-05-22 22:40 ` shuah
0 siblings, 0 replies; 3+ messages in thread
From: shuah @ 2020-05-22 22:40 UTC (permalink / raw)
To: Brendan Higgins, Vitor Massaru Iha
Cc: linux-kernel-mentees, Linux Kernel Mailing List,
open list:KERNEL SELFTEST FRAMEWORK, shuah, KUnit Development
On 4/16/20 5:20 PM, Brendan Higgins wrote:
> On Tue, Apr 14, 2020 at 4:37 PM Vitor Massaru Iha <vitor@massaru.org> wrote:
>>
>> To improve the usability of KUnit, defconfig is used
>> by default if no kunitconfig is present.
>>
>> * https://bugzilla.kernel.org/show_bug.cgi?id=205259
>>
>> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
>
Applied the patch to kselftest/kunit on top of
45ba7a893ad89114e773b3dc32f6431354c465d6
kunit: kunit_tool: Separate out config/build/exec/parse
from David's work resolving merge conflicts. Please check if it is
sane.
thanks,
-- Shuah
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-22 22:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 23:37 [Linux-kernel-mentees] [PATCH] kunit: use KUnit defconfig by default Vitor Massaru Iha
2020-04-16 23:20 ` Brendan Higgins via Linux-kernel-mentees
2020-05-22 22:40 ` shuah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).