From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28339C56201 for ; Tue, 27 Oct 2020 09:52:35 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACE4A20759 for ; Tue, 27 Oct 2020 09:52:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k7S+sBnO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACE4A20759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4C195870E5; Tue, 27 Oct 2020 09:52:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2Vq3xIjACkXc; Tue, 27 Oct 2020 09:52:32 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id DF6FE870C1; Tue, 27 Oct 2020 09:52:32 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id DB997C0859; Tue, 27 Oct 2020 09:52:32 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5DD9EC0051 for ; Tue, 27 Oct 2020 09:52:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4B71E870C3 for ; Tue, 27 Oct 2020 09:52:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N7JYo6a6x3GP for ; Tue, 27 Oct 2020 09:52:31 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by hemlock.osuosl.org (Postfix) with ESMTPS id 363F6870C1 for ; Tue, 27 Oct 2020 09:52:31 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id h6so482430pgk.4 for ; Tue, 27 Oct 2020 02:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wh2Hw8EQyBD0Ddx8+aLTmA94GJKfHflrTQAtGiNwqjA=; b=k7S+sBnOSCWLi9gS94OK1suhL54C/xa8qk9PbC2/Ct/ad7G5m7J95qIOWJH1g3fQ32 fEDDJgNe5Y0II0MgJogToX8CB9MCU0JyuItlUzVy7j9AMDMhssKRF5oIHu7QQ0HhIJvP AqCk86+NVzY8NfgsUNq6CFPGnCWwRhKPArXfdNQGqu9lR7YydzWxKdgQ4iH4rK8j+hT2 qAe92PSiDmVPwrmr1TkyaEROrbh9tzoq1T6fx/UgtP4ujAVacDlmA7TG1c7b1DBtzZe4 VFpKY3eubAqb+FJau8xRuMbjMpiHrdsFnEsZ2qHh+5euSdreoPGoU+oJmveVzxWtYar8 VHIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wh2Hw8EQyBD0Ddx8+aLTmA94GJKfHflrTQAtGiNwqjA=; b=LAcn3ed1EW+5l1UlnpL1x3oALjR36rgAss70N3Zjz+sHJlTX5T4jJnHsORAZv643Yn XMyBtnDmyIcTK7Gz0gngyds18Y9KdGKTdbCZBevuKRD18etGw/9bOHRaaatK6NMHoUqE mA4yhnGSrsd69Q/PqIoGlC5vsbHoFT5iR1cxQNfnnX2+cgZsYRDybrWLvkXBzp+8XOzE iCvP7SK7BYxSgFxio+NRsY2aOkFzCb2ZVoT04CyhBDbrcnMtbQ4aLmD1WqzDh0IoWlKi 3lS3/rrchqmqmeUjT7zSHNBXvYTdy49CNV3eISB3+mS+F079yz5FpcSmeu+Wf/icdGhX +Mmg== X-Gm-Message-State: AOAM532/qj5G31fUXuVqZm5VfNGIWKC8Lpd9kyi030S9fCWvBzh9zPP6 zPrrOjTHs3EKnTMqLfDWtgqyemkgm7Ij9bo4MA8= X-Google-Smtp-Source: ABdhPJzkEGgGZewNw2BKSvNe4Bk+gwQcxoZALl2cLT2PGihJey9WvkfVQ7IeOXbSMrNRHG8AAjNGmkQ6k5q3zbonpEA= X-Received: by 2002:a62:343:0:b029:15c:e33c:faff with SMTP id 64-20020a6203430000b029015ce33cfaffmr746550pfd.7.1603792350629; Tue, 27 Oct 2020 02:52:30 -0700 (PDT) MIME-Version: 1.0 References: <20201003230340.42mtl35n4ka4d5qw@Rk> <20201004051644.f3fg2oavbobrwhf6@Rk> <20201006044941.fdjsp346kc5thyzy@Rk> <20201006083157.3pg6zvju5buxspns@Rk> <69853d2b-239c-79d5-bf6f-7dc0eec65602@redhat.com> <4f02cbdf-e1dd-b138-4975-118dd4f86089@redhat.com> <20201014042420.fkkyabmrkiekpmfw@Rk> <20201026225400.37almqey2wxyazkn@Rk> In-Reply-To: <20201026225400.37almqey2wxyazkn@Rk> From: Andy Shevchenko Date: Tue, 27 Oct 2020 11:52:14 +0200 Message-ID: To: Coiby Xu Cc: Shyam Sundar S K , "open list:GPIO SUBSYSTEM" , Linus Walleij , wang jun , Hans de Goede , linux-kernel-mentees@lists.linuxfoundation.org, Nehal Shah Subject: Re: [Linux-kernel-mentees] Any other ways to debug GPIO interrupt controller (pinctrl-amd) for broken touchpads of a new laptop model? X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Tue, Oct 27, 2020 at 2:07 AM Coiby Xu wrote: > > Hi Hans and Linus, > > Will you interpret the 0x0000 value for debounce timeout in GPIO > Interrupt Connection Resource Descriptor as disabling debouncing > filter? > > GpioInt (EdgeLevel, ActiveLevel, Shared, PinConfig, DebounceTimeout, ResourceSource, > ResourceSourceIndex, ResourceUsage, DescriptorName, VendorData) {PinList} According to the spec DebounceTimeout is an optional argument specifying the debounce wait time, in hundredths of milliseconds. The bit field name _DBT is automatically created to refer to this portion of the resource descriptor. I interpret this as 0 == no debounce (or a minimum that hardware has if there is no possibility to disable). > I'm not sure if Windows' implementation is the de facto standard like > i2c-hid. But if we are going to conform to the ACPI specs and we would > regard 0x0000 debounce timeout as disabling debouncing filter, then we > can fix this touchpad issue and potentially some related issues by > implementing the feature of supporting configuring debounce timeout in > drivers/gpio/gpiolib-acpi.c and removing all debounce filter > configuration in amd_gpio_irq_set_type of drivers/pinctrl/pinctrl-amd.c. > What do you think? > > A favorable evidence is I've collected five DSDT tables when > investigating this issue. All 5 DSDT tables have an GpioInt specifying > an non-zero debounce timeout value for the edge type irq and for all > the level type irq, the debounce timeout is set to 0x0000. To the future mails: please, do not top-post. And please remove a huge amount of unrelated lines in the reply. -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees