From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BA28C433EA for ; Mon, 20 Jul 2020 16:23:26 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 725FC2070A for ; Mon, 20 Jul 2020 16:23:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WWh4HW8Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 725FC2070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 4837486C11; Mon, 20 Jul 2020 16:23:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q70mbErItMIY; Mon, 20 Jul 2020 16:23:25 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 571CA8696A; Mon, 20 Jul 2020 16:23:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 45060C0894; Mon, 20 Jul 2020 16:23:25 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id E7AF3C016F for ; Mon, 20 Jul 2020 16:23:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D547886C11 for ; Mon, 20 Jul 2020 16:23:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F5P-CLYGCrIy for ; Mon, 20 Jul 2020 16:23:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by whitealder.osuosl.org (Postfix) with ESMTPS id 003E38696A for ; Mon, 20 Jul 2020 16:23:22 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id t27so13784335ill.9 for ; Mon, 20 Jul 2020 09:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OWFAaYoN+XCoJ7AgiWORga1TI9spDAaDAukT4gXW2bI=; b=WWh4HW8QHbh38QjtWamy8pjKHek67OYoPXbXu/t8qdSUvxpxAvvwRcd1e8ghA65ZQW BdO98zGhkfvSUuQ2l4T02KCFddz+7wA9S21Ubz/66RhBld+K9U8sWYd3GE/QqTizJy8K ouljlySRxiRljjjBHEBs3SSpEcECTwgxP2+CqjCGNOBc4m+mhtL5lVBhXaV9dHFcejMg pypo57WOF52np6QYS5CthqWEmBbWdWXOzAz6DDoduTD6n6AcBLhASvB2MD9WeXAlqCA2 KEN0u8dZ2JQDltsObVpK2ioZFd0tQynvcF3ByaM8Ht32T7YYBwDH93tOm80xRJk6b9zP Lc7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OWFAaYoN+XCoJ7AgiWORga1TI9spDAaDAukT4gXW2bI=; b=HcLODOvEo7aLlPcbM3TroQdqZezSHGwPKVlBUfa4u61J5GF9ZohEHy9qfQPXFtQEDT Lu22SzDd56f6g/GsH4pAlTL5BbM7CprHtWUk+1eNTcQsqMipJjqsozosfQEcHmOh+J14 p+UqBNnMdYTyKG4hzAG7dUuCPXbB6EKuHmF62wlvUDYbnLHx/QbnROOcij7x4a81Jjr0 o00v3iADONwNH4JMBy0FAby9Q+A0k5u9emTuRTs2tVW/aOllu8wAP/Tyt+UMXNkmwbDk FIBpLuwZTl416liDEp4+HZl21felzTX94omvzAEULJktEfqH8XyoDcIJNskKPQFZwzW+ Sr0g== X-Gm-Message-State: AOAM533M6rG7nFTzKbYvW8hSyX1K6xTAxKyWXSsh8LI5PbfFJ7g58tyF UR431Vq98NWckaaU+QKLse7cG4w7IDtFcWlcdPQ= X-Google-Smtp-Source: ABdhPJwydeMoqycuRoz99SqTUeGodwoMjiPEKCrupMlT/1sWhOs1A2jppjnTRN7jP4zbGLVKTE/rZ6l8dTnLFxJfWCo= X-Received: by 2002:a92:dc0c:: with SMTP id t12mr24400002iln.260.1595262202307; Mon, 20 Jul 2020 09:23:22 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6602:22d1:0:0:0:0 with HTTP; Mon, 20 Jul 2020 09:23:21 -0700 (PDT) In-Reply-To: References: <20200719171554.264462-1-nachiketun8@gmail.com> From: Lukas Bulwahn Date: Mon, 20 Jul 2020 18:23:21 +0200 Message-ID: To: Nachiket N Cc: "linux-kernel-mentees@lists.linuxfoundation.org" Subject: Re: [Linux-kernel-mentees] [PATCH] Checkpatch: Disables commit length check/warning in commit log in case of valid signature tags X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3025128257034857410==" Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" --===============3025128257034857410== Content-Type: multipart/alternative; boundary="000000000000e4681005aae1ec6d" --000000000000e4681005aae1ec6d Content-Type: text/plain; charset="UTF-8" On Monday, July 20, 2020, Nachiket N wrote: > I did run checkpatch on the patch in the previous mail. > Checkpatch.pl outputs warnings for commit description lines that exceed > beyond 75 chars. Sometimes these lines might contain signature tags that > cannot be > shortened. The patch checks if the line has any valid signature tags and > disables > the warning in such a case. > I tested it on patches which contain long commit log lines such as > Reported-and-tested-by: syzbot+db339689b2101f6f6071@ > syzkaller.appspotmail.com > in patch generated by commit ID ac854131d984. > It does not output commit warning for in such cases. > >> >> Okay, this patch below is not ready for submission to the general mailing list. Please read the kernel documentation on proper preparation of a patch submission. Lukas On Sun, Jul 19, 2020 at 11:07 PM Lukas Bulwahn > wrote: > >> Did you checkpatch this patch? >> >> You need to provide a rationale. Use a full checkpatch.pl evaluation >> data for showing the difference before and after applying the patch. >> >> Lukas >> >> On So., 19. Juli 2020 at 19:16, Nachiket Naganure >> wrote: >> >>> From: NachiketUN >>> >>> Signed-off-by: NachiketUN >>> --- >>> scripts/checkpatch.pl | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >>> index 197436b20288..8db0f26601c5 100755 >>> --- a/scripts/checkpatch.pl >>> +++ b/scripts/checkpatch.pl >>> @@ -2799,7 +2799,7 @@ sub process { >>> >>> # Check for line lengths > 75 in commit log, warn once >>> if ($in_commit_log && !$commit_log_long_line && >>> - length($line) > 75 && >>> + length($line) > 75 && $line !~ /$signature_tags/ && >>> !($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ || >>> # file delta changes >>> $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ || >>> -- >>> 2.25.1 >>> >>> --000000000000e4681005aae1ec6d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Monday, July 20, 2020, Nachiket N <nachiketun8@gmail.com> wrote:
I did run checkpatch on the patch in the p= revious mail.
Checkpatch.pl outputs warnings for commit descripti= on lines that exceed
beyond 75 chars. Sometimes these lines might contai= n signature tags that cannot be
shortened. The patch checks if the line = has any valid signature tags and disables
the warning in such a case.
I tested it on patches which contain long commit log lines such as<= /div>
in patch generated by com= mit ID ac854131d984.
It does not output commit warning for in suc= h cases.


Okay, this patch below is not ready for submissio= n to the general mailing list.

Please read the ker= nel documentation on proper preparation of a patch submission.
Lukas


= On Sun, Jul 19, 2020 at 11:07 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:=
Did you checkpatch this patch?

<= /div>
You need to provide a rationale. Use a full checkpatch.pl evaluation da= ta for showing the difference before and after applying the patch.

Lukas

On So., 19. Juli 2020 at 19:16, Nachiket Naganure <= ;nachiketun8@gma= il.com> wrote:
From: NachiketUN <nachiketun8@gmail.com>

Signed-off-by: NachiketUN <nachiketun8@gmail.com>
---
=C2=A0scripts/checkpatch.pl | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 197436b20288..8db0f26601c5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2799,7 +2799,7 @@ sub process {

=C2=A0# Check for line lengths > 75 in commit log, warn once
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ($in_commit_log = && !$commit_log_long_line &&
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lengt= h($line) > 75 &&
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lengt= h($line) > 75 && $line !~ /$signature_tags/ &&
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 !($li= ne =3D~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ ||
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # file d= elta changes
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 $line =3D~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ ||
--
2.25.1

--000000000000e4681005aae1ec6d-- --===============3025128257034857410== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees --===============3025128257034857410==--