From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Mrinal Pandey <mrinalmni@gmail.com>
Cc: Linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] scripts: Add intended executable mode and SPDX license
Date: Thu, 27 Aug 2020 08:16:33 +0200 [thread overview]
Message-ID: <CAKXUXMyZsENwp2jM106N_uao+yj=R-tGJDLerSO-GqtL+Qd3qg@mail.gmail.com> (raw)
In-Reply-To: <20200827061307.54526dz54p3gd45u@mrinalpandey>
On Thu, Aug 27, 2020 at 8:13 AM Mrinal Pandey <mrinalmni@gmail.com> wrote:
>
> On 20/08/27 11:35AM, Mrinal Pandey wrote:
> > commit b72231eb7084 ("scripts: add spdxcheck.py self test") added the file
> > spdxcheck-test.sh to repository without the executable flag and license
s/to/to the/
> > information.
> >
> > commit eb8305aecb95 ("scripts: Coccinelle script for namespace
> > dependencies.") added the file nsdeps, commit 313dd1b62921 ("gcc-plugins:
> > Add the randstruct plugin") added the file gcc-plugins/gen-random-seed.sh
> > and commit 9b4ade226f74 ("xen: build infrastructure for generating
> > hypercall depending symbols") added the file xen-hypercalls.sh without the
> > executable bit.
> >
> > Set to usual modes for these files and provide the SPDX license for
> > spdxcheck-test.sh. No functional changes.
> >
> > Signed-off-by: Mrinal Pandey <mrinalmni@gmail.com>
> > ---
> > scripts/gcc-plugins/gen-random-seed.sh | 0
> > scripts/nsdeps | 0
> > scripts/spdxcheck-test.sh | 2 +-
> > scripts/xen-hypercalls.sh | 0
> > 4 files changed, 1 insertion(+), 1 deletion(-)
> > mode change 100644 => 100755 scripts/gcc-plugins/gen-random-seed.sh
> > mode change 100644 => 100755 scripts/nsdeps
> > mode change 100644 => 100755 scripts/spdxcheck-test.sh
> > mode change 100644 => 100755 scripts/xen-hypercalls.sh
> >
> > diff --git a/scripts/gcc-plugins/gen-random-seed.sh b/scripts/gcc-plugins/gen-random-seed.sh
> > old mode 100644
> > new mode 100755
> > diff --git a/scripts/nsdeps b/scripts/nsdeps
> > old mode 100644
> > new mode 100755
> > diff --git a/scripts/spdxcheck-test.sh b/scripts/spdxcheck-test.sh
> > old mode 100644
> > new mode 100755
> > index cfea6a0d1cc0..758fa645ed99
> > --- a/scripts/spdxcheck-test.sh
> > +++ b/scripts/spdxcheck-test.sh
> > @@ -1,5 +1,5 @@
> > #!/bin/sh
> > -
Why do you delete the newline?
> > +# SPDX-License-Identifier: GPL-2.0
> > for PYTHON in python2 python3; do
> > # run check on a text and a binary file
> > for FILE in Makefile Documentation/logo.gif; do
> > diff --git a/scripts/xen-hypercalls.sh b/scripts/xen-hypercalls.sh
> > old mode 100644
> > new mode 100755
> > --
> > 2.25.1
> >
>
I think it is fine to have this as a single patch. It is local enough
to say that we are touching all those files in a single go.
Other than that, it looks good to me.
Please state to whom you intend to send this patch.
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-08-27 6:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 6:05 Mrinal Pandey
2020-08-27 6:13 ` Mrinal Pandey
2020-08-27 6:16 ` Lukas Bulwahn [this message]
2020-08-27 6:26 ` Mrinal Pandey
2020-08-27 7:24 ` Lukas Bulwahn
2020-08-27 9:24 Mrinal Pandey
2020-08-27 9:34 ` Lukas Bulwahn
2020-08-27 9:43 ` Greg KH
2020-08-27 9:49 ` Lukas Bulwahn
2020-08-27 10:00 ` Greg KH
2020-08-27 18:14 ` Kees Cook
2020-08-31 0:44 ` Andrew Morton
2020-08-31 5:45 ` Lukas Bulwahn
2020-08-31 19:20 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKXUXMyZsENwp2jM106N_uao+yj=R-tGJDLerSO-GqtL+Qd3qg@mail.gmail.com' \
--to=lukas.bulwahn@gmail.com \
--cc=Linux-kernel-mentees@lists.linuxfoundation.org \
--cc=mrinalmni@gmail.com \
--subject='Re: [Linux-kernel-mentees] [PATCH] scripts: Add intended executable mode and SPDX license' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).