From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Aditya <yashsri421@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: add fix for BAD_SIGN_OFF
Date: Sun, 8 Nov 2020 11:42:26 +0100 [thread overview]
Message-ID: <CAKXUXMzGDwAaVqTxoqctu8nkx3ddJWR0LXvERjThsMA=P4EGzA@mail.gmail.com> (raw)
In-Reply-To: <ce5206bd-0beb-a35b-829c-968a01c92e6d@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1614 bytes --]
On So., 8. Nov. 2020 at 10:19, Aditya <yashsri421@gmail.com> wrote:
> On 8/11/20 12:17 pm, Lukas Bulwahn wrote:
> >
> >
> > On Sun, 8 Nov 2020, Aditya wrote:
> >
> >> On 8/11/20 12:08 am, Lukas Bulwahn wrote:
> >>>
> >>> Can you share the six commits?
> >>>
> >>> Then we check if the fix is really the right fix of if something
> different
> >>> is wrong with these commits.
> >>>
> >>
> >>
> >> These are the commits where this warning for BAD_SIGN_OFF was getting
> >> triggered(over 4.13..5.8):
> >> 1) Commit 1d1f898df658 ("rcu: Do RCU GP kthread self-wakeup from
> >> softirq and interrupt")
> >> 2) Commit 6e88559470f5 ("Documentation: Add section about CPU
> >> vulnerabilities for Spectre")
> >> 3) Commit a35d16905efc ("rcu: Add basic support for kfree_rcu()
> batching")
> >> 4) Commit b7e4aadef28f ("locking/spinlocks: Document the semantics of
> >> spin_is_locked()")
> >> 5) Commit 621df431b0ac ("Documentation/memory-barriers.txt:
> >> Cross-reference "tools/memory-model/"")
> >> 6) Commit 1c27b644c0fd ("Automate memory-barriers.txt; provide
> >> Linux-kernel memory model")
> >>
> >
> > I checked all six cases and think the proposed fix is always okay.
> >
> > I guess there is still the warning that Co-developed-by: should
> > immediately be followed up the Signed-off-by:, right?
> >
> > A possible fix for that would be to check if the needed Signed-off-by:
> > follows somewhere and then just move that to the appropriate place in
> the
> > patch.
> >
>
> Should I add this in the current patch itself or create another patch
> for it?
>
Make that further fix feature a new patch.
Lukas
[-- Attachment #1.2: Type: text/html, Size: 2350 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-11-08 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 15:18 [Linux-kernel-mentees] [PATCH] checkpatch: add fix for BAD_SIGN_OFF Aditya Srivastava
2020-11-04 11:14 ` Lukas Bulwahn
2020-11-07 9:27 ` Aditya
2020-11-07 18:38 ` Lukas Bulwahn
2020-11-07 18:55 ` Aditya
2020-11-08 6:47 ` Lukas Bulwahn
2020-11-08 9:19 ` Aditya
2020-11-08 10:42 ` Lukas Bulwahn [this message]
2020-11-08 13:41 Aditya Srivastava
2020-11-08 13:43 Aditya Srivastava
2020-11-08 19:57 ` Joe Perches
2020-11-09 7:24 ` Aditya
2020-12-04 10:06 ` Aditya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKXUXMzGDwAaVqTxoqctu8nkx3ddJWR0LXvERjThsMA=P4EGzA@mail.gmail.com' \
--to=lukas.bulwahn@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).