From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C8CC4361A for ; Thu, 3 Dec 2020 18:56:13 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9519E208A9 for ; Thu, 3 Dec 2020 18:56:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9519E208A9 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0A98420429; Thu, 3 Dec 2020 18:56:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gmV-eW1ylGeu; Thu, 3 Dec 2020 18:56:11 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 3C360203B2; Thu, 3 Dec 2020 18:56:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2621FC0FA8; Thu, 3 Dec 2020 18:56:11 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id B7255C0FA7 for ; Thu, 3 Dec 2020 18:56:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9EB33874E8 for ; Thu, 3 Dec 2020 18:56:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BdLmzf5cGDX2 for ; Thu, 3 Dec 2020 18:56:07 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 456D88765F for ; Thu, 3 Dec 2020 18:56:07 +0000 (UTC) Date: Thu, 3 Dec 2020 19:57:13 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607021766; bh=OqCtaXAc83XAziJ60WcmvXio5z8n15J9SDIYOmxMMNw=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=yZWojBvM3upIyJEYAEqhlfJx1oaX/XVeJlGhpe8EzP9ADCZqJraYwIy/JtQVMXcaf s+iQqCMfjEM48Qkd/tpNLU5l/Y+oc0WJo4G+Fo9egVo8K9uGAeEzAtGu01dYPbGkNp tlMtfsCo4K+cxSv774UXAv0FiFJ1jc3QYjRFUJLU= From: Greg KH To: Lukas Bulwahn Message-ID: References: <280235acc0e91365f3fd3b5be5a5244eced1ff61.camel@perches.com> <20201202183045.9309-1-yashsri421@gmail.com> <5afbcd1423ee8fc2dfad191d94aef6efc17198c8.camel@perches.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Joe Perches , linux-kernel-mentees@lists.linuxfoundation.org, Linux Kernel Mailing List , Aditya Subject: Re: [Linux-kernel-mentees] [PATCH -mmots] checkpatch: add fix for non-standard signature - co-authored-by X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Thu, Dec 03, 2020 at 11:59:54AM +0100, Lukas Bulwahn wrote: > On Thu, Dec 3, 2020 at 10:59 AM Aditya wrote: > > > > On 3/12/20 12:26 am, Joe Perches wrote: > > > On Thu, 2020-12-03 at 00:00 +0530, Aditya Srivastava wrote: > > >> Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of > > >> non-standard signatures. > > >> > > >> An evaluation on v4.13..v5.8 showed that out of 539 warnings due to > > >> non-standard signatures, 43 are due to the use of 'Co-authored-by' > > >> tag, which may seem correct, but is not standard. > > >> > > >> The standard signature equivalent for 'Co-authored-by' is > > >> 'Co-developed-by'. > > > > > > I'm not going to ack this as I don't mind non-standard signatures. > > > > > > > What do you suggest? > > Should I drop this patch and move on? > > > > Joe does not ack this, but he also does not nack it. > > You either move on (which is perfectly fine), or > > you either wait that Andrew Morton reviews it and accepts it because > he thinks it useful, or > > you reach out to the git committers that have been using > Co-authored-by in the past and ask them if this kind of feature would > have been helpful for them and you get an ack from them that convinces > Andrew Morton to pick this. co-developed-by is the correct tag for this. It is documented exactly for this reason, please do not try to use something that is not already accepted by the kernel developers for this type of thing. thanks, greg k-h _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees