Linux Kernel Mentees Archive on
 help / color / Atom feed
From: Joe Perches <>
To: Dwaipayan Ray <>
Subject: Re: [Linux-kernel-mentees] [PATCH v2] checkpatch: fix missing whitespace in formatted email
Date: Mon, 12 Oct 2020 23:57:50 -0700
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, 2020-10-13 at 12:06 +0530, Dwaipayan Ray wrote:
> Commit 0c01921e56f9 ("checkpatch: add new warnings to author signoff
> checks.") introduced new checks for author sign off. The format_email
> procedure was modified to add comment blocks to the formatted email. But
> no space was added between the email address and mail comment.
> This causes wrong email formatting in cases where the email is in the form
> " (Comment block)". The space between the address and
> comment block is removed, which causes incorrect parsing of the
> formatted email.
> An evaluation on checkpatch brought up this case. For example,
> on commit 1129d31b55d5 ("ima: Fix ima digest hash table key calculation"),
> the following warning was reported:
> WARNING:BAD_SIGN_OFF: email address ' (big endian
> system concerns)' might be better as ' endian
> system concerns)'

Strictly, a comment or multiple comments can exist
in any part of an email

"John (Jon) Smith (Smitty) <jsmith@domain.tld> (tld is the best tld)

> Add a single space in between the address and comment when the
> extracted comment is not empty.

So after the address is not necessarily the best
location for a comment.

Linux-kernel-mentees mailing list

  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  6:36 Dwaipayan Ray
2020-10-13  6:57 ` Joe Perches [this message]
2020-10-13  7:35   ` Dwaipayan Ray
  -- strict thread matches above, loose matches on Subject: below --
2020-10-13  6:07 Dwaipayan Ray
2020-10-13  6:16 ` Lukas Bulwahn
2020-10-13  6:20   ` Dwaipayan Ray
2020-10-13  6:29     ` Lukas Bulwahn
2020-10-14 17:03   ` Aditya
2020-10-17  5:38     ` Aditya
2020-10-18  7:43       ` Lukas Bulwahn
2020-10-19  9:26         ` Aditya
2020-10-19 10:42           ` Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Kernel Mentees Archive on

Archives are clonable:
	git clone --mirror linux-kernel-mentees/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kernel-mentees linux-kernel-mentees/ \
	public-inbox-index linux-kernel-mentees

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone