From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2C4C433DF for ; Tue, 13 Oct 2020 07:33:20 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26CC4205CA for ; Tue, 13 Oct 2020 07:33:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26CC4205CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id C92FD2C35C; Tue, 13 Oct 2020 07:33:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TLKWIm+AViKG; Tue, 13 Oct 2020 07:33:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id C25212001A; Tue, 13 Oct 2020 07:33:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AB251C07FF; Tue, 13 Oct 2020 07:33:18 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5A3EEC0051 for ; Tue, 13 Oct 2020 07:33:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 48D3786B78 for ; Tue, 13 Oct 2020 07:33:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WbXmOBwJy8Io for ; Tue, 13 Oct 2020 07:33:17 +0000 (UTC) X-Greylist: delayed 00:20:00 by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by whitealder.osuosl.org (Postfix) with ESMTPS id 453C386B63 for ; Tue, 13 Oct 2020 07:33:17 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave07.hostedemail.com (Postfix) with ESMTP id 7D50D1801D421 for ; Tue, 13 Oct 2020 06:57:55 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id C2FB8182CED34; Tue, 13 Oct 2020 06:57:52 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: name14_1e1732027201 X-Filterd-Recvd-Size: 2127 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA; Tue, 13 Oct 2020 06:57:51 +0000 (UTC) Message-ID: From: Joe Perches To: Dwaipayan Ray Date: Mon, 12 Oct 2020 23:57:50 -0700 In-Reply-To: <20201013063642.39810-1-dwaipayanray1@gmail.com> References: <20201013063642.39810-1-dwaipayanray1@gmail.com> User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH v2] checkpatch: fix missing whitespace in formatted email X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Tue, 2020-10-13 at 12:06 +0530, Dwaipayan Ray wrote: > Commit 0c01921e56f9 ("checkpatch: add new warnings to author signoff > checks.") introduced new checks for author sign off. The format_email > procedure was modified to add comment blocks to the formatted email. But > no space was added between the email address and mail comment. > > This causes wrong email formatting in cases where the email is in the form > "author@example.com (Comment block)". The space between the address and > comment block is removed, which causes incorrect parsing of the > formatted email. > > An evaluation on checkpatch brought up this case. For example, > on commit 1129d31b55d5 ("ima: Fix ima digest hash table key calculation"), > the following warning was reported: > > WARNING:BAD_SIGN_OFF: email address 'David.Laight@aculab.com (big endian > system concerns)' might be better as 'David.Laight@aculab.com(big endian > system concerns)' Strictly, a comment or multiple comments can exist in any part of an email "John (Jon) Smith (Smitty) (tld is the best tld) > Add a single space in between the address and comment when the > extracted comment is not empty. So after the address is not necessarily the best location for a comment. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees