From: Joe Perches <email@example.com> To: Thomas Gleixner <firstname.lastname@example.org>, Julia Lawall <email@example.com> Cc: "Giuseppe Scrivano" <firstname.lastname@example.org>, "Valdis Klētnieks" <email@example.com>, kernelnewbies <firstname.lastname@example.org>, kernel-janitors <email@example.com>, LKML <firstname.lastname@example.org>, "Andy Whitcroft" <email@example.com>, "Andrew Morton" <firstname.lastname@example.org>, email@example.com, cocci <firstname.lastname@example.org> Subject: Re: [Linux-kernel-mentees] [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon) Date: Thu, 24 Sep 2020 15:23:39 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Thu, 2020-09-24 at 23:53 +0200, Thomas Gleixner wrote: > On Thu, Sep 24 2020 at 13:33, Joe Perches wrote: > > On Thu, 2020-09-24 at 22:19 +0200, Thomas Gleixner wrote: > > > On Sat, Aug 22 2020 at 09:07, Julia Lawall wrote: > > > > On Fri, 21 Aug 2020, Joe Perches wrote: > > > > > True enough for a general statement, though the coccinelle > > > > > script Julia provided does not change a single instance of > > > > > for loop expressions with commas. > > > > > > > > > > As far as I can tell, no logic defect is introduced by the > > > > > script at all. > > > > > > > > The script has a rule to ensure that what is changed is part of a top > > > > level statement that has the form e1, e2;. I put that in to avoid > > > > transforming cases where the comma is the body of a macro, but it protects > > > > against for loop headers as well. > > > > > > Right. I went through the lot and did not find something dodgy. Except > > > for two hunks this still applies. Can someone please send a proper patch > > > with changelog/SOB etc. for this? > > > > Treewide? > > > > Somebody no doubt would complain, but there > > _really should_ be some mechanism for these > > trivial and correct treewide changes... > > There are lots of mechanisms: I've tried them all. None of them work particularly well, especially the individual patch route. > - Andrew picks such changes up Generally not treewide. > - With a few competent eyeballs on it (reviewers) this can go thorugh > the trivial tree as well. It's more than obvious after all. Jiri is almost non-existent when it comes to trivial treewide patches. > - Send the script to Linus with a proper change log attached and ask > him to run it. Linus has concerns about backports and what he deems trivialities. Generally overblown IMO. > - In the worst case if nobody feels responsible, I'll take care. If Julia doesn't send a new patch in the next few days, I will do the apply, fixup and resend of hers. So, you're on-deck, nearly up... > All of the above is better than trying to get the attention of a > gazillion of maintainters. True. And all of the treewide changes depend on some generic acceptance of value in the type of change. Some believe that comma->semicolon conversions aren't useful as there isn't a logical change and the compiler output wouldn't be different. Anyway, cheers, Joe _______________________________________________ Linux-kernel-mentees mailing list Linuxemail@example.com https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-24 23:03 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <firstname.lastname@example.org> [not found] ` <email@example.com> [not found] ` <firstname.lastname@example.org> [not found] ` <alpine.DEB.2.22.394.2008201021400.2524@hadrien> [not found] ` <email@example.com> [not found] ` <alpine.DEB.2.22.394.2008201856110.2524@hadrien> 2020-08-22 1:08 ` Joe Perches 2020-08-22 3:35 ` Valdis Klētnieks 2020-08-22 5:30 ` Joe Perches 2020-08-22 7:07 ` Julia Lawall 2020-09-24 20:19 ` Thomas Gleixner 2020-09-24 20:21 ` Julia Lawall 2020-09-24 20:33 ` Joe Perches 2020-09-24 21:53 ` Thomas Gleixner 2020-09-24 22:23 ` Joe Perches [this message] 2020-09-25 17:06 ` Julia Lawall 2020-09-25 17:26 ` Joe Perches 2020-09-26 19:11 ` Valdis Klētnieks 2020-09-27 17:08 ` Julia Lawall 2020-09-27 17:45 ` Joe Perches 2020-09-27 19:35 ` Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [Linux-kernel-mentees] [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).