From: Shuah Khan <skhan@linuxfoundation.org>
To: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>,
mchehab@kernel.org, sean@mess.org, tglx@linutronix.de,
gregkh@linuxfoundation.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton
Date: Thu, 9 Jan 2020 14:11:10 -0700 [thread overview]
Message-ID: <adb61fd6-fc05-173d-9795-9ef36c4882b3@linuxfoundation.org> (raw)
In-Reply-To: <ebec2bb5-8db0-76fe-9c66-0316c1800f7c@gmail.com>
On 1/9/20 2:00 PM, Daniel W. S. Almeida wrote:
> Hi Shuah, thank you for you input!
>
>
>>
>> Looks like there is more code to be added to register/unregister
>
> Just to be clear, attach() is missing, but register / unregister belong
> in the bridge driver. Is this correct?
>
>
Right attach/detach is what I was thinking.
>>
>> Please add more detail here on what this driver does. What this
>> driver is used for and so on.
>>
>>
>> Samehere. Give more details on what this driver does. Add enough detail
>> to help users decide why they should enable it or not.
>> General practice is the following.
>>
>> Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida@gmail.com>
>
>> Please add details about the driver similar to the .c file.
>
> OK.
>
thanks,
-- Shuah
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-01-09 21:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 15:24 [Linux-kernel-mentees] [PATCH 0/1] Implement a DVB Dummy Tuner Daniel W. S. Almeida
2020-01-09 15:24 ` [Linux-kernel-mentees] [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton Daniel W. S. Almeida
2020-01-09 15:54 ` Greg KH
2020-01-09 20:43 ` Daniel W. S. Almeida
2020-01-09 16:13 ` Mauro Carvalho Chehab
2020-01-09 20:52 ` Daniel W. S. Almeida
2020-01-09 16:45 ` Shuah Khan
2020-01-09 21:00 ` Daniel W. S. Almeida
2020-01-09 21:11 ` Shuah Khan [this message]
2020-01-09 16:07 ` [Linux-kernel-mentees] [PATCH 0/1] Implement a DVB Dummy Tuner Mauro Carvalho Chehab
2020-01-09 20:51 ` Daniel W. S. Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adb61fd6-fc05-173d-9795-9ef36c4882b3@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=dwlsalmeida@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).