From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0652DC33CAA for ; Tue, 21 Jan 2020 06:20:34 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF3CF21734 for ; Tue, 21 Jan 2020 06:20:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF3CF21734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 72DC62041B; Tue, 21 Jan 2020 06:20:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WX7uUYtbDSIc; Tue, 21 Jan 2020 06:20:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 0FF7720430; Tue, 21 Jan 2020 06:20:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E61FDC0178; Tue, 21 Jan 2020 06:20:28 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id E5698C0174 for ; Tue, 21 Jan 2020 06:20:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E210685E07 for ; Tue, 21 Jan 2020 06:20:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qW1Mn-bX7mNZ for ; Tue, 21 Jan 2020 06:20:24 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 5A15D85E6F for ; Tue, 21 Jan 2020 06:20:24 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.70,344,1574118000"; d="scan'208";a="432302135" Received: from unknown (HELO hadrien) ([167.98.102.107]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2020 07:20:21 +0100 Date: Tue, 21 Jan 2020 06:20:21 +0000 (GMT) From: Julia Lawall X-X-Sender: julia@hadrien To: Jaskaran Singh In-Reply-To: <20200119134812.32748-1-jaskaransingh7654321@gmail.com> Message-ID: References: <20200119134812.32748-1-jaskaransingh7654321@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr Subject: Re: [Linux-kernel-mentees] [PATCH] parsing_hacks: Add bool to list of known typedefs X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Sun, 19 Jan 2020, Jaskaran Singh wrote: > bool is widely used in the Linux kernel. Certain cases of > parsing_hacks.ml would mislabel bool. > > Add bool to the list of known typedefs. > > Stats of --parse-c on Linux v5.5-rc4 are as follows: > > Before: > > nb good = 18956150, nb passed = 134062 =========> 0.70% passed > > After: > > nb good = 18956150, nb passed = 134073 =========> 0.70% passed Why did nb passed increase? These are tokens that will not be able to be transformed by a semantic patch. julia > > Signed-off-by: Jaskaran Singh > --- > The above diff has been obtained after applying > https://www.mail-archive.com/cocci@systeme.lip6.fr/msg06706.html > > parsing_c/parsing_hacks.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/parsing_c/parsing_hacks.ml b/parsing_c/parsing_hacks.ml > index 685a4908..5e3301a0 100644 > --- a/parsing_c/parsing_hacks.ml > +++ b/parsing_c/parsing_hacks.ml > @@ -61,7 +61,7 @@ let is_known_typdef = > | "u_char" | "u_short" | "u_int" | "u_long" > | "u8" | "u16" | "u32" | "u64" > | "s8" | "s16" | "s32" | "s64" > - | "__u8" | "__u16" | "__u32" | "__u64" > + | "__u8" | "__u16" | "__u32" | "__u64" | "bool" > -> true > > | "acpi_handle" > -- > 2.21.1 > > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees