Linux Kernel Mentees Archive on lore.kernel.org
 help / color / Atom feed
* Re: [Linux-kernel-mentees] [Cocci] [PATCH 2/2] tests: Add test case for matching pointers to const pointers (and variants)
@ 2020-02-05 18:55 Markus Elfring
  2020-02-06 11:58 ` Jaskaran Singh
  0 siblings, 1 reply; 7+ messages in thread
From: Markus Elfring @ 2020-02-05 18:55 UTC (permalink / raw)
  To: Jaskaran Singh, cocci; +Cc: linux-kernel-mentees

Would you like to avoid any abbreviations in the patch subject?


> These types would not match previously.

I imagine that this information can be improved for a nicer patch description,
can't it?

Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] [PATCH 2/2] tests: Add test case for matching pointers to const pointers (and variants)
  2020-02-05 18:55 [Linux-kernel-mentees] [Cocci] [PATCH 2/2] tests: Add test case for matching pointers to const pointers (and variants) Markus Elfring
@ 2020-02-06 11:58 ` Jaskaran Singh
  2020-02-06 14:00   ` Julia Lawall
                     ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Jaskaran Singh @ 2020-02-06 11:58 UTC (permalink / raw)
  To: Markus Elfring; +Cc: Julia Lawall, linux-kernel-mentees, cocci

On Wed, 2020-02-05 at 19:55 +0100, Markus Elfring wrote:
> Would you like to avoid any abbreviations in the patch subject?
> 

I used abbreviations to keep the patch subject short but still clear.

Would the following be a better subject?

"tests: Add test case to match const pointer variants"

Cheers,
Jaskaran.

> 
> > These types would not match previously.
> 
> I imagine that this information can be improved for a nicer patch
> description,
> can't it?
> 
> Regards,
> Markus

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] [PATCH 2/2] tests: Add test case for matching pointers to const pointers (and variants)
  2020-02-06 11:58 ` Jaskaran Singh
@ 2020-02-06 14:00   ` Julia Lawall
  2020-02-06 15:43   ` [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants Markus Elfring
  2020-02-07  6:07   ` Markus Elfring
  2 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2020-02-06 14:00 UTC (permalink / raw)
  To: Jaskaran Singh; +Cc: linux-kernel-mentees, Markus Elfring, cocci



On Thu, 6 Feb 2020, Jaskaran Singh wrote:

> On Wed, 2020-02-05 at 19:55 +0100, Markus Elfring wrote:
> > Would you like to avoid any abbreviations in the patch subject?
> >
>
> I used abbreviations to keep the patch subject short but still clear.
>
> Would the following be a better subject?
>
> "tests: Add test case to match const pointer variants"

OK for me.

julia

>
> Cheers,
> Jaskaran.
>
> >
> > > These types would not match previously.
> >
> > I imagine that this information can be improved for a nicer patch
> > description,
> > can't it?
> >
> > Regards,
> > Markus
>
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants
  2020-02-06 11:58 ` Jaskaran Singh
  2020-02-06 14:00   ` Julia Lawall
@ 2020-02-06 15:43   ` Markus Elfring
  2020-02-07  6:07   ` Markus Elfring
  2 siblings, 0 replies; 7+ messages in thread
From: Markus Elfring @ 2020-02-06 15:43 UTC (permalink / raw)
  To: Jaskaran Singh, cocci; +Cc: Julia Lawall, linux-kernel-mentees

> Would the following be a better subject?

I find the alternative succinct.

Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants
  2020-02-06 11:58 ` Jaskaran Singh
  2020-02-06 14:00   ` Julia Lawall
  2020-02-06 15:43   ` [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants Markus Elfring
@ 2020-02-07  6:07   ` Markus Elfring
  2020-02-07  6:15     ` Jaskaran Singh
  2 siblings, 1 reply; 7+ messages in thread
From: Markus Elfring @ 2020-02-07  6:07 UTC (permalink / raw)
  To: Jaskaran Singh, cocci; +Cc: Julia Lawall, linux-kernel-mentees

> Would the following be a better subject?

The alternative is nicer.


Will other implementation details become also more interesting?

The information “Align C AST and Cocci AST” was provided.
https://lore.kernel.org/cocci/20200205130327.6812-2-jaskaransingh7654321@gmail.com/
https://systeme.lip6.fr/pipermail/cocci/2020-February/006840.html

* Should the potential for differences in these “AST” be checked any more?

* How can such items be compared safely?


Is there a need to extend the test format?
https://github.com/coccinelle/coccinelle/issues/134

Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants
  2020-02-07  6:07   ` Markus Elfring
@ 2020-02-07  6:15     ` Jaskaran Singh
  2020-02-07  6:24       ` Markus Elfring
  0 siblings, 1 reply; 7+ messages in thread
From: Jaskaran Singh @ 2020-02-07  6:15 UTC (permalink / raw)
  To: Markus Elfring; +Cc: Julia Lawall, linux-kernel-mentees, cocci

On Fri, 2020-02-07 at 07:07 +0100, Markus Elfring wrote:
> > Would the following be a better subject?
> 
> The alternative is nicer.
> 
> 
> Will other implementation details become also more interesting?
> 
> The information “Align C AST and Cocci AST” was provided.
> https://lore.kernel.org/cocci/20200205130327.6812-2-jaskaransingh7654321@gmail.com/
> https://systeme.lip6.fr/pipermail/cocci/2020-February/006840.html
> 
> * Should the potential for differences in these “AST” be checked any
> more?
> 

An effort is already being made to do this by me and Julia :)

> * How can such items be compared safely?
> 

Not sure what you mean. If you mean how the two ASTs can be compared,
it's just a process of data collection and debugging.

Cheers,
Jaskaran.

> 
> Is there a need to extend the test format?
> https://github.com/coccinelle/coccinelle/issues/134
> 
> Regards,
> Markus

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants
  2020-02-07  6:15     ` Jaskaran Singh
@ 2020-02-07  6:24       ` Markus Elfring
  0 siblings, 0 replies; 7+ messages in thread
From: Markus Elfring @ 2020-02-07  6:24 UTC (permalink / raw)
  To: Jaskaran Singh; +Cc: Julia Lawall, linux-kernel-mentees, cocci

>> * Should the potential for differences in these “AST” be checked any more?
>
> An effort is already being made to do this by me and Julia :)

I am curious how this collaboration will evolve further.


>> * How can such items be compared safely?
>
> Not sure what you mean. If you mean how the two ASTs can be compared,
> it's just a process of data collection and debugging.

Which programming interfaces do you use for this purpose at the moment?

Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 18:55 [Linux-kernel-mentees] [Cocci] [PATCH 2/2] tests: Add test case for matching pointers to const pointers (and variants) Markus Elfring
2020-02-06 11:58 ` Jaskaran Singh
2020-02-06 14:00   ` Julia Lawall
2020-02-06 15:43   ` [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants Markus Elfring
2020-02-07  6:07   ` Markus Elfring
2020-02-07  6:15     ` Jaskaran Singh
2020-02-07  6:24       ` Markus Elfring

Linux Kernel Mentees Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kernel-mentees/0 linux-kernel-mentees/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kernel-mentees linux-kernel-mentees/ https://lore.kernel.org/linux-kernel-mentees \
		linux-kernel-mentees@lists.linuxfoundation.org
	public-inbox-index linux-kernel-mentees

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxfoundation.lists.linux-kernel-mentees


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git