From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0698C28CBC for ; Sun, 3 May 2020 19:32:43 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86EB42068E for ; Sun, 3 May 2020 19:32:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86EB42068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 675B487D36; Sun, 3 May 2020 19:32:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JYye6G8ONNhM; Sun, 3 May 2020 19:32:40 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 7ECAA87938; Sun, 3 May 2020 19:32:40 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6B4D6C0176; Sun, 3 May 2020 19:32:40 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4BD53C0175 for ; Sun, 3 May 2020 19:32:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 39A31882F0 for ; Sun, 3 May 2020 19:32:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nBaxAJqqurIH for ; Sun, 3 May 2020 19:32:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by hemlock.osuosl.org (Postfix) with ESMTPS id 5A168882E7 for ; Sun, 3 May 2020 19:32:38 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.73,349,1583190000"; d="scan'208";a="347594006" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2020 21:32:36 +0200 Date: Sun, 3 May 2020 21:32:36 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Jaskaran Singh In-Reply-To: <20200428170228.7002-23-jaskaransingh7654321@gmail.com> Message-ID: References: <20200428170228.7002-1-jaskaransingh7654321@gmail.com> <20200428170228.7002-23-jaskaransingh7654321@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr Subject: Re: [Linux-kernel-mentees] [PATCH 22/32] parsing_c: pretty_print_c: Reflect Cast attributes X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Tue, 28 Apr 2020, Jaskaran Singh wrote: > Cast attributes are added to the SmPL AST. Print these attributes in > pretty_print_c.ml. > > Signed-off-by: Jaskaran Singh > --- > parsing_c/pretty_print_c.ml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/parsing_c/pretty_print_c.ml b/parsing_c/pretty_print_c.ml > index 99a7e0ed..96a11d72 100644 > --- a/parsing_c/pretty_print_c.ml > +++ b/parsing_c/pretty_print_c.ml > @@ -146,8 +146,9 @@ let mk_pretty_printers > pp_expression e > | SizeOfType (t), [i1;i2;i3] -> > pr_elem i1; pr_elem i2; pp_type t; pr_elem i3 > - | Cast (t, e), [i1;i2] -> > - pr_elem i1; pp_type t; pr_elem i2; pp_expression e > + | Cast (t, e, a), [i1;i2] -> Less space in front of the [ julia > + pr_elem i1; pp_type t; pr_elem i2; pp_expression e; > + a +> pp_attributes pr_elem pr_space > > | StatementExpr (statxs, [ii1;ii2]), [i1;i2] -> > pr_elem i1; > @@ -184,7 +185,7 @@ let mk_pretty_printers > | CondExpr (_,_,_) | Sequence (_,_) | Assignment (_,_,_) > | Postfix (_,_) | Infix (_,_) | Unary (_,_) | Binary (_,_,_) > | ArrayAccess (_,_) | RecordAccess (_,_) | RecordPtAccess (_,_) > - | SizeOfExpr (_) | SizeOfType (_) | Cast (_,_) > + | SizeOfExpr (_) | SizeOfType (_) | Cast (_,_,_) > | StatementExpr (_) | Constructor _ > | ParenExpr (_) | New (_) | Delete (_,_) > | Defined (_)),_ -> raise (Impossible 95) > -- > 2.21.1 > > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees