archive mirror
 help / color / mirror / Atom feed
From: Lukas Bulwahn <>
To: Ayush <>
Subject: Re: [Linux-kernel-mentees] Regarding "Linux Kernel: Evaluate and Improve"
Date: Wed, 9 Sep 2020 11:52:08 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2009091145130.5622@felia> (raw)
In-Reply-To: <>

On Wed, 9 Sep 2020, Ayush wrote:

> > No, that is allowed. There can be of course a line break after commit
> > and before the hash, it is just that the current script
> > does not handle this case yet.
> > 
> > That would need improvement.
> I have already sent a patch for handling quotes in commit messages.
> (

Yes, I have seen that. I do not think it will be accepted (it is just too 
unclear), but you will see.

> I have created another patch which fixes line breaks after commit and
> before hash.
> It can handles cases like:
> - commit
> 1234567890ab ("foo bar")
> - commit
> 1234567890ab ("Revert "foo bar"")
> But, my question is, should I send this as a new patch or append it with
> my last patch and make a patch v2?

Create a separate patch that can be applied independently. As a mentor, I 
suggest to first send the patch only to me and the linux-kernel-mentees 
list, so that you get some first feedback without bothering the 
maintainers and them losing patience to work with you.

I suggest to work on this patch here first and then revisit the other 
patch for revert commits you created.

> My last patch is still under review.
> > I do not think that it is disallowed, but maybe a new check in
> > is recommended to make aware that quotes in commit
> > message subject lines cannot be properly handled and are discouraged.
> So, should we give a warning if (no. of quotes > 4)?

I suggest to implement a check if a commit message contains quotes. Then, 
we can check on previous commits how often that would trigger and see if 
we find legitimate cases where quotes really make sense; then we can 
improve to handle those well when refering to such commits.

Linux-kernel-mentees mailing list

  reply	other threads:[~2020-09-09  9:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200810125354.xeijyh3v5upatrez@salamander>
2020-08-17  9:43 ` [Linux-kernel-mentees] Regarding "Linux Kernel: Evaluate and Improve" Lukas Bulwahn
2020-08-21 16:18 ` Ayush
2020-08-22  8:06   ` Lukas Bulwahn
2020-08-24 10:06   ` Ayush
2020-08-27  5:28     ` Lukas Bulwahn
2020-08-30 18:51     ` Ayush
2020-08-31  5:14       ` Lukas Bulwahn
2020-09-06  9:59       ` Ayush
2020-09-07  7:38         ` Lukas Bulwahn
2020-09-07 14:27         ` Ayush
2020-09-07 16:43           ` Lukas Bulwahn
2020-09-09  9:14           ` Ayush
2020-09-09  9:52             ` Lukas Bulwahn [this message]
2020-09-09 16:01             ` Ayush
2020-09-10  6:04               ` Lukas Bulwahn
2020-08-26 13:51   ` Ayush

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2009091145130.5622@felia \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).