From: Lukas Bulwahn <firstname.lastname@example.org> To: Ayush <email@example.com> Cc: Joe Perches <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: GIT_COMMIT_ID: handle commit messages with multiple quotes Date: Wed, 9 Sep 2020 12:06:06 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.21.2009091152530.5622@felia> (raw) In-Reply-To: <firstname.lastname@example.org> On Tue, 8 Sep 2020, Ayush wrote: > > I think all your examples are broken. > > > > I think all should start with revert > > i.e.: Reverts commit <SHA-1> ("description...") > > Actually I am talking about those commits which referenced a revert commit. > > For example: > > If I want to mention a revert commit in my commit message, I will do something like. > > This bug appeared first in commit 1234567890ab ("Revert "abc: foo bar""). > (Just an example) > > Here, according to syntax, it is right but checkpatch.pl gives an error as multiple > quotes in commit messages are not handled in checkpatch.pl. > As the mentor in the linux kernel community bridge program, I usually inform the mentees when the review on the mentee mailing list has successfully concluded to a first acceptable state and I think it is well advised to reach out to the maintainers for further discussion. You did not do that, but just send some patch to the maintainers. That is fully up to you, but I will not support the patch acceptance in any way, and it suggests that you do not see the need to be mentored. If you can land patches without mentoring support successfully, that is great, but then you do not need a mentorship. Now, to the commit: Ayush, your commit message is largely incomprehensible. Your follow-up explanation that was needed should have been in the commit message in the first place. Ayush, you did not sign-off with your full legal name. So, I advice NOT TO TAKE this patch. I did not even start testing and reviewing the code yet. Lukas _______________________________________________ Linux-kernel-mentees mailing list Linuxemail@example.com https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-09 10:06 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-07 15:14 Ayush 2020-09-07 20:50 ` Joe Perches 2020-09-08 8:32 ` Ayush 2020-09-09 10:06 ` Lukas Bulwahn [this message] 2020-09-09 10:31 ` Ayush 2020-09-09 11:32 ` Lukas Bulwahn 2020-09-09 12:02 ` Joe Perches 2020-09-09 13:10 ` Lukas Bulwahn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.21.2009091152530.5622@felia \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [Linux-kernel-mentees] [PATCH] checkpatch: GIT_COMMIT_ID: handle commit messages with multiple quotes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).