linux-kernel-mentees.lists.linuxfoundation.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Ujjwal Kumar <ujjwalkumar0501@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] Evaluate and Improve checkpatch: tasks
Date: Sat, 12 Sep 2020 14:32:45 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2009121422520.3770@felia> (raw)
In-Reply-To: <23226f28-dcc4-dba3-dac9-636464d37b03@gmail.com>

On Sat, 12 Sep 2020, Ujjwal Kumar wrote:

> On 12/09/20 5:14 pm, Lukas Bulwahn wrote:
> > 
> > 
> > On Sat, 12 Sep 2020, Ujjwal Kumar wrote:
> > 
> >> Hello Lukas,
> >>
> >> I attempted the tasks.
> >>
> >> Below is the link of GitHub repository containing my write-up and findings.
> >> https://github.com/Ujjwal0501/lkmp-checkpatch
> >>
> > 
> > Thanks, it shows 404. Good luck next time.
> 
> I'm really sorry for the noise. The link is active now.

Okay, scripts and data looks sound. So, let us try those scripts.

Please have a look at this patch:

https://lore.kernel.org/linux-kernel-mentees/20200912094826.150170-1-ayush@disroot.org/

The author states:

This issue was discovered through a thorough analysis of checkpatch.pl
errors and warnings of type GIT_COMMIT_ID on commits between v5.7 and
v5.8.

Before applying this patch, checkpatch.pl reported 342 errors of type
GIT_COMMIT_ID. After applying patch, errors reduced to 284.


If your scripts work, you should be able to confirm the statement.

The tasks are:

1. Run your scripts and create a full statistics of all error types with
their according count for v5.7..v5.8.

2. Apply the patch with git am.

3. Run your scripts again and create a new statistics.

4. Compare before and after

5. Make all results available on your github repository.

---

Ujjwal, I can see that your evaluation shows

272 ERROR:GIT_COMMIT_ID

different from what the author reports. Maybe you apply the patch and 
check the difference for your evaluation first.

Afterwards, you might want to reach out to the author, cc this mailing 
list and check the difference of the configurations for the evaluation.

Then you can confirm the other evaluation as well.

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2020-09-12 12:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12 11:38 [Linux-kernel-mentees] Evaluate and Improve checkpatch: tasks Ujjwal Kumar
2020-09-12 11:44 ` Lukas Bulwahn
2020-09-12 11:48   ` Ujjwal Kumar
2020-09-12 12:32     ` Lukas Bulwahn [this message]
2020-09-13  9:35       ` Ujjwal Kumar
2020-09-13 11:15         ` Lukas Bulwahn
2020-09-16 11:36           ` Ujjwal Kumar
2020-09-16 12:06             ` [Linux-kernel-mentees] RRRe: " Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2009121422520.3770@felia \
    --to=lukas.bulwahn@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=ujjwalkumar0501@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).