From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Ayush <ayush@disroot.org>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value
Date: Mon, 14 Sep 2020 07:12:04 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2009140708240.7737@felia> (raw)
In-Reply-To: <8178fe030ae071aec6397987e672e0fb@disroot.org>
On Sun, 13 Sep 2020, Ayush wrote:
> Sir,
>
> > Yes, we should investigate that. If checkpatch.pl does not work properly
> > with git ranges, we should fix that first. Otherwise, all our evaluations
> > are broken...
>
> I noticed one more issue (more likely issue with git):
>
> If I run:
>
> $ scripts/checkpatch.pl --show-types -g d31275a9dc0b..a02254f8a676
>
> Output is: https://gist.githubusercontent.com/eldraco19/b979e752baa2c6fdc1776c8b65dfa21e/raw/39ad42113141929d93142d9a2962759b4b6b2e3b/checkpatch_issue.txt
>
> which doesn't include some in-between commits like: 3dbf1ee6abbb, 69388e15f507 e.t.c.
>
> Strangely it includes commit like 022467444515, which isn't even in the given range.
>
> then with,
>
> $ git log --no-merges --oneline
> .
> .
> a02254f8a676 dmaengine: ioat: Decreasing allocation chunk size 2M->512K
> bd2bf302eef2 dmaengine: ioat: fixing chunk sizing macros dependency
> 2fea2906b5cb dmaengine: Fix misspelling of "Analog Devices"
> b3cb14310eb4 dt-bindings: dma: renesas,usb-dmac: convert bindings to json-schema
> cde9a96ee24f dt-bindings: dma: renesas,rcar-dmac: convert bindings to json-schema
> fc6f5d0a4983 dmaengine: dw-edma: Decouple dw-edma-core.c from struct pci_dev
> 69388e15f507 pinctrl: cherryview: Add missing spinlock usage in chv_gpio_irq_handler
> 3dbf1ee6abbb pinctrl: cherryview: Add missing spinlock usage in chv_gpio_irq_handler
> 9f676e5313c1 gpio: mlxbf2: remove unused including <linux/version.h>
> b392350ec3f2 ALSA: hda/hdmi: Add module option to disable audio component binding
> 4c2b54f73aba gpio: dwapb: Split out dwapb_get_irq() helper
> c59042ed8965 gpio: dwapb: Drop of_match_ptr() & ACPI_PTR() calls
> 4f344e86c739 gpio: dwapb: Drop bogus BUG_ON()s
> 48ce80568346 gpio: dwapb: Switch to more usual pattern of RMW in dwapb_gpio_set_debounce()
> d31275a9dc0b gpio: dwapb: Convert to use IRQ core provided macros
> .
> .
> (trimmed output for specific range)
>
> It shows all the commits in between.
>
> But if I run:
>
> $ git log --no-merges v5.7..v5.8 --oneline
> .
> .
> a02254f8a676 dmaengine: ioat: Decreasing allocation chunk size 2M->512K
> bd2bf302eef2 dmaengine: ioat: fixing chunk sizing macros dependency
> 2fea2906b5cb dmaengine: Fix misspelling of "Analog Devices"
> b3cb14310eb4 dt-bindings: dma: renesas,usb-dmac: convert bindings to json-schema
> cde9a96ee24f dt-bindings: dma: renesas,rcar-dmac: convert bindings to json-schema
> fc6f5d0a4983 dmaengine: dw-edma: Decouple dw-edma-core.c from struct pci_dev
> 3dbf1ee6abbb pinctrl: cherryview: Add missing spinlock usage in chv_gpio_irq_handler
> 9f676e5313c1 gpio: mlxbf2: remove unused including <linux/version.h>
> 4c2b54f73aba gpio: dwapb: Split out dwapb_get_irq() helper
> c59042ed8965 gpio: dwapb: Drop of_match_ptr() & ACPI_PTR() calls
> 4f344e86c739 gpio: dwapb: Drop bogus BUG_ON()s
> 48ce80568346 gpio: dwapb: Switch to more usual pattern of RMW in dwapb_gpio_set_debounce()
> d31275a9dc0b gpio: dwapb: Convert to use IRQ core provided macros
> .
> .
> (trimmed output for specific range)
>
> It shows commit 3dbf1ee6abbb but not 69388e15f507.
> I confirmed both commits are present in tree from:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?h=linux-5.8.y&ofs=18900
>
>
> I think it is an issue with git.
>
> Please give your opinion on this.
>
I cannot follow your description and explanation.
What is the problem you encountered? What did you expect? What did you
observe? Which lines of code are involved? What git command is called?
Why do you expect a certain behaviour?
I would bet that you misunderstand git and git is not broken; so, convince
us on the mailing list that I lose this bet.
You can do better explaining, then we might help you.
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-14 5:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 9:48 [Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value Ayush
2020-09-12 11:17 ` Lukas Bulwahn
2020-09-12 12:42 ` Lukas Bulwahn
2020-09-12 13:34 ` Ayush
2020-09-12 14:15 ` Lukas Bulwahn
2020-09-12 15:38 ` Ayush
2020-09-12 19:37 ` Ayush
2020-09-13 11:01 ` Lukas Bulwahn
2020-09-13 12:06 ` Ayush
2020-09-13 18:09 ` Lukas Bulwahn
2020-09-13 20:53 ` Ayush
2020-09-14 5:12 ` Lukas Bulwahn [this message]
2020-09-17 14:53 ` Ayush
2020-09-17 15:17 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2009140708240.7737@felia \
--to=lukas.bulwahn@gmail.com \
--cc=ayush@disroot.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).