linux-kernel-mentees.lists.linuxfoundation.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: [Linux-kernel-mentees] checkpatch.pl investigation: NO_AUTHOR_SIGN_OFF issues
Date: Fri, 18 Sep 2020 12:06:41 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2009181157160.14717@felia> (raw)

Hi Dwaipayan, hi others,

I had a quick look on the NO AUTHOR SIGN OFF issues reported by 
checkpatch.pl on v5.4..v5.8 on my own small script.

After collecting all the data in a tsv (no details on that tsv here):

$ grep "NO_AUTHOR_SIGN_OFF" v5.4..v5.8.tsv | wc -l
1064

$ grep "NO_AUTHOR_SIGN_OFF" v5.4..v5.8.tsv  | cut -f 7 | sort  | uniq -c | 
sort -nr | head -n 8
    175 Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
    116 Missing Signed-off-by: line by nominal patch author ''
     68 Missing Signed-off-by: line by nominal patch author 'Trond Myklebust <trondmy@gmail.com>'
     43 Missing Signed-off-by: line by nominal patch author 'Thinh Nguyen <Thinh.Nguyen@synopsys.com>'
     40 Missing Signed-off-by: line by nominal patch author 'Pascal van Leeuwen <pascalvanl@gmail.com>'
     36 Missing Signed-off-by: line by nominal patch author 'Alex Maftei <amaftei@solarflare.com>'
     31 Missing Signed-off-by: line by nominal patch author 'Valdis Kletnieks <valdis.kletnieks@vt.edu>'
     24 Missing Signed-off-by: line by nominal patch author 'Luke Nelson <lukenels@cs.washington.edu>'


Here a quick look at the first two:

    175 Missing Signed-off-by: line by nominal patch author 'Daniel Vetter 
<daniel.vetter@ffwll.ch>'

$ grep "NO_AUTHOR_SIGN_OFF" v5.4..v5.8.tsv | grep "Daniel Vetter" \
  | cut -f 1 > commits-NO_AUTHOR_SIGN_OFF-Daniel-Vetter
$ cat commits-NO_AUTHOR_SIGN_OFF-Daniel-Vetter | \
  xargs git show  --format="%b" -s | \
  grep "Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>" | \
  wc -l

So all 175 commits are of the type:

Author: Daniel Vetter <daniel.vetter@ffwll.ch>
...
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>


and the second:

    116 Missing Signed-off-by: line by nominal patch author ''

That is probably due to not parsing the patch author with a line break.


So, if we can find a solution for Daniel Vetter (of course, not 
hard-coding it in checkpatch.pl), e.g., by adding a .mailmap entry for him 
and making use of that in checkpatch.pl,

... and for the encoding problem, then we got around 27% of the 
NO_AUTHOR_SIGN_OFF 'problems' solved. Next, we can continue to look at the 
next few remaining ones. The longer tail of warnings are clearly warnings 
that deserve to be pointed out to newbies with a broken setup.

I hope you can continue to work on a solution for this class.


Thanks for your initial investigation,

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

             reply	other threads:[~2020-09-18 10:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 10:06 Lukas Bulwahn [this message]
2020-09-18 10:29 ` [Linux-kernel-mentees] checkpatch.pl investigation: NO_AUTHOR_SIGN_OFF issues Dwaipayan Ray
2020-09-18 10:44   ` Lukas Bulwahn
2020-09-21  9:07     ` Dwaipayan Ray
2020-09-21  9:12       ` Lukas Bulwahn
2020-09-21  9:15       ` Lukas Bulwahn
2020-09-22 13:21         ` Dwaipayan Ray
2020-09-22 18:38           ` Lukas Bulwahn
2020-09-22 19:08             ` Dwaipayan Ray
2020-09-23  7:32               ` Lukas Bulwahn
2020-09-23  7:38                 ` Dwaipayan Ray
2020-09-23  7:42                   ` Lukas Bulwahn
2020-09-25  4:18                     ` Dwaipayan Ray
2020-09-25  7:20                       ` Lukas Bulwahn
2020-09-25  7:29                         ` Dwaipayan Ray
2020-09-25  7:35                           ` Lukas Bulwahn
2020-09-26 11:31                             ` Dwaipayan Ray
2020-09-28 13:30                               ` Dwaipayan Ray
2020-09-28 14:09                                 ` Lukas Bulwahn
2020-09-28 14:20                                   ` Dwaipayan Ray
2020-09-28 15:09                                     ` Lukas Bulwahn
2020-09-28 15:06                               ` Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2009181157160.14717@felia \
    --to=lukas.bulwahn@gmail.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).