linux-kernel-mentees.lists.linuxfoundation.org archive mirror
 help / color / mirror / Atom feed
* [Linux-kernel-mentees] [PATCH RFC] kconfig: use interpreters to invoke scripts
@ 2020-10-01 19:52 Ujjwal Kumar
  2020-10-02  3:50 ` Lukas Bulwahn
  0 siblings, 1 reply; 6+ messages in thread
From: Ujjwal Kumar @ 2020-10-01 19:52 UTC (permalink / raw)
  To: Lukas Bulwahn; +Cc: linux-kernel-mentees

We cannot rely on execute bits to be set on files in the repository.
The build script should use the explicit interpreter when invoking any 
script from the repository.

Link: https://lore.kernel.org/lkml/20200830174409.c24c3f67addcce0cea9a9d4c@linux-foundation.org/
Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/

Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Suggested-by: Kees Cook <keescook@chromium.org>
Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Ujjwal Kumar <ujjwalkumar0501@gmail.com>
---
 init/Kconfig | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index 91456ac0ef20..335c8fcb99af 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -30,12 +30,12 @@ config CC_IS_GCC
 
 config GCC_VERSION
 	int
-	default $(shell,$(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
+	default $(shell,$(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
 	default 0
 
 config LD_VERSION
 	int
-	default $(shell,$(LD) --version | $(srctree)/scripts/ld-version.sh)
+	default $(shell,$(LD) --version | $(AWK) -f $(srctree)/scripts/ld-version.sh)
 
 config CC_IS_CLANG
 	def_bool $(success,echo "$(CC_VERSION_TEXT)" | grep -q clang)
@@ -45,20 +45,20 @@ config LD_IS_LLD
 
 config CLANG_VERSION
 	int
-	default $(shell,$(srctree)/scripts/clang-version.sh $(CC))
+	default $(shell,$(CONFIG_SHELL) $(srctree)/scripts/clang-version.sh $(CC))
 
 config CC_CAN_LINK
 	bool
-	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag)) if 64BIT
-	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag))
+	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag)) if 64BIT
+	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag))
 
 config CC_CAN_LINK_STATIC
 	bool
-	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag) -static) if 64BIT
-	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag) -static)
+	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag) -static) if 64BIT
+	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag) -static)
 
 config CC_HAS_ASM_GOTO
-	def_bool $(success,$(srctree)/scripts/gcc-goto.sh $(CC))
+	def_bool $(success,$(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC))
 
 config CC_HAS_ASM_GOTO_OUTPUT
 	depends on CC_HAS_ASM_GOTO
-- 
2.26.2

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH RFC] kconfig: use interpreters to invoke scripts
  2020-10-01 19:52 [Linux-kernel-mentees] [PATCH RFC] kconfig: use interpreters to invoke scripts Ujjwal Kumar
@ 2020-10-02  3:50 ` Lukas Bulwahn
  2020-10-02  7:10   ` Ujjwal Kumar
  0 siblings, 1 reply; 6+ messages in thread
From: Lukas Bulwahn @ 2020-10-02  3:50 UTC (permalink / raw)
  To: Ujjwal Kumar; +Cc: linux-kernel-mentees



On Fri, 2 Oct 2020, Ujjwal Kumar wrote:

> We cannot rely on execute bits to be set on files in the repository.
> The build script should use the explicit interpreter when invoking any 
> script from the repository.
> 
> Link: https://lore.kernel.org/lkml/20200830174409.c24c3f67addcce0cea9a9d4c@linux-foundation.org/
> Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/
> 
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Suggested-by: Kees Cook <keescook@chromium.org>
> Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Signed-off-by: Ujjwal Kumar <ujjwalkumar0501@gmail.com>


Ujjwal, you have nicely split the patches. I suggest you send out this 
patch and the patch "kbuild: use interpreters to incoke scripts" together 
as one patch series.

You just need to write a cover letter and explain there which steps you 
did to find this being wrong before and what you did to test that it is 
now corrected.

Also, can you please share on this list to whom/which lists you would send 
this patch series?

Then we check that we did not miss anyone important for these two patches.

Please resend the two mentioned patches again as patch series with a cover 
letter.

We are getting close now to sending this to the larger group of kernel 
developers.

Good progress so far.

Lukas

> ---
>  init/Kconfig | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index 91456ac0ef20..335c8fcb99af 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -30,12 +30,12 @@ config CC_IS_GCC
>  
>  config GCC_VERSION
>  	int
> -	default $(shell,$(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
> +	default $(shell,$(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
>  	default 0
>  
>  config LD_VERSION
>  	int
> -	default $(shell,$(LD) --version | $(srctree)/scripts/ld-version.sh)
> +	default $(shell,$(LD) --version | $(AWK) -f $(srctree)/scripts/ld-version.sh)
>  
>  config CC_IS_CLANG
>  	def_bool $(success,echo "$(CC_VERSION_TEXT)" | grep -q clang)
> @@ -45,20 +45,20 @@ config LD_IS_LLD
>  
>  config CLANG_VERSION
>  	int
> -	default $(shell,$(srctree)/scripts/clang-version.sh $(CC))
> +	default $(shell,$(CONFIG_SHELL) $(srctree)/scripts/clang-version.sh $(CC))
>  
>  config CC_CAN_LINK
>  	bool
> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag)) if 64BIT
> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag))
> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag)) if 64BIT
> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag))
>  
>  config CC_CAN_LINK_STATIC
>  	bool
> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag) -static) if 64BIT
> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag) -static)
> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag) -static) if 64BIT
> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag) -static)
>  
>  config CC_HAS_ASM_GOTO
> -	def_bool $(success,$(srctree)/scripts/gcc-goto.sh $(CC))
> +	def_bool $(success,$(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC))
>  
>  config CC_HAS_ASM_GOTO_OUTPUT
>  	depends on CC_HAS_ASM_GOTO
> -- 
> 2.26.2
> 
> 
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH RFC] kconfig: use interpreters to invoke scripts
  2020-10-02  3:50 ` Lukas Bulwahn
@ 2020-10-02  7:10   ` Ujjwal Kumar
  2020-10-03  7:05     ` Lukas Bulwahn
  0 siblings, 1 reply; 6+ messages in thread
From: Ujjwal Kumar @ 2020-10-02  7:10 UTC (permalink / raw)
  To: Lukas Bulwahn; +Cc: linux-kernel-mentees

On 02/10/20 9:20 am, Lukas Bulwahn wrote:
> 
> 
> On Fri, 2 Oct 2020, Ujjwal Kumar wrote:
> 
>> We cannot rely on execute bits to be set on files in the repository.
>> The build script should use the explicit interpreter when invoking any 
>> script from the repository.
>>
>> Link: https://lore.kernel.org/lkml/20200830174409.c24c3f67addcce0cea9a9d4c@linux-foundation.org/
>> Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/
>>
>> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
>> Suggested-by: Kees Cook <keescook@chromium.org>
>> Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>> Signed-off-by: Ujjwal Kumar <ujjwalkumar0501@gmail.com>
> 
> 
> Ujjwal, you have nicely split the patches. I suggest you send out this 
> patch and the patch "kbuild: use interpreters to incoke scripts" together 
> as one patch series.
> 
> You just need to write a cover letter and explain there which steps you 
> did to find this being wrong before and what you did to test that it is 
> now corrected.
> 
> Also, can you please share on this list to whom/which lists you would send 
> this patch series?Running 'get_maintainer.pl' script I get the following list.

kconfig: use interpreters to invoke scripts-

Nathan Chancellor <natechancellor@gmail.com>
Nick Desaulniers <ndesaulniers@google.com>
Masahiro Yamada <masahiroy@kernel.org>
"Steven Rostedt (VMware)" <rostedt@goodmis.org>
Masami Hiramatsu <mhiramat@kernel.org>
Daniel Borkmann <daniel@iogearbox.net>
Andrew Morton <akpm@linux-foundation.org>
Krzysztof Kozlowski <krzk@kernel.org>
Valentin Schneider <valentin.schneider@arm.com>
Nick Terrell <terrelln@fb.com>
"Eric W. Biederman" <ebiederm@xmission.com>
Johannes Weiner <hannes@cmpxchg.org>
linux-kernel@vger.kernel.org
clang-built-linux@googlegroups.com


kbuild: use interpreters to invoke scripts-

Masahiro Yamada <masahiroy@kernel.org>
Michal Marek <michal.lkml@markovi.net>
Catalin Marinas <catalin.marinas@arm.com>
Will Deacon <will@kernel.org>
Tony Luck <tony.luck@intel.com>
Fenghua Yu <fenghua.yu@intel.com>
Nick Hu <nickhu@andestech.com>
Greentime Hu <green.hu@gmail.com>
Vincent Chen <deanbo422@gmail.com>
Vincenzo Frascino <vincenzo.frascino@arm.com>
Kees Cook <keescook@chromium.org>
Nick Desaulniers <ndesaulniers@google.com>
Alexander Popov <alex.popov@linux.com>
Mark Brown <broonie@kernel.org>
Sami Tolvanen <samitolvanen@google.com>
Nathan Chancellor <natechancellor@gmail.com>
Denis Efremov <efremov@linux.com>
linux-kbuild@vger.kernel.org
linux-kernel@vger.kernel.org
linux-arm-kernel@lists.infradead.org
linux-ia64@vger.kernel.org

> 
> Then we check that we did not miss anyone important for these two patches.
> 
> Please resend the two mentioned patches again as patch series with a cover 
> letter.
> 
> We are getting close now to sending this to the larger group of kernel 
> developers.
> 
> Good progress so far.
> 
> Lukas
> 
>> ---
>>  init/Kconfig | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/init/Kconfig b/init/Kconfig
>> index 91456ac0ef20..335c8fcb99af 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -30,12 +30,12 @@ config CC_IS_GCC
>>  
>>  config GCC_VERSION
>>  	int
>> -	default $(shell,$(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
>> +	default $(shell,$(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
>>  	default 0
>>  
>>  config LD_VERSION
>>  	int
>> -	default $(shell,$(LD) --version | $(srctree)/scripts/ld-version.sh)
>> +	default $(shell,$(LD) --version | $(AWK) -f $(srctree)/scripts/ld-version.sh)
>>  
>>  config CC_IS_CLANG
>>  	def_bool $(success,echo "$(CC_VERSION_TEXT)" | grep -q clang)
>> @@ -45,20 +45,20 @@ config LD_IS_LLD
>>  
>>  config CLANG_VERSION
>>  	int
>> -	default $(shell,$(srctree)/scripts/clang-version.sh $(CC))
>> +	default $(shell,$(CONFIG_SHELL) $(srctree)/scripts/clang-version.sh $(CC))
>>  
>>  config CC_CAN_LINK
>>  	bool
>> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag)) if 64BIT
>> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag))
>> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag)) if 64BIT
>> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag))
>>  
>>  config CC_CAN_LINK_STATIC
>>  	bool
>> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag) -static) if 64BIT
>> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag) -static)
>> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag) -static) if 64BIT
>> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag) -static)
>>  
>>  config CC_HAS_ASM_GOTO
>> -	def_bool $(success,$(srctree)/scripts/gcc-goto.sh $(CC))
>> +	def_bool $(success,$(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC))
>>  
>>  config CC_HAS_ASM_GOTO_OUTPUT
>>  	depends on CC_HAS_ASM_GOTO
>> -- 
>> 2.26.2
>>
>>

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH RFC] kconfig: use interpreters to invoke scripts
  2020-10-02  7:10   ` Ujjwal Kumar
@ 2020-10-03  7:05     ` Lukas Bulwahn
  2020-10-03 14:30       ` Ujjwal Kumar
  0 siblings, 1 reply; 6+ messages in thread
From: Lukas Bulwahn @ 2020-10-03  7:05 UTC (permalink / raw)
  To: Ujjwal Kumar; +Cc: linux-kernel-mentees



On Fri, 2 Oct 2020, Ujjwal Kumar wrote:

> On 02/10/20 9:20 am, Lukas Bulwahn wrote:
> > 
> > 
> > On Fri, 2 Oct 2020, Ujjwal Kumar wrote:
> > 
> >> We cannot rely on execute bits to be set on files in the repository.
> >> The build script should use the explicit interpreter when invoking any 
> >> script from the repository.
> >>
> >> Link: https://lore.kernel.org/lkml/20200830174409.c24c3f67addcce0cea9a9d4c@linux-foundation.org/
> >> Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/
> >>
> >> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> >> Suggested-by: Kees Cook <keescook@chromium.org>
> >> Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> >> Signed-off-by: Ujjwal Kumar <ujjwalkumar0501@gmail.com>
> > 
> > 
> > Ujjwal, you have nicely split the patches. I suggest you send out this 
> > patch and the patch "kbuild: use interpreters to incoke scripts" together 
> > as one patch series.
> > 
> > You just need to write a cover letter and explain there which steps you 
> > did to find this being wrong before and what you did to test that it is 
> > now corrected.
> > 
> > Also, can you please share on this list to whom/which lists you would send 
> > this patch series?Running 'get_maintainer.pl' script I get the following list.
> 
> kconfig: use interpreters to invoke scripts-
> 

Make those people explicitly to:

> Nathan Chancellor <natechancellor@gmail.com>
> Nick Desaulniers <ndesaulniers@google.com>

Nathan and Nick were working on the multi-compier support.

> Masahiro Yamada <masahiroy@kernel.org>

Masahiro-san is the important maintainer here.
also add Michal Marek.

I guess they are all optional:

> "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> Masami Hiramatsu <mhiramat@kernel.org>
> Daniel Borkmann <daniel@iogearbox.net>
> Andrew Morton <akpm@linux-foundation.org>
> Krzysztof Kozlowski <krzk@kernel.org>
> Valentin Schneider <valentin.schneider@arm.com>
> Nick Terrell <terrelln@fb.com>
> "Eric W. Biederman" <ebiederm@xmission.com>
> Johannes Weiner <hannes@cmpxchg.org>


Yes, the mailing lists should be added:

> linux-kernel@vger.kernel.org
> clang-built-linux@googlegroups.com
>

also add the linux-kbuild mailing list.

> 
> kbuild: use interpreters to invoke scripts-
> 

These are the important maintainers:

> Masahiro Yamada <masahiroy@kernel.org>
> Michal Marek <michal.lkml@markovi.net>


I think these are mainly developers that some of the lines;

maybe just put them CC:

> Catalin Marinas <catalin.marinas@arm.com>
> Will Deacon <will@kernel.org>
> Tony Luck <tony.luck@intel.com>
> Fenghua Yu <fenghua.yu@intel.com>
> Nick Hu <nickhu@andestech.com>
> Greentime Hu <green.hu@gmail.com>
> Vincent Chen <deanbo422@gmail.com>
> Vincenzo Frascino <vincenzo.frascino@arm.com>
> Kees Cook <keescook@chromium.org>
> Nick Desaulniers <ndesaulniers@google.com>
> Alexander Popov <alex.popov@linux.com>
> Mark Brown <broonie@kernel.org>
> Sami Tolvanen <samitolvanen@google.com>
> Nathan Chancellor <natechancellor@gmail.com>
> Denis Efremov <efremov@linux.com>


Mailing lists looks good:

> linux-kbuild@vger.kernel.org
> linux-kernel@vger.kernel.org
> linux-arm-kernel@lists.infradead.org
> linux-ia64@vger.kernel.org
>

I think you have a good list.

Lukas
 
> > 
> > Then we check that we did not miss anyone important for these two patches.
> > 
> > Please resend the two mentioned patches again as patch series with a cover 
> > letter.
> > 
> > We are getting close now to sending this to the larger group of kernel 
> > developers.
> > 
> > Good progress so far.
> > 
> > Lukas
> > 
> >> ---
> >>  init/Kconfig | 16 ++++++++--------
> >>  1 file changed, 8 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/init/Kconfig b/init/Kconfig
> >> index 91456ac0ef20..335c8fcb99af 100644
> >> --- a/init/Kconfig
> >> +++ b/init/Kconfig
> >> @@ -30,12 +30,12 @@ config CC_IS_GCC
> >>  
> >>  config GCC_VERSION
> >>  	int
> >> -	default $(shell,$(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
> >> +	default $(shell,$(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
> >>  	default 0
> >>  
> >>  config LD_VERSION
> >>  	int
> >> -	default $(shell,$(LD) --version | $(srctree)/scripts/ld-version.sh)
> >> +	default $(shell,$(LD) --version | $(AWK) -f $(srctree)/scripts/ld-version.sh)
> >>  
> >>  config CC_IS_CLANG
> >>  	def_bool $(success,echo "$(CC_VERSION_TEXT)" | grep -q clang)
> >> @@ -45,20 +45,20 @@ config LD_IS_LLD
> >>  
> >>  config CLANG_VERSION
> >>  	int
> >> -	default $(shell,$(srctree)/scripts/clang-version.sh $(CC))
> >> +	default $(shell,$(CONFIG_SHELL) $(srctree)/scripts/clang-version.sh $(CC))
> >>  
> >>  config CC_CAN_LINK
> >>  	bool
> >> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag)) if 64BIT
> >> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag))
> >> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag)) if 64BIT
> >> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag))
> >>  
> >>  config CC_CAN_LINK_STATIC
> >>  	bool
> >> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag) -static) if 64BIT
> >> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag) -static)
> >> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag) -static) if 64BIT
> >> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag) -static)
> >>  
> >>  config CC_HAS_ASM_GOTO
> >> -	def_bool $(success,$(srctree)/scripts/gcc-goto.sh $(CC))
> >> +	def_bool $(success,$(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC))
> >>  
> >>  config CC_HAS_ASM_GOTO_OUTPUT
> >>  	depends on CC_HAS_ASM_GOTO
> >> -- 
> >> 2.26.2
> >>
> >>
> 
> 
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH RFC] kconfig: use interpreters to invoke scripts
  2020-10-03  7:05     ` Lukas Bulwahn
@ 2020-10-03 14:30       ` Ujjwal Kumar
  2020-10-03 14:45         ` Lukas Bulwahn
  0 siblings, 1 reply; 6+ messages in thread
From: Ujjwal Kumar @ 2020-10-03 14:30 UTC (permalink / raw)
  To: Lukas Bulwahn; +Cc: linux-kernel-mentees

On 03/10/20 12:35 pm, Lukas Bulwahn wrote:
> 
> 
> On Fri, 2 Oct 2020, Ujjwal Kumar wrote:
> 
>> On 02/10/20 9:20 am, Lukas Bulwahn wrote:
>>>
>>>
>>> On Fri, 2 Oct 2020, Ujjwal Kumar wrote:
>>>
>>>> We cannot rely on execute bits to be set on files in the repository.
>>>> The build script should use the explicit interpreter when invoking any 
>>>> script from the repository.
>>>>
>>>> Link: https://lore.kernel.org/lkml/20200830174409.c24c3f67addcce0cea9a9d4c@linux-foundation.org/
>>>> Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/
>>>>
>>>> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
>>>> Suggested-by: Kees Cook <keescook@chromium.org>
>>>> Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>>>> Signed-off-by: Ujjwal Kumar <ujjwalkumar0501@gmail.com>
>>>
>>>
>>> Ujjwal, you have nicely split the patches. I suggest you send out this 
>>> patch and the patch "kbuild: use interpreters to incoke scripts" together 
>>> as one patch series.
>>>
>>> You just need to write a cover letter and explain there which steps you 
>>> did to find this being wrong before and what you did to test that it is 
>>> now corrected.
>>>
>>> Also, can you please share on this list to whom/which lists you would send 
>>> this patch series?Running 'get_maintainer.pl' script I get the following list.
>>
>> kconfig: use interpreters to invoke scripts-
>>
> 
> Make those people explicitly to:
> 
>> Nathan Chancellor <natechancellor@gmail.com>
>> Nick Desaulniers <ndesaulniers@google.com>
> 
> Nathan and Nick were working on the multi-compier support.
> 
>> Masahiro Yamada <masahiroy@kernel.org>
> 
> Masahiro-san is the important maintainer here.
> also add Michal Marek.
> 
> I guess they are all optional:
> 
>> "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>> Masami Hiramatsu <mhiramat@kernel.org>
>> Daniel Borkmann <daniel@iogearbox.net>
>> Andrew Morton <akpm@linux-foundation.org>
>> Krzysztof Kozlowski <krzk@kernel.org>
>> Valentin Schneider <valentin.schneider@arm.com>
>> Nick Terrell <terrelln@fb.com>
>> "Eric W. Biederman" <ebiederm@xmission.com>
>> Johannes Weiner <hannes@cmpxchg.org>
> 
> 
> Yes, the mailing lists should be added:
> 
>> linux-kernel@vger.kernel.org
>> clang-built-linux@googlegroups.com
>>
> 
> also add the linux-kbuild mailing list.
> 
>>
>> kbuild: use interpreters to invoke scripts-
>>
> 
> These are the important maintainers:
> 
>> Masahiro Yamada <masahiroy@kernel.org>
>> Michal Marek <michal.lkml@markovi.net>
> 
> 
> I think these are mainly developers that some of the lines;
> 
> maybe just put them CC:
> 
>> Catalin Marinas <catalin.marinas@arm.com>
>> Will Deacon <will@kernel.org>
>> Tony Luck <tony.luck@intel.com>
>> Fenghua Yu <fenghua.yu@intel.com>
>> Nick Hu <nickhu@andestech.com>
>> Greentime Hu <green.hu@gmail.com>
>> Vincent Chen <deanbo422@gmail.com>
>> Vincenzo Frascino <vincenzo.frascino@arm.com>
>> Kees Cook <keescook@chromium.org>
>> Nick Desaulniers <ndesaulniers@google.com>
>> Alexander Popov <alex.popov@linux.com>
>> Mark Brown <broonie@kernel.org>
>> Sami Tolvanen <samitolvanen@google.com>
>> Nathan Chancellor <natechancellor@gmail.com>
>> Denis Efremov <efremov@linux.com>
> 
> 
> Mailing lists looks good:
> 
>> linux-kbuild@vger.kernel.org
>> linux-kernel@vger.kernel.org
>> linux-arm-kernel@lists.infradead.org
>> linux-ia64@vger.kernel.org
>>
> 
> I think you have a good list.

For PATCH 1/2:
Nathan Chancellor <natechancellor@gmail.com>
Nick Desaulniers <ndesaulniers@google.com>
Masahiro Yamada <masahiroy@kernel.org>
Michal Marek <michal.lkml@markovi.net>
linux-kbuild@vger.kernel.org
linux-kernel@vger.kernel.org
clang-built-linux@googlegroups.com
linux-kernel-mentees@lists.linuxfoundation.org

For PATCH 2/2:
Nathan Chancellor <natechancellor@gmail.com>
Nick Desaulniers <ndesaulniers@google.com>
Masahiro Yamada <masahiroy@kernel.org>
Michal Marek <michal.lkml@markovi.net>
linux-kbuild@vger.kernel.org
linux-kernel@vger.kernel.org
linux-arm-kernel@lists.infradead.org
linux-ia64@vger.kernel.org
linux-kernel-mentees@lists.linuxfoundation.org

Is it okay to send one patch from the series to a recipient and skip 
the other patches?
Should I merge recipients for each patch into one to create a common list 
of recipients for all the patches (with cover letter) in the series?
And send all the patches (with cover letter) to that common list.

Thanks
Ujjwal Kumar

> 
> Lukas
>  
>>>
>>> Then we check that we did not miss anyone important for these two patches.
>>>
>>> Please resend the two mentioned patches again as patch series with a cover 
>>> letter.
>>>
>>> We are getting close now to sending this to the larger group of kernel 
>>> developers.
>>>
>>> Good progress so far.
>>>
>>> Lukas
>>>
>>>> ---
>>>>  init/Kconfig | 16 ++++++++--------
>>>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>>>
>>>> diff --git a/init/Kconfig b/init/Kconfig
>>>> index 91456ac0ef20..335c8fcb99af 100644
>>>> --- a/init/Kconfig
>>>> +++ b/init/Kconfig
>>>> @@ -30,12 +30,12 @@ config CC_IS_GCC
>>>>  
>>>>  config GCC_VERSION
>>>>  	int
>>>> -	default $(shell,$(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
>>>> +	default $(shell,$(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
>>>>  	default 0
>>>>  
>>>>  config LD_VERSION
>>>>  	int
>>>> -	default $(shell,$(LD) --version | $(srctree)/scripts/ld-version.sh)
>>>> +	default $(shell,$(LD) --version | $(AWK) -f $(srctree)/scripts/ld-version.sh)
>>>>  
>>>>  config CC_IS_CLANG
>>>>  	def_bool $(success,echo "$(CC_VERSION_TEXT)" | grep -q clang)
>>>> @@ -45,20 +45,20 @@ config LD_IS_LLD
>>>>  
>>>>  config CLANG_VERSION
>>>>  	int
>>>> -	default $(shell,$(srctree)/scripts/clang-version.sh $(CC))
>>>> +	default $(shell,$(CONFIG_SHELL) $(srctree)/scripts/clang-version.sh $(CC))
>>>>  
>>>>  config CC_CAN_LINK
>>>>  	bool
>>>> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag)) if 64BIT
>>>> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag))
>>>> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag)) if 64BIT
>>>> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag))
>>>>  
>>>>  config CC_CAN_LINK_STATIC
>>>>  	bool
>>>> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag) -static) if 64BIT
>>>> -	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag) -static)
>>>> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m64-flag) -static) if 64BIT
>>>> +	default $(success,$(CONFIG_SHELL) $(srctree)/scripts/cc-can-link.sh $(CC) $(CLANG_FLAGS) $(m32-flag) -static)
>>>>  
>>>>  config CC_HAS_ASM_GOTO
>>>> -	def_bool $(success,$(srctree)/scripts/gcc-goto.sh $(CC))
>>>> +	def_bool $(success,$(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC))
>>>>  
>>>>  config CC_HAS_ASM_GOTO_OUTPUT
>>>>  	depends on CC_HAS_ASM_GOTO
>>>> -- 
>>>> 2.26.2
>>>>
>>>>
>>
>>

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH RFC] kconfig: use interpreters to invoke scripts
  2020-10-03 14:30       ` Ujjwal Kumar
@ 2020-10-03 14:45         ` Lukas Bulwahn
  0 siblings, 0 replies; 6+ messages in thread
From: Lukas Bulwahn @ 2020-10-03 14:45 UTC (permalink / raw)
  To: Ujjwal Kumar; +Cc: linux-kernel-mentees



On Sat, 3 Oct 2020, Ujjwal Kumar wrote:

> On 03/10/20 12:35 pm, Lukas Bulwahn wrote:
> > 
> > 
> > On Fri, 2 Oct 2020, Ujjwal Kumar wrote:
> > 
> >> On 02/10/20 9:20 am, Lukas Bulwahn wrote:
> >>>
> >>>
> >>> On Fri, 2 Oct 2020, Ujjwal Kumar wrote:
> >>>
> >>>> We cannot rely on execute bits to be set on files in the repository.
> >>>> The build script should use the explicit interpreter when invoking any 
> >>>> script from the repository.
> >>>>
> >>>> Link: https://lore.kernel.org/lkml/20200830174409.c24c3f67addcce0cea9a9d4c@linux-foundation.org/
> >>>> Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/
> >>>>
> >>>> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> >>>> Suggested-by: Kees Cook <keescook@chromium.org>
> >>>> Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> >>>> Signed-off-by: Ujjwal Kumar <ujjwalkumar0501@gmail.com>
> >>>
> >>>
> >>> Ujjwal, you have nicely split the patches. I suggest you send out this 
> >>> patch and the patch "kbuild: use interpreters to incoke scripts" together 
> >>> as one patch series.
> >>>
> >>> You just need to write a cover letter and explain there which steps you 
> >>> did to find this being wrong before and what you did to test that it is 
> >>> now corrected.
> >>>
> >>> Also, can you please share on this list to whom/which lists you would send 
> >>> this patch series?Running 'get_maintainer.pl' script I get the following list.
> >>
> >> kconfig: use interpreters to invoke scripts-
> >>
> > 
> > Make those people explicitly to:
> > 
> >> Nathan Chancellor <natechancellor@gmail.com>
> >> Nick Desaulniers <ndesaulniers@google.com>
> > 
> > Nathan and Nick were working on the multi-compier support.
> > 
> >> Masahiro Yamada <masahiroy@kernel.org>
> > 
> > Masahiro-san is the important maintainer here.
> > also add Michal Marek.
> > 
> > I guess they are all optional:
> > 
> >> "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >> Masami Hiramatsu <mhiramat@kernel.org>
> >> Daniel Borkmann <daniel@iogearbox.net>
> >> Andrew Morton <akpm@linux-foundation.org>
> >> Krzysztof Kozlowski <krzk@kernel.org>
> >> Valentin Schneider <valentin.schneider@arm.com>
> >> Nick Terrell <terrelln@fb.com>
> >> "Eric W. Biederman" <ebiederm@xmission.com>
> >> Johannes Weiner <hannes@cmpxchg.org>
> > 
> > 
> > Yes, the mailing lists should be added:
> > 
> >> linux-kernel@vger.kernel.org
> >> clang-built-linux@googlegroups.com
> >>
> > 
> > also add the linux-kbuild mailing list.
> > 
> >>
> >> kbuild: use interpreters to invoke scripts-
> >>
> > 
> > These are the important maintainers:
> > 
> >> Masahiro Yamada <masahiroy@kernel.org>
> >> Michal Marek <michal.lkml@markovi.net>
> > 
> > 
> > I think these are mainly developers that some of the lines;
> > 
> > maybe just put them CC:
> > 
> >> Catalin Marinas <catalin.marinas@arm.com>
> >> Will Deacon <will@kernel.org>
> >> Tony Luck <tony.luck@intel.com>
> >> Fenghua Yu <fenghua.yu@intel.com>
> >> Nick Hu <nickhu@andestech.com>
> >> Greentime Hu <green.hu@gmail.com>
> >> Vincent Chen <deanbo422@gmail.com>
> >> Vincenzo Frascino <vincenzo.frascino@arm.com>
> >> Kees Cook <keescook@chromium.org>
> >> Nick Desaulniers <ndesaulniers@google.com>
> >> Alexander Popov <alex.popov@linux.com>
> >> Mark Brown <broonie@kernel.org>
> >> Sami Tolvanen <samitolvanen@google.com>
> >> Nathan Chancellor <natechancellor@gmail.com>
> >> Denis Efremov <efremov@linux.com>
> > 
> > 
> > Mailing lists looks good:
> > 
> >> linux-kbuild@vger.kernel.org
> >> linux-kernel@vger.kernel.org
> >> linux-arm-kernel@lists.infradead.org
> >> linux-ia64@vger.kernel.org
> >>
> > 
> > I think you have a good list.
> 
> For PATCH 1/2:
> Nathan Chancellor <natechancellor@gmail.com>
> Nick Desaulniers <ndesaulniers@google.com>
> Masahiro Yamada <masahiroy@kernel.org>
> Michal Marek <michal.lkml@markovi.net>
> linux-kbuild@vger.kernel.org
> linux-kernel@vger.kernel.org
> clang-built-linux@googlegroups.com
> linux-kernel-mentees@lists.linuxfoundation.org
> 
> For PATCH 2/2:
> Nathan Chancellor <natechancellor@gmail.com>
> Nick Desaulniers <ndesaulniers@google.com>
> Masahiro Yamada <masahiroy@kernel.org>
> Michal Marek <michal.lkml@markovi.net>
> linux-kbuild@vger.kernel.org
> linux-kernel@vger.kernel.org
> linux-arm-kernel@lists.infradead.org
> linux-ia64@vger.kernel.org
> linux-kernel-mentees@lists.linuxfoundation.org
> 
> Is it okay to send one patch from the series to a recipient and skip 
> the other patches?
> Should I merge recipients for each patch into one to create a common list 
> of recipients for all the patches (with cover letter) in the series?
> And send all the patches (with cover letter) to that common list.
>

Both options are fine. I think it is up to your personal preference.


Merging them is probably just easier to write a git send-email command.

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-10-03 14:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 19:52 [Linux-kernel-mentees] [PATCH RFC] kconfig: use interpreters to invoke scripts Ujjwal Kumar
2020-10-02  3:50 ` Lukas Bulwahn
2020-10-02  7:10   ` Ujjwal Kumar
2020-10-03  7:05     ` Lukas Bulwahn
2020-10-03 14:30       ` Ujjwal Kumar
2020-10-03 14:45         ` Lukas Bulwahn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).