From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: sean@mess.org, linux-kernel@vger.kernel.org, tglx@linutronix.de,
mchehab@kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-media@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton
Date: Thu, 9 Jan 2020 17:43:13 -0300 [thread overview]
Message-ID: <c242068a-ad8c-be27-4c95-22cb5ff17216@gmail.com> (raw)
In-Reply-To: <20200109155437.GA568342@kroah.com>
Hi Greg! Thanks for chiming in.
> As you are a driver, you should never need to call any pr_* calls,
> instead use dev_*(). For this, you can use dev_dbg(), but really, why
> is that even needed except for your debugging bringup. And for that,
> you can use ftrace, right? So no need for any printing of anything
> here.
> Again, dev_err() would be proper, but there's no need for any error
> message here.
Let's take these out in v2 then.
> Don't you need to register the tuner ops with something in this
> function?
> Don't you need to unregister the tuner ops in here?
It is my understanding that bridge drivers are the ones responsible for
this. For instance, I don't see this with either xc4000.c, xc5000.c or
mt2060.c. I could be wrong, though. Maybe Mauro could clarify this?
What I did miss in this patch was an attach function. Let's also add
this in v2.
Thanks again,
- Daniel.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-01-09 20:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 15:24 [Linux-kernel-mentees] [PATCH 0/1] Implement a DVB Dummy Tuner Daniel W. S. Almeida
2020-01-09 15:24 ` [Linux-kernel-mentees] [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton Daniel W. S. Almeida
2020-01-09 15:54 ` Greg KH
2020-01-09 20:43 ` Daniel W. S. Almeida [this message]
2020-01-09 16:13 ` Mauro Carvalho Chehab
2020-01-09 20:52 ` Daniel W. S. Almeida
2020-01-09 16:45 ` Shuah Khan
2020-01-09 21:00 ` Daniel W. S. Almeida
2020-01-09 21:11 ` Shuah Khan
2020-01-09 16:07 ` [Linux-kernel-mentees] [PATCH 0/1] Implement a DVB Dummy Tuner Mauro Carvalho Chehab
2020-01-09 20:51 ` Daniel W. S. Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c242068a-ad8c-be27-4c95-22cb5ff17216@gmail.com \
--to=dwlsalmeida@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).