From: Randy Dunlap <rdunlap@infradead.org>
To: Vitor Massaru Iha <vitor@massaru.org>, dri-devel@lists.freedesktop.org
Cc: brendanhiggins@google.com, linux-kernel@vger.kernel.org,
linaro-mm-sig@lists.linaro.org,
linux-kernel-mentees@lists.linuxfoundation.org,
sumit.semwal@linaro.org, linux-media@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings
Date: Wed, 29 Apr 2020 19:06:55 -0700 [thread overview]
Message-ID: <cb4d93a0-b967-f37d-ea01-0368c91b896e@infradead.org> (raw)
In-Reply-To: <20200430015930.32224-1-vitor@massaru.org>
On 4/29/20 6:59 PM, Vitor Massaru Iha wrote:
> Add missed ":" on kernel-doc function parameter.
>
> This patch fixes this warnings from `make htmldocs`:
> ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or member 'importer_ops' not described in 'dma_buf_dynamic_attach'
> ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or member 'importer_priv' not described in 'dma_buf_dynamic_attach'
>
> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> ---
> drivers/dma-buf/dma-buf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index ccc9eda1bc28..0756d2155745 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -655,8 +655,8 @@ EXPORT_SYMBOL_GPL(dma_buf_put);
> * calls attach() of dma_buf_ops to allow device-specific attach functionality
> * @dmabuf: [in] buffer to attach device to.
> * @dev: [in] device to be attached.
> - * @importer_ops [in] importer operations for the attachment
> - * @importer_priv [in] importer private pointer for the attachment
> + * @importer_ops: [in] importer operations for the attachment
> + * @importer_priv: [in] importer private pointer for the attachment
> *
> * Returns struct dma_buf_attachment pointer for this attachment. Attachments
> * must be cleaned up by calling dma_buf_detach().
>
Sumit said that he would be applying my patch from April 7:
https://lore.kernel.org/linux-media/7bcbe6fe-0b4b-87da-d003-b68a26eb4cf0@infradead.org/
thanks.
--
~Randy
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-04-30 2:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 1:59 [Linux-kernel-mentees] [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings Vitor Massaru Iha
2020-04-30 2:06 ` Randy Dunlap [this message]
2020-04-30 2:27 ` Vitor Massaru Iha
2020-04-30 4:37 ` Sam Ravnborg
2020-04-30 14:20 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb4d93a0-b967-f37d-ea01-0368c91b896e@infradead.org \
--to=rdunlap@infradead.org \
--cc=brendanhiggins@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).