From: Johannes Berg <johannes@sipsolutions.net>
To: Brendan Higgins <brendanhiggins@google.com>,
Vitor Massaru Iha <vitor@massaru.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
kvalo@codeaurora.org,
KUnit Development <kunit-dev@googlegroups.com>
Subject: Re: [Linux-kernel-mentees] [PATCH] lib: kunit: add bitfield test conversion to KUnit
Date: Thu, 17 Sep 2020 12:00:12 +0200 [thread overview]
Message-ID: <cfcb01c087fdd9f22a875721444a7659bceec05f.camel@sipsolutions.net> (raw)
In-Reply-To: <CAFd5g47s09BfsqNx2RY1Zdp-TC4KbKgsMgr9-SHv1Nf6P9vAMQ@mail.gmail.com> (sfid-20200819_231025_419730_3D8DCC68)
On Wed, 2020-08-19 at 14:10 -0700, Brendan Higgins wrote:
> On Wed, Jul 29, 2020 at 10:58 AM Vitor Massaru Iha <vitor@massaru.org> wrote:
> > This adds the conversion of the runtime tests of test_bitfield,
> > from `lib/test_bitfield.c` to KUnit tests.
> >
> > Please apply this commit first (linux-kselftest/kunit-fixes):
> > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space
> >
> > Code Style Documentation: [0]
> >
> > Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> > Link: [0] https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-davidgow@google.com/T/#u
>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
>
> Probably still want a review from Johannes though.
Huh, sorry, this slipped through the cracks.
Yeah, don't really care, looks fine to me? I'm not familiar with the
kunit infrastructure much yet.
Not sure I see much value in converting TEST_BITFIELD_COMPILE to a
KUNIT_CASE though, because anyway it will not compile if you enable
that? IOW, just leaving the function there without any KUNIT_CASE()
reference to it should be fine and saves you an ifdef ...
johannes
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-17 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 17:58 [Linux-kernel-mentees] [PATCH] lib: kunit: add bitfield test conversion to KUnit Vitor Massaru Iha
2020-08-19 21:10 ` Brendan Higgins via Linux-kernel-mentees
2020-09-17 10:00 ` Johannes Berg [this message]
2020-10-10 5:43 ` Brendan Higgins via Linux-kernel-mentees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfcb01c087fdd9f22a875721444a7659bceec05f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andy.shevchenko@gmail.com \
--cc=brendanhiggins@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).