From: Joe Perches <firstname.lastname@example.org>
To: Ujjwal Kumar <email@example.com>,
Lukas Bulwahn <firstname.lastname@example.org>
Subject: Re: [Linux-kernel-mentees] [RFC PATCH] checkpatch: add shebang check to EXECUTE_PERMISSIONS
Date: Mon, 12 Oct 2020 08:08:24 -0700 [thread overview]
Message-ID: <email@example.com> (raw)
On Mon, 2020-10-12 at 19:22 +0530, Ujjwal Kumar wrote:
> On 12/10/20 11:47 am, Joe Perches wrote:
> > On Mon, 2020-10-12 at 11:19 +0530, Ujjwal Kumar wrote:
> > > checkpatch.pl checks for invalid EXECUTE_PERMISSIONS on source
> > > files. The script leverages filename extensions and its path in
> > > the repository to decide whether to allow execute permissions on
> > > the file or not.
> > >
> > > Based on current check conditions, a perl script file having
> > > execute permissions, without '.pl' extension in its filename
> > > and not belonging to 'scripts/' directory is reported as ERROR
> > > which is a false-positive.
> > >
> > > Adding a shebang check along with current conditions will make
> > > the check more generalised and improve checkpatch reports.
> > > To do so, without breaking the core design decision of checkpatch,
> > > we can fetch the first line from the patch itself and match it for
> > > a shebang pattern.
> > >
> > > There can be cases where the first line is not part of the patch.
> > For instance: a patch that only changes permissions
> > without changing any of the file content.
Please add verbiage like this to the commit message.
> Should these new changes go as a separate patch or can they be
> included in the next iteration of this patch?
Linux-kernel-mentees mailing list
next prev parent reply other threads:[~2020-10-12 16:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 5:49 [Linux-kernel-mentees] [RFC PATCH] checkpatch: add shebang check to EXECUTE_PERMISSIONS Ujjwal Kumar
2020-10-12 6:17 ` Joe Perches
2020-10-12 13:52 ` Ujjwal Kumar
2020-10-12 14:16 ` Lukas Bulwahn
2020-10-12 15:23 ` Joe Perches
2020-10-12 15:08 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-12 4:36 Ujjwal Kumar
2020-10-12 5:25 ` Lukas Bulwahn
2020-10-11 16:21 Ujjwal Kumar
2020-10-11 16:40 ` Ujjwal Kumar
2020-10-11 17:50 ` Lukas Bulwahn
2020-10-11 18:14 ` Ujjwal Kumar
2020-10-11 18:19 ` Lukas Bulwahn
2020-10-11 18:32 ` Ujjwal Kumar
2020-10-11 18:35 ` Lukas Bulwahn
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).