From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: sean@mess.org, linux-kernel@vger.kernel.org, tglx@linutronix.de,
mchehab@kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-media@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] media: dvb_dummy_tuner: implement driver skeleton
Date: Mon, 13 Jan 2020 15:23:02 -0300 [thread overview]
Message-ID: <d6d119cf-7447-31ce-37db-25503cf2f9bc@gmail.com> (raw)
In-Reply-To: <20200110073024.GA156006@kroah.com>
Hi Greg,
I am working on v3. Would you mind clarifying this?
>> + *
>> + * The virtual DVB test driver serves as a reference DVB driver and helps
>> + * validate the existing APIs in the media subsystem. It can also aid developers
>> + * working on userspace applications.
>> + *
>> + * This dummy tuner should support common TV standards such as DVB-T/T2/S/S2,
>> + * ISDB-T and ATSC when completed.
>> + *
>> + * Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida@gmail.com>
> Normally this is the first comment line above in this block.
>
Just so we're clear, do you mean this? e.g.:
+ * Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida@gmail.com>
+ *
+ * The virtual DVB test driver serves as a reference DVB driver and helps
+ * validate the existing APIs in the media subsystem. It can also aid developers
+ * working on userspace applications.
+ *
+ * This dummy tuner should support common TV standards such as DVB-T/T2/S/S2,
+ * ISDB-T and ATSC when completed.
+ *
> Not the same license as your .c file? Odd :(
Oops! :(
> If you keep this file, same comments as above for the comment block, but
> really, you don't need this .h file at all, just drop it.
OK.
- Daniel
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-01-13 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 23:37 [Linux-kernel-mentees] [PATCH v2] media: dvb_dummy_tuner: implement driver skeleton Daniel W. S. Almeida
2020-01-09 23:50 ` Shuah Khan
2020-01-10 7:30 ` Greg KH
2020-01-13 18:23 ` Daniel W. S. Almeida [this message]
2020-01-13 18:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6d119cf-7447-31ce-37db-25503cf2f9bc@gmail.com \
--to=dwlsalmeida@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).