On Wed, Mar 13, 2024 at 8:07 AM Kohshi Yamaguchi <kohshi54.yam@gmail.com> wrote:
>
> subscribe request to linux-kernel-mentees
>
> Thanks,
>
Dear Kohshi-san, this email above is NOT how to subscribe to this mailing list.
Good luck with your next attempt,
Lukas
subscribe request to linux-kernel-mentees Thanks, Kohshi Yamaguchi
On Tue 05-03-24 12:21:02, syzbot wrote:
> syzbot suspects this issue was fixed by commit:
>
> commit 6f861765464f43a71462d52026fbddfc858239a5
> Author: Jan Kara <jack@suse.cz>
> Date: Wed Nov 1 17:43:10 2023 +0000
>
> fs: Block writes to mounted block devices
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12be09f2180000
> start commit: afead42fdfca Merge tag 'perf-tools-fixes-for-v6.4-2-2023-0..
> git tree: upstream
> kernel config: https://syzkaller.appspot.com/x/.config?x=162cf2103e4a7453
> dashboard link: https://syzkaller.appspot.com/bug?extid=4768a8f039aa677897d0
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12da9bbd280000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=174e8115280000
>
> If the result looks correct, please mark the issue as fixed by replying with:
The reproducer is just mounting the fs so I'm not sure what's happening
there. But since there's no working repro and this is ntfs3:
#syz fix: fs: Block writes to mounted block devices
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
syzbot suspects this issue was fixed by commit: commit 6f861765464f43a71462d52026fbddfc858239a5 Author: Jan Kara <jack@suse.cz> Date: Wed Nov 1 17:43:10 2023 +0000 fs: Block writes to mounted block devices bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12be09f2180000 start commit: afead42fdfca Merge tag 'perf-tools-fixes-for-v6.4-2-2023-0.. git tree: upstream kernel config: https://syzkaller.appspot.com/x/.config?x=162cf2103e4a7453 dashboard link: https://syzkaller.appspot.com/bug?extid=4768a8f039aa677897d0 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12da9bbd280000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=174e8115280000 If the result looks correct, please mark the issue as fixed by replying with: #syz fix: fs: Block writes to mounted block devices For information about bisection process see: https://goo.gl/tpsmEJ#bisection
With python 3.12, '\.' results in this warning SyntaxWarning: invalid escape sequence '\.' Signed-off-by: Andrew Ballance <andrewjballance@gmail.com> --- scripts/gdb/linux/symbols.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py index c8047f4441e6..e8316beb17a7 100644 --- a/scripts/gdb/linux/symbols.py +++ b/scripts/gdb/linux/symbols.py @@ -82,7 +82,7 @@ lx-symbols command.""" self.module_files_updated = True def _get_module_file(self, module_name): - module_pattern = ".*/{0}\.ko(?:.debug)?$".format( + module_pattern = r".*/{0}\.ko(?:.debug)?$".format( module_name.replace("_", r"[_\-]")) for name in self.module_files: if re.match(module_pattern, name) and os.path.exists(name): -- 2.44.0
syzbot suspects this issue was fixed by commit: commit 6f861765464f43a71462d52026fbddfc858239a5 Author: Jan Kara <jack@suse.cz> Date: Wed Nov 1 17:43:10 2023 +0000 fs: Block writes to mounted block devices bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14b5e754180000 start commit: 8689f4f2ea56 Merge tag 'mmc-v6.5-2' of git://git.kernel.or.. git tree: upstream kernel config: https://syzkaller.appspot.com/x/.config?x=15873d91ff37a949 dashboard link: https://syzkaller.appspot.com/bug?extid=fc26c366038b54261e53 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14237dc2a80000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13e34d22a80000 If the result looks correct, please mark the issue as fixed by replying with: #syz fix: fs: Block writes to mounted block devices For information about bisection process see: https://goo.gl/tpsmEJ#bisection
That sequence of steps fixed the warnings. Thank you so much! Regards, Shresth
>Is the declaration of klp_get_state() visible at that >point, i.e. is
>there perhaps any warning about missing >declarations above that?
>
>Otherwise C rules would default to assume an 'int' >return type.
I wasn't aware it works like that. You're right I do see some warnings about implicit function declarations of klp_get_state.
Regards,
Shresth
On 2/21/24 07:44, Nicolai Stange wrote:
> Shresth Prasad <shresthprasad7@gmail.com> writes:
>
>> I checked the source code and yes I am on the latest Linux next repo.
>>
>> Here's the warning:
>> /home/shresthp/dev/linux_work/linux_next/tools/testing/selftests/livepatch/test_modules/test_klp_state.c:38:24: warning: assignment to ‘struct klp_state *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>> 38 | loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> | ^
>
>
> Is the declaration of klp_get_state() visible at that point, i.e. is
> there perhaps any warning about missing declarations above that?
>
> Otherwise C rules would default to assume an 'int' return type.
>
This is an interesting clue. I thought I might be able to reproduce the
build error by modifying include/livepatch.h and running `make -j15 -C
tools/testing/selftests/livepatch` ... but that seemed to work fine on
my system. I even removed the entire include/ subdir from my tree and
it still built the test module. Huh?
Then I moved /lib/modules/$(uname -r)/build out of the way and saw that
the compilation failed. Ah hah -- that's right, it's using the system
build tree. That version of livepatch.h may have a missing or
completely different definition of klp_get_state().
How does this sequence work for you, Shresth:
# Verify that kernel livepatching is turned on
$ grep LIVEPATCH .config
CONFIG_HAVE_LIVEPATCH=y
CONFIG_LIVEPATCH=y
# Build linux-next kernel tree and then the livepatch selftests,
# pointing KDIR to this tree
$ make -j$(nproc) vmlinux && \
make -j$(nproc) KDIR=$(pwd) -C tools/testing/selftests/livepatch
--
Joe
Shresth Prasad <shresthprasad7@gmail.com> writes:
> I checked the source code and yes I am on the latest Linux next repo.
>
> Here's the warning:
> /home/shresthp/dev/linux_work/linux_next/tools/testing/selftests/livepatch/test_modules/test_klp_state.c:38:24: warning: assignment to ‘struct klp_state *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
> 38 | loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
> | ^
Is the declaration of klp_get_state() visible at that point, i.e. is
there perhaps any warning about missing declarations above that?
Otherwise C rules would default to assume an 'int' return type.
Thanks,
Nicolai
--
SUSE Software Solutions Germany GmbH, Frankenstraße 146, 90461 Nürnberg, Germany
GF: Ivo Totev, Andrew McDonald, Werner Knoblich
(HRB 36809, AG Nürnberg)
I checked the source code and yes I am on the latest Linux next repo. Here's the warning: /home/shresthp/dev/linux_work/linux_next/tools/testing/selftests/livepatch/test_modules/test_klp_state.c:38:24: warning: assignment to ‘struct klp_state *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 38 | loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); | ^ /home/shresthp/dev/linux_work/linux_next/tools/testing/selftests/livepatch/test_modules/test_klp_state.c: In function ‘fix_console_loglevel’: /home/shresthp/dev/linux_work/linux_next/tools/testing/selftests/livepatch/test_modules/test_klp_state.c:55:24: warning: assignment to ‘struct klp_state *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 55 | loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); | ^ /home/shresthp/dev/linux_work/linux_next/tools/testing/selftests/livepatch/test_modules/test_klp_state.c: In function ‘restore_console_loglevel’: /home/shresthp/dev/linux_work/linux_next/tools/testing/selftests/livepatch/test_modules/test_klp_state.c:68:24: warning: assignment to ‘struct klp_state *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 68 | loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); | ^ /home/shresthp/dev/linux_work/linux_next/tools/testing/selftests/livepatch/test_modules/test_klp_state.c: In function ‘free_loglevel_state’: /home/shresthp/dev/linux_work/linux_next/tools/testing/selftests/livepatch/test_modules/test_klp_state.c:80:24: warning: assignment to ‘struct klp_state *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 80 | loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); | ^ Thank you for your help so far. Regards, Shresth
Would you please pasting the original warning of your complier?
And did you check your source code if your source code is the the latest version?
Regards,
Warden
> On Feb 20, 2024, at 21:20, Shresth Prasad <shresthprasad7@gmail.com> wrote:
>
>> What compiler version and architecture? Are you >compiling using flags like W=1?
>> I would advise you to always add more information >about how the problem
>> manifests, and what you are executing. This can >help to nail down the issue quicker.
>
> I'll keep that in mind. I'm on an x86_64 system with gcc version 13.2.1 20230801.
>
> I'm using the command `make -j15 -C tools/testing/selftests` with no additional flags.
>
> Regards,
> Shresth
>What compiler version and architecture? Are you >compiling using flags like W=1?
>I would advise you to always add more information >about how the problem
>manifests, and what you are executing. This can >help to nail down the issue quicker.
I'll keep that in mind. I'm on an x86_64 system with gcc version 13.2.1 20230801.
I'm using the command `make -j15 -C tools/testing/selftests` with no additional flags.
Regards,
Shresth
On Tue, 20 Feb 2024 17:23:49 +0530 (GMT+05:30) Shresth Prasad <shresthprasad7@gmail.com> wrote: > Looking at the function definition now, I do see that the function returns a struct pointer but for me the compiler still complains about an implicit conversion from int to struct pointer. > > Is there any particular reason why this might be happening? I couldn't quite figure it out myself as I am very new to working with the kernel. What compiler version and architecture? Are you compiling using flags like W=1? I would advise you to always add more information about how the problem manifests, and what you are executing. This can help to nail down the issue quicker. Thanks, Marcos > > Regards, > Shresth
Looking at the function definition now, I do see that the function returns a struct pointer but for me the compiler still complains about an implicit conversion from int to struct pointer. Is there any particular reason why this might be happening? I couldn't quite figure it out myself as I am very new to working with the kernel. Regards, Shresth
Well, the repo location I use is git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git.
It seem klp_get_state return struct klp_state.
The definition of this function in my repo as follows:
struct klp_state *klp_get_state(struct klp_patch *patch, unsigned long id)
{
struct klp_state *state;
klp_for_each_state(patch, state) {
if (state->id == id)
return state;
}
return NULL;
}
EXPORT_SYMBOL_GPL(klp_get_state);
Are you sure there is really a need for forced conversion?
> 2024年2月19日 22:16,Marcos Paulo de Souza <mpdesouza@suse.com> 写道:
>
> On Sat, 17 Feb 2024 04:21:26 +0530 Shresth Prasad <shresthprasad7@gmail.com> wrote:
>
>> The function `klp_get_state` returns an `int` value, but the variable
>> `loglevel_state` is of type `struct klp_state *` and thus does an
>> implicit cast. Explicitly casting these values fixes:
>>
>> - warning: assignment to \u2018struct klp_state *\u2019 from \u2018int\u2019
>> makes pointer from integer without a cast [-Wint-conversion]
>>
>> on lines 38, 55, 68 and 80 of test_klp_state.c
>
> I was unable to find where you saw the klp_get_state returning int. I tried
> searching at the current master of live-patching repo[1], on linux-next. Can
> you point where do you saw it? For me, klp_get_state return a pointer to klp_state.
>
> Thanks,
> Marcos
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git/tree/kernel/livepatch/state.c
>
>>
>> Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
>> ---
>> .../selftests/livepatch/test_modules/test_klp_state.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/testing/selftests/livepatch/test_modules/test_klp_state.c b/tools/testing/selftests/livepatch/test_modules/test_klp_state.c
>> index 57a4253acb01..ae6b1ca15fc0 100644
>> --- a/tools/testing/selftests/livepatch/test_modules/test_klp_state.c
>> +++ b/tools/testing/selftests/livepatch/test_modules/test_klp_state.c
>> @@ -35,7 +35,7 @@ static int allocate_loglevel_state(void)
>> {
>> struct klp_state *loglevel_state;
>>
>> - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> if (!loglevel_state)
>> return -EINVAL;
>>
>> @@ -52,7 +52,7 @@ static void fix_console_loglevel(void)
>> {
>> struct klp_state *loglevel_state;
>>
>> - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> if (!loglevel_state)
>> return;
>>
>> @@ -65,7 +65,7 @@ static void restore_console_loglevel(void)
>> {
>> struct klp_state *loglevel_state;
>>
>> - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> if (!loglevel_state)
>> return;
>>
>> @@ -77,7 +77,7 @@ static void free_loglevel_state(void)
>> {
>> struct klp_state *loglevel_state;
>>
>> - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> if (!loglevel_state)
>> return;
>>
>> --
>> 2.43.1
>
Lukas Bulwahn <lukas.bulwahn@gmail.com> writes:
> Ricardo suggests that:
>
> - you run 'make htmldocs' before applying the patch and check for the
> existing warnings.
>
> - you run 'make cleandocs' and 'make htmldocs' after applying the
> patch and check for the existing warnings.
>
> Did any warning disappear or appear due to your patch? Were you
> motivated by a specific warning you observed during the build and you
> addressing that?
>
> So, for starters: did you already try 'make htmldocs' with your patch
> applied? What did you observe?
This all seems like a bit much for what is essentially a typo fix. I
would be amazed if it changed the build in any way other than making the
case more consistent; there's no need to do all that stuff.
I've applied it, thanks.
jon
On Sat, 17 Feb 2024 04:21:26 +0530 Shresth Prasad <shresthprasad7@gmail.com> wrote: > The function `klp_get_state` returns an `int` value, but the variable > `loglevel_state` is of type `struct klp_state *` and thus does an > implicit cast. Explicitly casting these values fixes: > > - warning: assignment to \u2018struct klp_state *\u2019 from \u2018int\u2019 > makes pointer from integer without a cast [-Wint-conversion] > > on lines 38, 55, 68 and 80 of test_klp_state.c I was unable to find where you saw the klp_get_state returning int. I tried searching at the current master of live-patching repo[1], on linux-next. Can you point where do you saw it? For me, klp_get_state return a pointer to klp_state. Thanks, Marcos [1]: https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git/tree/kernel/livepatch/state.c > > Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com> > --- > .../selftests/livepatch/test_modules/test_klp_state.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/livepatch/test_modules/test_klp_state.c b/tools/testing/selftests/livepatch/test_modules/test_klp_state.c > index 57a4253acb01..ae6b1ca15fc0 100644 > --- a/tools/testing/selftests/livepatch/test_modules/test_klp_state.c > +++ b/tools/testing/selftests/livepatch/test_modules/test_klp_state.c > @@ -35,7 +35,7 @@ static int allocate_loglevel_state(void) > { > struct klp_state *loglevel_state; > > - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); > + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); > if (!loglevel_state) > return -EINVAL; > > @@ -52,7 +52,7 @@ static void fix_console_loglevel(void) > { > struct klp_state *loglevel_state; > > - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); > + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); > if (!loglevel_state) > return; > > @@ -65,7 +65,7 @@ static void restore_console_loglevel(void) > { > struct klp_state *loglevel_state; > > - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); > + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); > if (!loglevel_state) > return; > > @@ -77,7 +77,7 @@ static void free_loglevel_state(void) > { > struct klp_state *loglevel_state; > > - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); > + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); > if (!loglevel_state) > return; > > -- > 2.43.1
The function `klp_get_state` returns an `int` value, but the variable `loglevel_state` is of type `struct klp_state *` and thus does an implicit cast. Explicitly casting these values fixes: - warning: assignment to ‘struct klp_state *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] on lines 38, 55, 68 and 80 of test_klp_state.c Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com> --- .../selftests/livepatch/test_modules/test_klp_state.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/livepatch/test_modules/test_klp_state.c b/tools/testing/selftests/livepatch/test_modules/test_klp_state.c index 57a4253acb01..ae6b1ca15fc0 100644 --- a/tools/testing/selftests/livepatch/test_modules/test_klp_state.c +++ b/tools/testing/selftests/livepatch/test_modules/test_klp_state.c @@ -35,7 +35,7 @@ static int allocate_loglevel_state(void) { struct klp_state *loglevel_state; - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); if (!loglevel_state) return -EINVAL; @@ -52,7 +52,7 @@ static void fix_console_loglevel(void) { struct klp_state *loglevel_state; - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); if (!loglevel_state) return; @@ -65,7 +65,7 @@ static void restore_console_loglevel(void) { struct klp_state *loglevel_state; - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); if (!loglevel_state) return; @@ -77,7 +77,7 @@ static void free_loglevel_state(void) { struct klp_state *loglevel_state; - loglevel_state = klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); + loglevel_state = (struct klp_state *)klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); if (!loglevel_state) return; -- 2.43.1
On Fri, Feb 16, 2024 at 6:29 AM Ran.Park <ranpark@foxmail.com> wrote: > > Thank you for your reply. I'm sorry that I noticed this problem > while browsing the document. I have not seen any report about this problem > on lore.kernel.org or other places. Should I mention the situation elsewhere > and then resend the patch to mention and fix the problem. > Ran, in the future: please do not remove the context when you reply to somebody's email. In this case, I wanted to help you to understand what Ricardo was asking, but his original response was not in your email. So, I copy and pasted it now---but that is not how it is supposed to be for someone replying to your email. On Wed, Feb 14, 2024 at 2:21 PM Ricardo B. Marliere <ricardo@marliere.net> wrote: > > Hi Ran, > > On 14 Feb 19:40, Ran.Park wrote: > > In the 'fault-injection' subdirectory, the first letter F > > is capitalized, whereas in index.rst f is lowercase, but in > > index.rst all other elements in the same column are capitalized. > > Does this fix any error or build warning? If so, it should be mentioned. > Ricardo suggests that: - you run 'make htmldocs' before applying the patch and check for the existing warnings. - you run 'make cleandocs' and 'make htmldocs' after applying the patch and check for the existing warnings. Did any warning disappear or appear due to your patch? Were you motivated by a specific warning you observed during the build and you addressing that? So, for starters: did you already try 'make htmldocs' with your patch applied? What did you observe? Lukas
Thank you for your reply. I'm sorry that I noticed this problem while browsing the document. I have not seen any report about this problem on lore.kernel.org or other places. Should I mention the situation elsewhere and then resend the patch to mention and fix the problem.
On Wed, Feb 14, 2024 at 10:25 AM Andrew Ballance <andrewjballance@gmail.com> wrote: > > with python 3.12.1 '\#' results in this warning > SyntaxWarning: invalid escape sequence '\#' I changed "3.12.1" to "3.12" when I applied it because this occurs for Python 3.12.0 Thanks. > > Signed-off-by: Andrew Ballance <andrewjballance@gmail.com> > --- > scripts/clang-tools/gen_compile_commands.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py > index 5dea4479240b..e4fb686dfaa9 100755 > --- a/scripts/clang-tools/gen_compile_commands.py > +++ b/scripts/clang-tools/gen_compile_commands.py > @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path): > # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the > # kernel version). The compile_commands.json file is not interepreted > # by Make, so this code replaces the escaped version with '#'. > - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#') > + prefix = command_prefix.replace(r'\#', '#').replace('$(pound)', '#') > > # Return the canonical path, eliminating any symbolic links encountered in the path. > abs_path = os.path.realpath(os.path.join(root_directory, file_path)) > -- > 2.43.0 > -- Best Regards Masahiro Yamada
Hi, On Tue, Feb 13, 2024 at 07:23:05PM -0600, Andrew Ballance wrote: > with python 3.12.1 '\#' results in this warning > SyntaxWarning: invalid escape sequence '\#' > > Signed-off-by: Andrew Ballance <andrewjballance@gmail.com> You probably don't need to send a patch series (with a cover letter) if you're only sending a single patch to the list. Really, though, who cares! Reviewed-by: Justin Stitt <justinstitt@google.com> > --- > scripts/clang-tools/gen_compile_commands.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py > index 5dea4479240b..e4fb686dfaa9 100755 > --- a/scripts/clang-tools/gen_compile_commands.py > +++ b/scripts/clang-tools/gen_compile_commands.py > @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path): > # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the > # kernel version). The compile_commands.json file is not interepreted > # by Make, so this code replaces the escaped version with '#'. > - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#') > + prefix = command_prefix.replace(r'\#', '#').replace('$(pound)', '#') > > # Return the canonical path, eliminating any symbolic links encountered in the path. > abs_path = os.path.realpath(os.path.join(root_directory, file_path)) > -- > 2.43.0 > Thanks Justin
Hi Ran, On 14 Feb 19:40, Ran.Park wrote: > In the 'fault-injection' subdirectory, the first letter F > is capitalized, whereas in index.rst f is lowercase, but in > index.rst all other elements in the same column are capitalized. Does this fix any error or build warning? If so, it should be mentioned. > > Signed-off-by: Ran.Park <ranpark@foxmail.com> > --- > Documentation/fault-injection/index.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > ──────────────────────────────────────────────────────────────────────────────── > modified: Documentation/fault-injection/index.rst > ──────────────────────────────────────────────────────────────────────────────── > @ Documentation/fault-injection/index.rst:4 @ > .. SPDX-License-Identifier: GPL-2.0 > > =============== > fault-injection > Fault-injection > =============== > > .. toctree:: > - > 2.34.1 > >
In the 'fault-injection' subdirectory, the first letter F is capitalized, whereas in index.rst f is lowercase, but in index.rst all other elements in the same column are capitalized. Signed-off-by: Ran.Park <ranpark@foxmail.com> --- Documentation/fault-injection/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/fault-injection/index.rst b/Documentation/fault-injection/index.rst index 8408a8a91b34..a6ea1d190222 100644 --- a/Documentation/fault-injection/index.rst +++ b/Documentation/fault-injection/index.rst @@ -1,7 +1,7 @@ .. SPDX-License-Identifier: GPL-2.0 =============== -fault-injection +Fault-injection =============== .. toctree:: -- 2.34.1