linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Anders Roxell <anders.roxell@linaro.org>,
	ysato@users.sourceforge.jp, dalias@libc.org
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: kernel: traps: remove unused variable
Date: Mon, 18 Jan 2021 21:05:27 +0100	[thread overview]
Message-ID: <0c036e4f-837c-c854-ef28-24cb55153a55@physik.fu-berlin.de> (raw)
In-Reply-To: <20201210124422.3858524-1-anders.roxell@linaro.org>

On 12/10/20 1:44 PM, Anders Roxell wrote:
> When building defconfig the following warning shows up:
> 
> arch/sh/kernel/traps.c: In function 'nmi_trap_handler':
> arch/sh/kernel/traps.c:183:15: warning: unused variable 'cpu' [-Wunused-variable]
>   unsigned int cpu = smp_processor_id();
>                ^~~
> 
> Remove an unused variable 'cpu'.
> 
> Fixes: fe3f1d5d7cd3 ("sh: Get rid of nmi_count()")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>  arch/sh/kernel/traps.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/sh/kernel/traps.c b/arch/sh/kernel/traps.c
> index f5beecdac693..e76b22157099 100644
> --- a/arch/sh/kernel/traps.c
> +++ b/arch/sh/kernel/traps.c
> @@ -180,7 +180,6 @@ static inline void arch_ftrace_nmi_exit(void) { }
>  
>  BUILD_TRAP_HANDLER(nmi)
>  {
> -	unsigned int cpu = smp_processor_id();
>  	TRAP_HANDLER_DECL;
>  
>  	arch_ftrace_nmi_enter();

Good catch. Now I have one warning less when building the kernel for my SH-7785LCR ;-).

Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


      parent reply	other threads:[~2021-01-18 20:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 12:44 [PATCH] sh: kernel: traps: remove unused variable Anders Roxell
2020-12-29 13:07 ` Geert Uytterhoeven
2021-01-18 20:05 ` John Paul Adrian Glaubitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c036e4f-837c-c854-ef28-24cb55153a55@physik.fu-berlin.de \
    --to=glaubitz@physik.fu-berlin.de \
    --cc=anders.roxell@linaro.org \
    --cc=dalias@libc.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).