Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: "Adrian Bunk" <bunk@kernel.org>
Cc: "Kyle Moffett" <mrmacman_g4@mac.com>,
	"Casey Schaufler" <casey@schaufler-ca.com>,
	akpm@osdl.org, torvalds@osdl.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser
Date: Tue, 6 Nov 2007 16:30:35 +0200	[thread overview]
Message-ID: <1865922a0711060630i4d67f8a5ka2fd30494a525ac9@mail.gmail.com> (raw)
In-Reply-To: <20071106141037.GL26163@stusta.de>

On 11/6/07, Adrian Bunk <bunk@kernel.org> wrote:
> On Tue, Nov 06, 2007 at 04:05:13PM +0200, Ahmed S. Darwish wrote:
> >
> > Great, To summarize the discussion. Will there be a problem in
> > accepting ASCII and the UTF-8 ASCII _subset_ _only_ and  return
> > -EINVAL for all other cases/ecnodings ?.
>
> The UTF-8 ASCII subset is the complete ASCII.
>
> > i.e. The fragment I sent in a previous message:
> >
> > /* Filter UTF-8 non-ascii compatible bytes (> 0x7F) */
> > if (!isascii(c)) return -EINVAL;
> > /* Filter unwanted ascii chars */
> > if (!isspace(c) && !isgraph(c)) return -EINVAL;
> >...
>
> As I already said, this should work fine.
>

I thought you were objecting not handling the remaining non-ASCII
UTF-8 bytes. Everything is clear now. A Big thank you to everybody in
this thread for your effort on this :).

Regards,

-- 
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com