From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts
Date: Fri, 5 Jan 2007 12:32:47 +0200 [thread overview]
Message-ID: <20070105103247.GC382@Ahmed> (raw)
In-Reply-To: <200701051126.13682.eike-kernel@sf-tec.de>
On Fri, Jan 05, 2007 at 11:26:07AM +0100, Rolf Eike Beer wrote:
> One big patch for the whole kernel will not work anyway. You have to split it
> up to allow subsystems to integrate them in their own trees. With one big
> patch you would get collisions all over the tree causing the complete patch
> to get dropped. Also CC subsystem maintainers on their parts. And please send
> the patches as replies to the first one as it cleans up readability of lkml a
> lot :)
Oops, Just read this warning after sending the (big) patch. Sorry It's my first
patch :). I'll split it and do as written. Thanks alot :).
> > I think this will be better done in another patch to let every patch do one
> > single thing. right ?
>
> Yes. But I would suggest starting with the kmalloc()->kzalloc() things. When
> you do this conversions just remove the casts of the lines you're touching.
> This will reduce the size of the complete thing avoiding two rather trivial
> patches touching the same line twice.
>
> Eike
OK. In progress
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
next prev parent reply other threads:[~2007-01-05 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 6:36 [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts Ahmed S. Darwish
2007-01-05 6:56 ` Robert P. J. Day
2007-01-05 7:14 ` Ahmed S. Darwish
2007-01-05 8:10 ` Rolf Eike Beer
2007-01-05 10:06 ` Ahmed S. Darwish
2007-01-05 10:18 ` Robert P. J. Day
2007-01-05 10:39 ` Pekka Enberg
2007-01-05 10:51 ` Alan
2007-01-05 10:41 ` Robert P. J. Day
2007-01-05 11:03 ` Ahmed S. Darwish
2007-01-06 2:36 ` Ahmed S. Darwish
2007-01-06 7:35 ` Robert P. J. Day
2007-01-05 10:26 ` Rolf Eike Beer
2007-01-05 10:32 ` Ahmed S. Darwish [this message]
2007-01-05 11:54 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070105103247.GC382@Ahmed \
--to=darwish.07@gmail.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).