Re: [PATCH 2.6.20] s390-drivers: Use ARRAY_SIZE macro when appropriate

From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org,
	linux-390@vm.marist.edu
Subject: Re: [PATCH 2.6.20] s390-drivers: Use ARRAY_SIZE macro when appropriate
Date: Wed, 7 Feb 2007 07:32:16 +0100	[thread overview]
Message-ID: <20070207073216.246a079d@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20070206160744.GK8991@Ahmed>

On Tue, 6 Feb 2007 18:07:44 +0200,
"Ahmed S. Darwish" <darwish.07@gmail.com> wrote:

> Hi all,
> 
> A patch to use ARRAY_SIZE macro already defined in kernel.h
> 
> Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
> ---
> Not compile tested due to (ofcourse ;)) missing hardware.
> 
> diff --git a/drivers/s390/cio/device_id.c b/drivers/s390/cio/device_id.c
> index f172759..997f468 100644
> --- a/drivers/s390/cio/device_id.c
> +++ b/drivers/s390/cio/device_id.c
> @@ -11,6 +11,7 @@
> 
>  #include <linux/module.h>
>  #include <linux/init.h>
> +#include <linux/kernel.h>
> 
>  #include <asm/ccwdev.h>
>  #include <asm/delay.h>
> @@ -138,7 +139,7 @@ VM_virtual_device_info (__u16 devno, struct senseid *ps)
>  		ps->cu_model = 0x60;
>  		return;
>  	}
> -	for (i = 0; i < sizeof(vm_devices) / sizeof(vm_devices[0]); i++)
> +	for (i = 0; i < ARRAY_SIZE(vm_devices); i++)
>  		if (diag_data.vrdcvcla == vm_devices[i].vrdcvcla &&
>  		    diag_data.vrdcvtyp == vm_devices[i].vrdcvtyp) {
>  			ps->cu_type = vm_devices[i].cu_type;
> 
> 

Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>