From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Cc: trivial@kernel.org
Subject: [PATCH 2.6.21-rc4] kernel/exit: Fix a comment and code contradiction
Date: Sat, 17 Mar 2007 08:21:32 +0200 [thread overview]
Message-ID: <20070317062132.GA11326@Ahmed> (raw)
Hi list,
Comment in release_task() claims that group leader's parent process
is signalled only if it desires so, which is not true.
Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
---
To save your time, here's the contradictory code which don't appear in
the patch (appears after its last line):
leader = p->group_leader;
if (leader != p && thread_group_empty(leader) && leader->exit_state == EXIT_ZOMBIE) {
BUG_ON(leader->exit_signal == -1);
do_notify_parent(leader, leader->exit_signal);
diff --git a/kernel/exit.c b/kernel/exit.c
index f132349..4a0a35f 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -152,7 +152,7 @@ repeat:
/*
* If we are the last non-leader member of the thread
* group, and the leader is zombie, then notify the
- * group leader's parent process. (if it wants notification.)
+ * group leader's parent process.
*/
zap_leader = 0;
leader = p->group_leader;
--
Ahmed S. Darwish
http://darwish.07.googlepages.com
next reply other threads:[~2007-03-17 6:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-17 6:21 Ahmed S. Darwish [this message]
2007-03-17 9:45 ` [PATCH 2.6.21-rc4] kernel/exit: Fix a comment and code contradiction Johannes Weiner
2007-03-17 15:00 ` Ahmed S. Darwish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070317062132.GA11326@Ahmed \
--to=darwish.07@gmail.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).