From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: Brian Braunstein <brian@bristyle.com>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
rajesh_mish@yahoo.com
Subject: Re: PATCH: tun/tap driver hw address handling
Date: Sat, 24 Mar 2007 19:04:32 +0200 [thread overview]
Message-ID: <20070324170432.GA6016@Ahmed> (raw)
In-Reply-To: <4604E7D2.3020704@bristyle.com>
Hi Brian,
On Sat, Mar 24, 2007 at 01:56:50AM -0700, Brian Braunstein wrote:
>
> Linus,
>
> According to Documentation/SubmittingPatches "bug fixes" or "obvious"
> changes
> should CCed to you, so this is why I have done this.
>
IMHO these days patches got reviewed on LKML, then tested enough on the
unstable -mm tree then it got added to mainline kernel. Subsystem maintaners
can also add patches directly to mainline if they're trivial enough.
> Note: This entire email can be found at
> http://bristyle.com/share/patch-tuntap-hw_addr_handling.txt
>
I think No need for such two lines. everyone uses his favourite LKML archive.
> Summary:
> Fix tun/tap driver's handling of hw addresses. Specifically, ensure
> that
> when the tun.dev_addr field is set, the net_device.dev_addr field gets
> set to the same value.
>
> Background:
> The device hw address is stored in 2 places, in the tun.dev_addr field,
> and of course the net_device struct's dev_addr field. It really
> seems to
> me that the tun.dev_addr field is redundant, and that anywhere it is
> used
Editor/mailer wrapping your lines badly ?
>
> --- linux-2.6.20.4-ORIG/drivers/net/tun.c 2007-03-23
> 12:52:51.000000000 -0700
> +++ linux-2.6.20.4/drivers/net/tun.c 2007-03-24 01:36:59.000000000 -0700
> @@ -18,6 +18,11 @@
Please reread SubmittingPatches to know the canonical patch format (missing
Signed-off-by and others).
> /*
> * Changes:
> *
> + * Brian Braunstein <linuxkernel@bristyle.com> 2007/03/23
> + * Fixed hw address handling. Now net_device.dev_addr is kept
> consistent
[Remaing patch]
Patch can't be applied or even read cause your mailer has mistakenly wrapped
its lines.
Regards,
--
Ahmed S. Darwish
http://darwish.07.googlepages.com
prev parent reply other threads:[~2007-03-24 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <45E6BF26.7080607@bristyle.com>
[not found] ` <45E73715.9030909@qualcomm.com>
2007-03-24 8:56 ` PATCH: tun/tap driver hw address handling Brian Braunstein
2007-03-24 17:04 ` Ahmed S. Darwish [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070324170432.GA6016@Ahmed \
--to=darwish.07@gmail.com \
--cc=brian@bristyle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=rajesh_mish@yahoo.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).