From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Rob Landley <rob@landley.net>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
rdunlap@xenotime.net
Subject: Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.
Date: Tue, 9 Oct 2007 19:19:49 +0200 [thread overview]
Message-ID: <20071009171949.GA11579@Ahmed> (raw)
In-Reply-To: <20071009085500.e7be49a0.randy.dunlap@oracle.com>
On Tue, Oct 09, 2007 at 08:55:00AM -0700, Randy Dunlap wrote:
> On Tue, 9 Oct 2007 15:03:15 +0200 Ahmed S. Darwish wrote:
>
> > Hi Rob,
> >
> > On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley wrote:
> > [...]
> > > FILE * infile;
> > > +
> > > + srctree = getenv("SRCTREE");
> > > + if (!srctree) srctree = getcwd(NULL,0);
> > > if (argc != 3) {
> > > usage();
> > > exit(1);
> >
> > $ man getcwd
> >
> > char *getcwd(char *buf, size_t size);
> >
> > As an extension to the POSIX.1 standard, Linux (libc4, libc5, glibc) getcwd()
> > allocates the buffer dynamically using malloc() if buf is NULL on call.
> >
> > Shouldn't "srctree" be free()ed in case getenv("SRCTREE") failed ?
>
> What is there to free() at that point? If getenv() fails (i.e.,
> the env. variable is not found), it returns NULL.
> or do I need another cup of coffee?
>
I meant if getenv() failed, "srctree = getcwd(NULL, 0)" will let
"srctree" point to a _ malloc()ed _ buffer representing PWD.
As said in the manpage, this buffer needs to be free()ed after usage.
Right or I'm the one who needs that cup of coffee :) ?
Regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
next prev parent reply other threads:[~2007-10-09 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 6:25 [PATCH] Stop docproc segfaulting when SRCTREE isn't set Rob Landley
2007-10-09 13:03 ` Ahmed S. Darwish
2007-10-09 15:55 ` Randy Dunlap
2007-10-09 17:19 ` Ahmed S. Darwish [this message]
2007-10-09 17:24 ` Randy Dunlap
2007-10-09 17:51 ` Ahmed S. Darwish
2007-10-09 22:19 ` Rob Landley
2007-10-09 15:56 ` Randy Dunlap
2007-10-18 11:53 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009171949.GA11579@Ahmed \
--to=darwish.07@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdunlap@xenotime.net \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).