From: Jean Delvare <khali@linux-fr.org>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc: bryan.wu@analog.com, "Andrey Panin" <pazke@donpac.ru>,
"Roel Kluin" <12o3l@tiscali.nl>,
"Ahmed S. Darwish" <darwish.07@gmail.com>,
linux-input@atrey.karlin.mff.cuni.cz,
linux-joystick@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver
Date: Mon, 15 Oct 2007 21:35:41 +0200 [thread overview]
Message-ID: <20071015213541.25bac062@hyperion.delvare> (raw)
In-Reply-To: <d120d5000710150848t1993b0aavbbc0cd7971e3ef3e@mail.gmail.com>
On Mon, 15 Oct 2007 11:48:17 -0400, Dmitry Torokhov wrote:
> On 10/15/07, Bryan Wu <bryan.wu@analog.com> wrote:
> > +static int __init ad7142_init(void)
> > +{
> > + return i2c_add_driver(&ad7142_driver);
> > +}
> > +
> > +static void __exit ad7142_exit(void)
> > +{
> > + i2c_del_driver(&ad7142_driver);
> > + input_unregister_device(ad7142_dev);
>
> input_unregister_device() should be in ad7142_detach_client? I am not
> sure i2c - there seems to be 2 interface styles and you probably need
> to use the new one. I am CC-inj Jean on this.
The new style is preferred, yes.
--
Jean Delvare
prev parent reply other threads:[~2007-10-15 19:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 14:47 [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver Bryan Wu
2007-10-15 15:48 ` Dmitry Torokhov
2007-10-15 17:24 ` Bryan Wu
2007-10-15 17:40 ` Dmitry Torokhov
2007-10-16 5:51 ` Bryan Wu
2007-10-16 16:53 ` Dmitry Torokhov
2007-10-15 18:27 ` Ahmed S. Darwish
2007-10-16 6:08 ` Bryan Wu
2007-10-16 16:40 ` Ahmed S. Darwish
2007-10-15 19:35 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015213541.25bac062@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=darwish.07@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-joystick@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@donpac.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).