From: Sam Ravnborg <sam@ravnborg.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, pavel@suse.cz,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v2] Re: 2.6.25-rc2-mm1 (wakeup)
Date: Sun, 17 Feb 2008 22:07:10 +0100 [thread overview]
Message-ID: <20080217210710.GA15284@uranus.ravnborg.org> (raw)
In-Reply-To: <200802172140.16055.rjw@sisk.pl>
On Sun, Feb 17, 2008 at 09:40:15PM +0100, Rafael J. Wysocki wrote:
> On Sunday, 17 of February 2008, Randy Dunlap wrote:
> > H. Peter Anvin wrote:
> > > Randy Dunlap wrote:
> > >> On Sat, 16 Feb 2008 19:58:06 -0800 H. Peter Anvin wrote:
> > >>
> > >>> Randy Dunlap wrote:
> > >>>> Yes, adding -m32 to the X86_32 config ccflags (as is done for the
> > >>>> X86_64 case) makes it build for me. (like patch below)
> > >>>>
> > >>> It's wrong, though, because you can't assume a 32-bit compiler knows
> > >>> about -m32.
> > >>>
> > >>> You need $(call cc-option,-m32).
> > >>
> > >> -cflags-$(CONFIG_X86_32) :=
> > >> +cflags-$(CONFIG_X86_32) := $(call cc-option, -m32)
> > >> cflags-$(CONFIG_X86_64) := -m32
> > >
> > > I think this works for both; that's what we do for arch/x86/boot.
> >
> > OK, that makes sense. I think I'll let Rafael complete it.
>
> OK, so that would be the appended patch.
>
> Still, since there are several fixes against the "move the wakeup code to C"
> patch, I'll probably fold them all into a new version of this patch and resend
> it.
>
> Thanks,
> Rafael
>
> ---
> arch/x86/kernel/acpi/realmode/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: linux-2.6/arch/x86/kernel/acpi/realmode/Makefile
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/acpi/realmode/Makefile
> +++ linux-2.6/arch/x86/kernel/acpi/realmode/Makefile
> @@ -27,8 +27,6 @@ bootsrc := $(src)/../../../boot
> # How to compile the 16-bit code. Note we always compile for -march=i386,
> # that way we can complain to the user if the CPU is insufficient.
> # Compile with _SETUP since this is similar to the boot-time setup code.
> -cflags-$(CONFIG_X86_32) :=
> -cflags-$(CONFIG_X86_64) := -m32
> KBUILD_CFLAGS := $(LINUXINCLUDE) -g -Os -D_SETUP -D_WAKEUP -D__KERNEL__ \
> -I$(srctree)/$(bootsrc) \
> $(cflags-y) \
> @@ -41,6 +39,7 @@ KBUILD_CFLAGS := $(LINUXINCLUDE) -g -Os
> $(call cc-option, -fno-unit-at-a-time)) \
> $(call cc-option, -fno-stack-protector) \
> $(call cc-option, -mpreferred-stack-boundary=2)
> +KBUILD_CFLAGS += $(call cc-option, -m32)
For a 64 bit build we should error out if the compiler
fials to support -m32 (how unlikely that may be).
So I would prefer it unconditional for 64 bit.
But nit picking - I know.
Sam
next prev parent reply other threads:[~2008-02-17 21:07 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 8:25 2.6.25-rc2-mm1 Andrew Morton
2008-02-16 10:59 ` 2.6.25-rc2-mm1: build failure (x86) Marcin Slusarz
2008-02-16 11:09 ` Andrew Morton
2008-02-16 11:37 ` Marcin Slusarz
2008-02-17 0:22 ` Rafael J. Wysocki
2008-02-17 9:54 ` Marcin Slusarz
2008-02-17 1:37 ` Rafael J. Wysocki
2008-02-17 9:56 ` Marcin Slusarz
2008-02-19 18:51 ` Russell Leidich
2008-02-16 16:15 ` [BUG] 2.6.25-rc2-mm1 - kernel oops while bootup on s390x Kamalesh Babulal
2008-02-16 19:45 ` Andrew Morton
2008-02-16 19:49 ` Thomas Gleixner
2008-02-16 19:50 ` Thomas Gleixner
2008-02-17 3:40 ` Kamalesh Babulal
2008-02-17 9:06 ` Heiko Carstens
2008-02-18 14:08 ` Kamalesh Babulal
2008-02-16 17:21 ` 2.6.25-rc2-mm1 Randy Dunlap
2008-02-16 17:31 ` [PATCH]2.6.25-rc2-mm1 - Build Failure at security/keys/compat.c on powerpc Kamalesh Babulal
2008-02-16 17:48 ` 2.6.25-rc2-mm1 (wakeup) Randy Dunlap
2008-02-17 1:18 ` Rafael J. Wysocki
2008-02-17 1:22 ` H. Peter Anvin
2008-02-17 2:19 ` Randy Dunlap
2008-02-17 3:58 ` H. Peter Anvin
2008-02-17 4:38 ` [PATCH v2] " Randy Dunlap
2008-02-17 4:35 ` H. Peter Anvin
2008-02-17 4:47 ` Randy Dunlap
2008-02-17 20:40 ` Rafael J. Wysocki
2008-02-17 21:07 ` Sam Ravnborg [this message]
2008-02-17 21:21 ` H. Peter Anvin
2008-02-17 21:28 ` Sam Ravnborg
2008-02-17 21:31 ` H. Peter Anvin
2008-02-17 21:46 ` Sam Ravnborg
2008-02-17 21:20 ` H. Peter Anvin
2008-02-16 19:47 ` [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os Kamalesh Babulal
2008-02-16 20:01 ` Laura Garcia
2008-02-21 7:08 ` Len Brown
2008-02-21 18:54 ` Nish Aravamudan
2008-02-21 22:22 ` Sam Ravnborg
2008-02-22 1:38 ` Nish Aravamudan
2008-02-22 18:08 ` Sam Ravnborg
2008-02-22 18:12 ` Nish Aravamudan
2008-02-22 18:13 ` Randy Dunlap
2008-02-22 18:21 ` Nish Aravamudan
2008-02-22 18:27 ` Sam Ravnborg
2008-02-22 18:29 ` Randy Dunlap
2008-02-22 18:56 ` Sam Ravnborg
2008-02-22 19:25 ` [PATCH] " Randy Dunlap
2008-02-23 5:41 ` Len Brown
2008-02-23 15:33 ` Kamalesh Babulal
2008-02-16 21:27 ` 2.6.25-rc2-mm1: WARNING at arch/x86/mm/ioremap.c:129 Laurent Riffard
2008-02-16 21:52 ` Arjan van de Ven
2008-02-18 4:58 ` Brown, Len
2008-02-18 5:18 ` Arjan van de Ven
2008-02-18 19:35 ` Arjan van de Ven
2008-02-18 21:05 ` Laurent Riffard
2008-02-18 21:12 ` Arjan van de Ven
2008-02-24 0:44 ` Gabriel C
2008-02-24 2:50 ` Arjan van de Ven
2008-02-25 16:31 ` Gabriel C
2008-02-25 22:44 ` Arjan van de Ven
2008-02-25 23:33 ` Gabriel C
2008-02-25 23:59 ` Gabriel C
2008-03-01 15:40 ` Mirco Tischler
2008-03-02 15:53 ` Fabio Checconi
2008-03-02 16:58 ` Arjan van de Ven
2008-03-03 8:46 ` Ingo Molnar
2008-03-03 8:47 ` Ingo Molnar
2008-03-03 10:21 ` Fabio Checconi
2008-03-02 20:40 ` Laurent Riffard
2008-03-02 23:35 ` Mirco Tischler
2008-02-17 4:10 ` [BUG] 2.6.25-rc2-mm1 - Kernel panic while bootup caused by signal_group_exit() Kamalesh Babulal
2008-02-17 4:50 ` Andrew Morton
2008-02-17 5:02 ` Kamalesh Babulal
2008-02-17 12:41 ` Oleg Nesterov
2008-02-20 19:34 ` Rik van Riel
2008-02-20 20:04 ` Oleg Nesterov
2008-02-20 22:53 ` Rik van Riel
2008-02-28 13:13 ` Cedric Le Goater
2008-02-20 20:07 ` Alan Cox
2008-02-17 5:08 ` 2.6.25-rc2-mm1 Kamalesh Babulal
2008-02-17 5:24 ` 2.6.25-rc2-mm1 Andrew Morton
2008-02-17 7:36 ` 2.6.25-rc2-mm1 Kamalesh Babulal
2008-02-17 5:16 ` 2.6.25-rc2-mm1 (x64 thermal build failure) Randy Dunlap
2008-02-17 5:44 ` Andrew Morton
2008-02-18 10:15 ` Thomas Petazzoni
2008-02-18 12:13 ` Andrew Morton
2008-02-19 15:55 ` Thomas Petazzoni
2008-02-19 17:41 ` Randy Dunlap
2008-02-19 22:00 ` Thomas Petazzoni
2008-02-19 22:05 ` Randy Dunlap
2008-02-19 23:21 ` Andrew Morton
2008-02-20 7:21 ` Thomas Petazzoni
2008-02-20 9:55 ` Andrew Morton
2008-02-17 5:32 ` 2.6.25-rc2-mm1 (build failure) Randy Dunlap
2008-02-17 5:46 ` Andrew Morton
2008-02-17 19:52 ` Pavel Machek
2008-02-17 20:12 ` Rafael J. Wysocki
2008-02-17 11:23 ` Rafael J. Wysocki
2008-02-17 17:54 ` Randy Dunlap
2008-02-17 6:25 ` 2.6.25-rc2-mm1 Joel Becker
2008-02-17 6:32 ` 2.6.25-rc2-mm1 Joel Becker
2008-02-17 6:51 ` 2.6.25-rc2-mm1 Andrew Morton
2008-02-17 10:50 ` 2.6.25-rc2-mm1: new create_proc_entry() users Alexey Dobriyan
2008-02-18 13:01 ` Andrew Morton
2008-02-18 16:13 ` Daniel Walker
2008-02-19 22:25 ` Miller, Mike (OS Dev)
2008-02-19 23:59 ` Andrew Morton
2008-02-18 0:14 ` 2.6.25-rc2-mm1 (cifs build errs) Randy Dunlap
2008-02-18 4:10 ` Steve French
2008-02-18 0:16 ` 2.6.25-rc2-mm1 Randy Dunlap
2008-02-18 9:34 ` 2.6.25-rc2-mm1 Andrew Morton
2008-02-18 5:17 ` 2.6.25-rc2-mm1 (x86 MCE build error) Randy Dunlap
2008-02-18 6:03 ` Yinghai Lu
2008-02-18 13:31 ` Adrian Bunk
2008-02-18 17:13 ` 2.6.25-rc2-mm1 (cciss " Randy Dunlap
2008-02-19 0:08 ` 2.6.25-rc2-mm1 Kevin Winchester
2008-02-19 0:15 ` 2.6.25-rc2-mm1 Andrew Morton
2008-02-19 0:22 ` 2.6.25-rc2-mm1 Steven Rostedt
2008-02-19 1:15 ` 2.6.25-rc2-mm1 Kevin Winchester
2008-02-20 21:14 ` 2.6.25-rc2-mm1 - several bugs and a crash Tilman Schmidt
2008-02-20 21:50 ` Patrick McHardy
2008-02-21 11:28 ` Patrick McHardy
2008-02-21 16:32 ` Stephen Hemminger
2008-02-21 16:34 ` Patrick McHardy
2008-02-22 0:40 ` Tilman Schmidt
2008-02-22 0:52 ` Tilman Schmidt
2008-02-22 17:09 ` Paul E. McKenney
2008-02-25 8:54 ` Tilman Schmidt
2008-02-27 16:37 ` nf_conntrack fix smp_processor_id() in preemptible code (was: 2.6.25-rc2-mm1 - several bugs and a crash) Tilman Schmidt
2008-02-27 16:47 ` nf_conntrack fix smp_processor_id() in preemptible code Patrick McHardy
2008-02-21 12:38 ` 2.6.25-rc2-mm1 - several bugs and a crash Andrew Morton
2008-02-21 16:46 ` Christoph Hellwig
2008-02-22 0:10 ` Tilman Schmidt
2008-02-21 19:36 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217210710.GA15284@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=randy.dunlap@oracle.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).