From: Jakub Jelinek <jakub@redhat.com>
To: Ollie Wild <aaw@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Kerrisk <michael.kerrisk@googlemail.com>,
Andrew Morton <akpm@linux-foundation.org>,
michael.kerrisk@gmail.com, carlos@codesourcery.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
drepper@redhat.com, mtk.manpages@gmail.com
Subject: Re: [RFC/PATCH] RLIMIT_ARG_MAX
Date: Fri, 29 Feb 2008 14:09:52 -0500 [thread overview]
Message-ID: <20080229190952.GM24887@devserv.devel.redhat.com> (raw)
In-Reply-To: <65dd6fd50802291101j3786ee60iec0f3a24f5df9945@mail.gmail.com>
On Fri, Feb 29, 2008 at 11:01:38AM -0800, Ollie Wild wrote:
> On Fri, Feb 29, 2008 at 10:12 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > So it's not *going* to be exact even with RLIMIT_ARG_MAX, because it's
> > going to have all those other issues to contend with - on a 64-bit
> > architecture, the argument _pointers_ are often within an order of
> > magnitude of the argument strings themselves, and I don't think your patch
> > counted them as part of the argument/environemnt size (I was too lazy to
> > check the sources, but I'm pretty sure argv/env_start/end is just the
> > string space, not the pointers).
>
> This is precisely why I picked 25% as the maximum argument size ratio.
> In practice, that 25% can easily mean 50% or more. If people want to
> increase this, it can probably be tweaked somewhat, but switching it
> to, say, 50% probably isn't a good idea.
I think 50% would be still fine. And, ideally make that
MAX (RLIMIT_STACK / 2, 128KB) to avoid regressions for programs which assume
they can pass ARG_MAX args+env, even if they have say 192KB stack limit.
Jakub
next prev parent reply other threads:[~2008-02-29 19:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 13:37 [RFC/PATCH] RLIMIT_ARG_MAX Peter Zijlstra
2008-02-29 16:05 ` Linus Torvalds
2008-02-29 16:58 ` Michael Kerrisk
2008-02-29 17:12 ` Linus Torvalds
2008-02-29 17:18 ` Peter Zijlstra
2008-02-29 17:29 ` Linus Torvalds
2008-02-29 17:42 ` Peter Zijlstra
2008-02-29 18:12 ` Linus Torvalds
2008-02-29 19:01 ` Ollie Wild
2008-02-29 19:09 ` Jakub Jelinek [this message]
2008-02-29 19:50 ` Linus Torvalds
2008-02-29 20:03 ` Ollie Wild
2008-03-04 20:07 ` Pavel Machek
2008-02-29 17:14 ` Peter Zijlstra
2008-02-29 17:35 ` Linus Torvalds
2008-02-29 17:55 ` Peter Zijlstra
2008-02-29 18:14 ` Linus Torvalds
2008-02-29 18:18 ` Michael Kerrisk
2008-02-29 18:39 ` Linus Torvalds
2008-02-29 19:49 ` Michael Kerrisk
2008-02-29 20:07 ` Linus Torvalds
2008-02-29 20:43 ` Michael Kerrisk
2008-02-29 21:34 ` Linus Torvalds
2008-02-29 21:57 ` Linus Torvalds
2008-03-01 14:21 ` Carlos O'Donell
2008-03-01 8:42 ` Geoff Clare
2008-02-29 18:40 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080229190952.GM24887@devserv.devel.redhat.com \
--to=jakub@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=aaw@google.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=carlos@codesourcery.com \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.kerrisk@gmail.com \
--cc=michael.kerrisk@googlemail.com \
--cc=mtk.manpages@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).