From: Adrian Bunk <bunk@kernel.org>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: sfrench@samba.org, linux-cifs-client@lists.samba.org,
samba-technical@lists.samba.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][fs/cifs/cifsfs.c] Make use of cifs_xquota_get
Date: Sat, 1 Mar 2008 11:37:12 +0200 [thread overview]
Message-ID: <20080301093712.GB25835@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <47B08A0B.4020604@tiscali.nl>
On Mon, Feb 11, 2008 at 06:46:51PM +0100, Roel Kluin wrote:
> Functions cifs_xquota_set and cifs_xquota_get at respectively
> fs/cifs/cifsfs.c:367 and 392 are entirely similar - except for
> whitespace
>
> struct quotactl_ops contains function pointers .set_xquota and
> .get_xquota that both get the address of cifs_xquota_set.
> cifs_xquota_get isn't called anywhere else in the kernel.
>
> The patch below makes use of the function cifs_xquota_get, As
> an alternative the entire function cifs_xquota_get could be
> removed.
> ---
> Make use of cifs_xquota_get
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> index fcc4342..339b829 100644
> --- a/fs/cifs/cifsfs.c
> +++ b/fs/cifs/cifsfs.c
> @@ -461,7 +461,7 @@ int cifs_xstate_get(struct super_block *sb, struct fs_quota_stat *qstats)
>
> static struct quotactl_ops cifs_quotactl_ops = {
> .set_xquota = cifs_xquota_set,
> - .get_xquota = cifs_xquota_set,
> + .get_xquota = cifs_xquota_get,
> .set_xstate = cifs_xstate_set,
> .get_xstate = cifs_xstate_get,
> };
Steve, this obvious bugfix seems to be stuck in cifs-2.6.git.
Can you forward this fix (and other fixes if you have any) to Linus soon?
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-03-01 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 17:46 [PATCH][fs/cifs/cifsfs.c] Make use of cifs_xquota_get Roel Kluin
2008-03-01 9:37 ` Adrian Bunk [this message]
2008-03-01 16:06 ` Steve French
2008-03-01 16:15 ` Adrian Bunk
2008-03-01 18:29 ` Steve French
2008-03-01 18:40 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080301093712.GB25835@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=12o3l@tiscali.nl \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).