From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: torvalds@linux-foundation.org, hans.rosenfeld@amd.com,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: bisected boot regression post 2.6.25-rc3.. please revert
Date: Mon, 3 Mar 2008 18:40:09 +0100 [thread overview]
Message-ID: <20080303174009.GA19131@elte.hu> (raw)
In-Reply-To: <47CC2A3D.1000307@linux.intel.com>
* Arjan van de Ven <arjan@linux.intel.com> wrote:
> ------------[ cut here ]------------
> WARNING: at arch/x86/mm/pgtable_32.c:387 pmd_bad+0x44/0x53()
> Modules linked in:
> Pid: 1, comm: swapper Not tainted 2.6.25-rc3 #14
> [<c0424ba5>] warn_on_slowpath+0x41/0x67
> [<c0408c5c>] ? native_sched_clock+0x94/0xa6
> [<c043f432>] ? lock_release_holdtime+0x1a/0x115
> [<c04702d4>] ? handle_mm_fault+0x297/0x7e2
> [<c063eee6>] ? _spin_unlock+0x1d/0x20
> [<c04707f0>] ? handle_mm_fault+0x7b3/0x7e2
> [<c04851c1>] ? do_sync_read+0xab/0xe9
> [<c0417223>] pmd_bad+0x44/0x53
> [<c046f37f>] follow_page+0x8b/0x1f2
> [<c0470aa0>] get_user_pages+0x281/0x2ef
hm. I suspect some gcc related difference related to the handling of
this masking:
pmd_val(x) & ~(PAGE_MASK | _PAGE_USER | _PAGE_PSE | _PAGE_NX)
versus:
pmd_val(x) & (~PAGE_MASK & ~_PAGE_USER)
perhaps it will work if you change it to:
pmd_val(x) & (~PAGE_MASK & ~_PAGE_USER & ~_PAGE_PSE & ~_PAGE_NX)
?
in any case, the commit has to be reverted as it clearly isnt a NOP on
your box as it was intended to be. (it should only have made a
difference in a rare hugetlbfs case)
Ingo
next prev parent reply other threads:[~2008-03-03 17:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 18:56 bisected boot regression post 2.6.25-rc3.. please revert Arjan van de Ven
2008-03-03 7:46 ` Ingo Molnar
2008-03-03 9:13 ` Ingo Molnar
2008-03-03 16:41 ` Arjan van de Ven
2008-03-03 17:40 ` Ingo Molnar [this message]
2008-03-03 17:51 ` Nish Aravamudan
2008-03-03 17:55 ` Ingo Molnar
2008-03-03 17:58 ` H. Peter Anvin
2008-03-03 18:36 ` Arjan van de Ven
2008-03-03 18:44 ` Linus Torvalds
2008-03-03 22:00 ` Arjan van de Ven
2008-03-04 1:05 ` Arjan van de Ven
2008-03-04 6:53 ` Ingo Molnar
2008-03-05 15:35 ` Arjan van de Ven
2008-03-09 11:56 ` Ingo Molnar
2008-03-09 17:27 ` Linus Torvalds
2008-03-09 18:57 ` Ingo Molnar
2008-03-10 2:45 ` Jeremy Fitzhardinge
2008-03-10 4:35 ` Paul Mackerras
2008-03-03 21:13 ` Segher Boessenkool
2008-03-03 21:22 ` Segher Boessenkool
2008-03-03 22:33 ` Segher Boessenkool
2008-03-03 22:55 ` H. Peter Anvin
2008-03-03 22:56 ` Jeremy Fitzhardinge
2008-03-03 23:04 ` H. Peter Anvin
2008-03-04 6:58 ` Ingo Molnar
2008-03-03 17:15 ` Nish Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303174009.GA19131@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@linux.intel.com \
--cc=hans.rosenfeld@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).