Re: Regression in 2.6.25-rc3: s2ram segfaults before suspending

From: Ingo Molnar <mingo@elte.hu>
To: "Klaus S. Madsen" <ksm@hjernemadsen.org>
Cc: Pavel Machek <pavel@ucw.cz>,
	Suspend-devel list <suspend-devel@lists.sourceforge.net>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Thomas Gleixner <tglx@linutronix.de>,
	Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: Regression in 2.6.25-rc3: s2ram segfaults before suspending
Date: Tue, 4 Mar 2008 13:42:41 +0100	[thread overview]
Message-ID: <20080304124241.GD29777@elte.hu> (raw)
In-Reply-To: <20080303205227.GU17932@hjernemadsen.org>

* Klaus S. Madsen <ksm@hjernemadsen.org> wrote:

> > are you sure you ID-ed the right commit that broke things?
>
> I can't be sure. It was my third attempt, and there seems to be some 
> sort of Makefile trouble in that area, which causes the problem to 
> appear and disappear at random, unless I do a make clean && make. But 
> the triggering commit was found with make clean && make, and I made 
> sure that reverting the resulting commit did actually solve the 
> problem...

btw., even if it turns out to be the wrong commit, you sure poked in the 
right general area. This is one of the reoccuring problems with git 
bisection: a small mistake near the end of a long bisection session can 
point to the wrong commit. Especially with more sporadic failure modes 
it can be quite a challenge.

	Ingo