linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Pavel Roskin <proski@gnu.org>,
	Zan Lynx <zlynx@acm.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jon Masters <jcm@jonmasters.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 2.6.25] module: allow ndiswrapper to use GPL-only symbols
Date: Tue, 4 Mar 2008 09:38:40 -0800	[thread overview]
Message-ID: <20080304173840.GA16165@suse.de> (raw)
In-Reply-To: <alpine.LFD.1.00.0803040907420.12253@woody.linux-foundation.org>

On Tue, Mar 04, 2008 at 09:19:36AM -0800, Linus Torvalds wrote:
> Quite frankly, my position on this has always been that the GPLv2 
> explicitly covers _derived_ works only, and that very obviously a Windows 
> driver isn't a derived work of the kernel. So as far as I'm concerned, 
> ndiswrapper may be distasteful froma technical and support angle, but not 
> against the license.

I think ndiswrapper is a great hack from a technical point-of-view.  But
yes, I also do not think it is a violation of the GPLv2 for the same
reasons you do.

> So I'm personally perfectly happy to say that we should revert that commit 
> 0aa5bd52d0c49ca56d24584c646e6544ccbb3dc9, but what I've wanted to hear 
> from the very beginning was simply to get a list of symbols that currently 
> clash, and hear from the people who maintain the symbols whether they 
> really meant for that commit to be valid.
> 
> That's the only issue here. Not whether ndiswrapper could do a part of its 
> job in user space (because the answer to that latter question is: no. 
> Everything is "possible", of course, but realistically, that's simply not 
> going to happen).
> 
> It sounds like there aren't that many symbols affected at the core: the 
> workqueue stuff certainly isn't worth bothering about. The USB things that 
> ndiswrapper wants is much more involved, and more likely to have issues, 
> but I'm cc'ing Greg here to see.

I have no objection to reverting that patch to have nidiswrapper access
to those symbols, especially as that is really the only way they will be
able to control USB devices (as you state, doing a network driver in
userspace doesn't really make sense.)

thanks,

greg k-h

  reply	other threads:[~2008-03-04 17:38 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28 22:11 [PATCH 2.6.25] module: allow ndiswrapper to use GPL-only symbols Pavel Roskin
2008-02-28 23:25 ` Linus Torvalds
2008-02-29  6:20   ` Pavel Roskin
2008-02-29 16:08     ` Linus Torvalds
2008-02-29 16:54       ` Chris Friesen
2008-02-29 17:06         ` Linus Torvalds
2008-02-29 17:59           ` Chris Friesen
2008-03-06 14:56         ` David Woodhouse
2008-02-29 16:59       ` Zan Lynx
2008-02-29 17:07         ` Linus Torvalds
2008-02-29 17:20           ` Pavel Roskin
2008-02-29 17:33             ` Linus Torvalds
2008-02-29 19:39               ` Pavel Roskin
2008-02-29 19:53                 ` Linus Torvalds
2008-02-29 20:08                   ` Pavel Roskin
2008-02-29 20:28                     ` Linus Torvalds
2008-02-29 21:13                       ` Pavel Roskin
2008-02-29 20:17                 ` John W. Linville
2008-02-29 20:40                   ` David Newall
2008-02-29 20:59                     ` Pavel Roskin
2008-02-29 21:08                       ` David Newall
2008-02-29 22:17                         ` Pavel Roskin
2008-03-01  8:15                           ` David Newall
2008-02-29 20:44                   ` Pavel Roskin
2008-02-29 21:15                 ` Ingo Molnar
2008-02-29 22:31                   ` Pavel Roskin
2008-03-03 10:57                     ` Ingo Molnar
2008-03-04  5:37                       ` Pavel Roskin
2008-03-04 12:57                         ` Ingo Molnar
2008-03-04 17:19                           ` Linus Torvalds
2008-03-04 17:38                             ` Greg KH [this message]
2008-03-04 17:45                             ` Pavel Roskin
2008-03-04 21:20                               ` Ingo Molnar
2008-03-04 23:23                                 ` Pavel Roskin
2008-03-04 20:51                             ` Ingo Molnar
2008-03-04 23:25                               ` Jiri Kosina
2008-03-05 13:21                                 ` Ingo Molnar
2008-02-29 17:18         ` Jon Masters
2008-02-29 21:55           ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080304173840.GA16165@suse.de \
    --to=gregkh@suse.de \
    --cc=jcm@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=proski@gnu.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@linux-foundation.org \
    --cc=zlynx@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).