From: Adrian Bunk <bunk@kernel.org>
To: jgarzik@pobox.com
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] make ata_eh_qc_retry() static
Date: Mon, 31 Mar 2008 02:05:56 +0300 [thread overview]
Message-ID: <20080330230556.GV28445@cs181133002.pp.htv.fi> (raw)
This patch makes the needlessly global ata_eh_qc_retry() static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 1 Mar 2008
drivers/ata/libata-core.c | 1 -
drivers/ata/libata-eh.c | 2 +-
include/linux/libata.h | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
cc00162dc4939d15b078f4cc2e8827b2d70a90db foobar
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b3d01c5..774ca30 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -7882,7 +7882,6 @@ EXPORT_SYMBOL_GPL(sata_async_notification);
EXPORT_SYMBOL_GPL(ata_eh_freeze_port);
EXPORT_SYMBOL_GPL(ata_eh_thaw_port);
EXPORT_SYMBOL_GPL(ata_eh_qc_complete);
-EXPORT_SYMBOL_GPL(ata_eh_qc_retry);
EXPORT_SYMBOL_GPL(ata_do_eh);
EXPORT_SYMBOL_GPL(ata_irq_on);
EXPORT_SYMBOL_GPL(ata_dev_try_classify);
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 698ce2c..90caf08 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1015,7 +1015,7 @@ void ata_eh_qc_complete(struct ata_queued_cmd *qc)
* scmd->retries is decremented for commands which get retried
* due to unrelated failures (qc->err_mask is zero).
*/
-void ata_eh_qc_retry(struct ata_queued_cmd *qc)
+static void ata_eh_qc_retry(struct ata_queued_cmd *qc)
{
struct scsi_cmnd *scmd = qc->scsicmd;
if (!qc->err_mask && scmd->retries)
diff --git a/include/linux/libata.h b/include/linux/libata.h
index a05f600..b626f27 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1058,7 +1058,6 @@ extern void ata_eh_freeze_port(struct ata_port *ap);
extern void ata_eh_thaw_port(struct ata_port *ap);
extern void ata_eh_qc_complete(struct ata_queued_cmd *qc);
-extern void ata_eh_qc_retry(struct ata_queued_cmd *qc);
extern void ata_do_eh(struct ata_port *ap, ata_prereset_fn_t prereset,
ata_reset_fn_t softreset, ata_reset_fn_t hardreset,
next reply other threads:[~2008-03-30 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-30 23:05 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-14 18:41 [RFC: 2.6 patch] make ata_eh_qc_retry() static Adrian Bunk
2008-03-01 16:20 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080330230556.GV28445@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).