From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/7] rxrpc, afs: Fix probing issues
Date: Thu, 27 Aug 2020 12:56:10 -0700 (PDT) [thread overview]
Message-ID: <20200827.125610.1855963268633335218.davem@davemloft.net> (raw)
In-Reply-To: <159854061331.1382667.9693163318506702951.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Thu, 27 Aug 2020 16:03:33 +0100
>
> Here are some fixes for rxrpc and afs to fix issues in the RTT measuring in
> rxrpc and thence the Volume Location server probing in afs:
>
> (1) Move the serial number of a received ACK into a local variable to
> simplify the next patch.
>
> (2) Fix the loss of RTT samples due to extra interposed ACKs causing
> baseline information to be discarded too early. This is a particular
> problem for afs when it sends a single very short call to probe a
> server it hasn't talked to recently.
>
> (3) Fix rxrpc_kernel_get_srtt() to indicate whether it actually has seen
> any valid samples or not.
>
> (4) Remove a field that's set/woken, but never read/waited on.
>
> (5) Expose the RTT and other probe information through procfs to make
> debugging of this stuff easier.
>
> (6) Fix VL rotation in afs to only use summary information from VL probing
> and not the probe running state (which gets clobbered when next a
> probe is issued).
>
> (7) Fix VL rotation to actually return the error aggregated from the probe
> errors.
>
> The patches are tagged here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
> rxrpc-fixes-20200820
Pulled, thanks David.
prev parent reply other threads:[~2020-08-27 19:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 15:03 [PATCH net 0/7] rxrpc, afs: Fix probing issues David Howells
2020-08-27 15:03 ` [PATCH net 1/7] rxrpc: Keep the ACK serial in a var in rxrpc_input_ack() David Howells
2020-08-27 15:03 ` [PATCH net 2/7] rxrpc: Fix loss of RTT samples due to interposed ACK David Howells
2020-08-27 15:03 ` [PATCH net 3/7] rxrpc: Make rxrpc_kernel_get_srtt() indicate validity David Howells
2020-08-27 15:04 ` [PATCH net 4/7] afs: Remove afs_vlserver->probe.have_result David Howells
2020-08-27 15:04 ` [PATCH net 5/7] afs: Expose information from afs_vlserver through /proc for debugging David Howells
2020-08-27 15:04 ` [PATCH net 6/7] afs: Don't use VL probe running state to make decisions outside probe code David Howells
2020-08-27 15:04 ` [PATCH net 7/7] afs: Fix error handling in VL server rotation David Howells
2020-08-27 19:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827.125610.1855963268633335218.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).