From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Prarit Bhargava <prarit@redhat.com>,
Mark Salyzyn <salyzyn@android.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Orson Zhai <orsonzhai@gmail.com>,
Changki Kim <changki.kim@samsung.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 2/2] printk: Add more information about the printk caller
Date: Thu, 24 Sep 2020 11:17:56 +0900 [thread overview]
Message-ID: <20200924021756.GD577@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20200923135617.27149-3-pmladek@suse.com>
On (20/09/23 15:56), Petr Mladek wrote:
[..]
> /*
> * To reduce unnecessarily reopening, first check if the descriptor
> - * state and caller ID are correct.
> + * state and caller infromation are correct.
> */
> - d_state = desc_read(desc_ring, id, &desc, NULL, &cid);
> - if (d_state != desc_committed || cid != caller_id)
> + d_state = desc_read(desc_ring, id, &desc, NULL, &cal);
> + if (d_state != desc_committed ||
> + cal.pid != caller->pid ||
> + cal.cpu_ctx != caller->cpu_ctx) {
You probably might want to factor out ctx check into a static
inline helper. Since you use this check in several places, and
we may check more context fields in the future.
[..]
> +/* Information about the process and context that adds the message */
> +struct printk_caller {
> + pid_t pid; /* thread id */
> + u32 cpu_ctx; /* processor id and interrupt context */
> +};
A question. Suppose we have a task which does
CPU0
pr_err(...);
preempt_disable();
pr_err(...);
preempt_enable();
pr_err(...);
rcu_read_lock();
pr_info(...);
rcu_read_unlock();
Should we distinguish those as 3 different contexts?
- normal printk
- printk under disabled preemption (affects scheduling)
- printk under RCU read side lock (affects RCU grace periods)
-ss
next prev parent reply other threads:[~2020-09-24 2:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 13:56 [RFC 0/2] printk: Add more metadata for each record Petr Mladek
2020-09-23 13:56 ` [PATCH 1/2] printk: Store all three timestamps Petr Mladek
2020-09-23 22:12 ` John Ogness
2020-09-24 1:45 ` Sergey Senozhatsky
2020-09-24 11:49 ` Petr Mladek
[not found] ` <CAJ-C09hqwOJhSXx1h40q96xhNZFXxP6dUVfjUQZpO4ZhOMZLbQ@mail.gmail.com>
2020-09-25 9:51 ` Petr Mladek
2020-09-24 0:00 ` John Ogness
2020-09-24 10:37 ` Petr Mladek
2020-09-23 13:56 ` [RFC 2/2] printk: Add more information about the printk caller Petr Mladek
2020-09-24 1:40 ` Sergey Senozhatsky
2020-09-24 11:58 ` Petr Mladek
2020-09-24 2:17 ` Sergey Senozhatsky [this message]
2020-09-24 8:23 ` John Ogness
2020-09-24 13:26 ` Petr Mladek
2020-09-24 13:06 ` Petr Mladek
2020-09-24 4:24 ` Ahmed S. Darwish
2020-09-24 12:53 ` Petr Mladek
2020-09-24 13:38 ` Petr Mladek
2020-09-25 0:54 ` Sergey Senozhatsky
2020-09-25 10:20 ` Petr Mladek
2020-10-21 11:48 ` 김창기
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924021756.GD577@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=changki.kim@samsung.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=pmladek@suse.com \
--cc=prarit@redhat.com \
--cc=rostedt@goodmis.org \
--cc=salyzyn@android.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).