From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3F6C433E6 for ; Tue, 22 Dec 2020 14:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50C5723130 for ; Tue, 22 Dec 2020 14:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727431AbgLVOFh (ORCPT ); Tue, 22 Dec 2020 09:05:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726868AbgLVOFh (ORCPT ); Tue, 22 Dec 2020 09:05:37 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF997C0613D3; Tue, 22 Dec 2020 06:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DxJqoJ8PnZK608eAZuGRcAj/J+cjWwjqs4ZUdTA2aew=; b=Wk0QyNPy3C7mnC8JzcEbs7bvSx ozNMMdU8xG2atPmKs5376oVfRxkJIVdFdrKtl2H+yVycLYEyCN5/KErhmQ7HlYH5spEQ+OBxzePES fzTTHU4psBg+4K1MNT4mWu1vr+rUS9JyISGryO9MeVUuq1zXfuiu/N2BfoJ/tDz2xip/4liR36iwG U4xmkNIHV9G8zFqFtZbkduhNh2YrClKJ1TG+drl9Nl9/1tfWcxO+pbSoRciPdzOEaRhwSv8RRU0FQ tGul94ouWAU8VpNmAsLvphJ0llkmVPz4nUXj2PHJJYkjHiHLESJo6fSQww5RaGcZmBT3Z/4Nc90k+ CBkCCo9A==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kriHX-0003Xe-5N; Tue, 22 Dec 2020 14:04:55 +0000 Date: Tue, 22 Dec 2020 14:04:55 +0000 From: Christoph Hellwig To: Pavel Begunkov Cc: linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Matthew Wilcox , Ming Lei , Johannes Weiner , Alexander Viro , "Darrick J . Wong" , "Martin K . Petersen" , Jonathan Corbet , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v1 3/6] bio: deduplicate adding a page into bio Message-ID: <20201222140455.GB13079@infradead.org> References: <189cae47946fa49318f85678def738d358e8298b.1607976425.git.asml.silence@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <189cae47946fa49318f85678def738d358e8298b.1607976425.git.asml.silence@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If it was up to me I'd shorten noaccount to noacct. Otherwise looks good: Reviewed-by: Christoph Hellwig